Eliminate List

[Nick Davenport]

I have a class that fetches a record but dont think I need to use List object because I am fetching one record and not an array of records.
Please advise the best way to change the below class where I assume I should use something different instead of List? Maybe HashMap? Not sure how to do this?

public List getRecords(){
        ResultSet rs = null;
        Statement stmt = null;
        Connection connection = null;
 
        List rows = new ArrayList();
        
        try
        {
            Class.forName("org.gjt.mm.mysql.Driver");
            connection = DriverManager.getConnection("jdbc:mysql://localhost/dbase?user=myname&password=thepassword");
            stmt = connection.createStatement();
            rs = stmt.executeQuery("SELECT * from user where userid = 10");  
            
            while(rs.next()){
            RowBean row = new RowBean();
            row.setFirstname(rs.getString("firstname"));
            row.setLastname( rs.getString("lastname"));
            rows.add(row); 
            .....

[A Kumar]

If you are getting a single record of RowBean as in your code...

just return the same...

[Rob Spoor]

public RowBean getRecord()
{
    ResultSet rs = null;
    Statement stmt = null;
    Connection connection = null;
 
    RowBean bean = null;
        
    Class.forName("org.gjt.mm.mysql.Driver");
    connection = DriverManager.getConnection("jdbc:mysql://localhost/dbase?user=myname&password=thepassword");
    stmt = connection.createStatement();
    rs = stmt.executeQuery("SELECT * from user where userid = 10");  
     // you don't need to loop - just check once
    if (rs.next())
    {
        bean = new RowBean();
        row.setFirstname(rs.getString("firstname"));
        row.setLastname( rs.getString("lastname"));
    }
    // else you can throw an exception if you like, or just keep
    // bean to null
 
    return bean;
}

try-catch-finally block and closing of resources omitted for brevity.

[Nick Davenport]

Thanks it works great.

Is this an example of DTO (Data Transfer Object)?

[Jeanne Boyarsky]

Originally posted by Nick Davenport:
Is this an example of DTO (Data Transfer Object)?

Yes it is.