execute method in SQl

[dhwani mathur]

hi all

i am trying to create a login form
in which i take user name ,email id and password.
if the user is registered user the name ,id and password
are stored into database in table.So when the user logs in
i wanted to check by traversing through the database
that the name and password are right so previuosly
i was using
ResultSet rs;
rs.next(); method so it traverses
through all the registered name in database
but i felt this as abit long
so i choose execute () method which returns boolean value
if it gets the exact name and password but

below is my method

  <%
boolean b=false;
try{
b=statement.execute("select * from userinfo where name='"+name+"' and password='"+passw+"'");
out.println(b);[B]//verified value of b by using out.print();[/B]
if(b==true)[B]//b must be true only if value is present in database[/B]
{
response.sendRedirect("welcome.jsp");
}
%>  

each time the query gets executed
if the user is not registered ie user name is not present
in the database then also i am getting value of b=true
whereas i expect if user name and password is not present
it must give b=false.


i dont know where i am going wrong ?

may be the method which i have used is not appropriate
for use at this place.........


Anyone can help me on to what i must use
or where i am going wrong it will be realy great
thanks in advance.............

Dhwani:>Its always too soon to quit.

[Shailesh Chandra]

Dhwani As per java-docs

boolean execute(String sql)throws SQLException

Returns:
true if the first result is a ResultSet object; false if it is an update count or there are no results

therefore if your query is executed successfully then It will definitely return a resultset.

If there are no matching rows as per given criteria resultset.next() will be false. That is why you get true every time.

you modify your code
as

int count=0;
ResultSet rs = statement.executeQuery("select count(*) user_count 
from userinfo where name='"+name+"' and password='"+passw+"'");
 
if(rs.next()){
count =  rs.getInt("user_count");
}
 
if (count >0)
{
//value is present in database
response.sendRedirect("welcome.jsp");
 
}

Thanks,
Shailesh
[ February 04, 2008: Message edited by: Shailesh Chandra ]

[dhwani mathur]

hi shailesh!!!

Thanks for such a great reponse

i modified the query as shown by you as below

but i am stuck now somewhere else

  int count=0;

try{
rs=statement.executeQuery("select * from userinfo where   name='"+name+"' and password='"+passw+"'");
    if(rs.next()){
    count=rs.getInt("select count(*) from userinfo where name='"+name+"'");
    }
if(count>0){
session.setAttribute("name",name);
response.sendRedirect("welcome.jsp");
}
}
catch(SQLException e){
e.printStackTrace();
}  

i am storing this values when the user registers
in a table ,and when the user logs in the name and password is getting
verified in my query above
when i use statement as

[B]select * from userinfo where name='"+name+"'
i am getting result in resultset object ie user name exist
[/B]

but i want to verify not only name before logging in
but also password so i used query as

[B]("select * from userinfo where   name='"+name+"' and password='"+passw+"'");
as i use password field i am not getting anything into
resultset i dont know what going wrong 
i have checked values coming in name and passw field 
they are right as well as present in table............
in table for password i have used value as varchar
[/B]

any help on the above will be
realy great

thanks in advance!!

Dhwani:>Winning is not important but it is the only thing.
[ February 04, 2008: Message edited by: dhwani mathur ]

[Shailesh Chandra]

Check the case-sensitivity of the password

user out.println to print your query, which is formed by code, and execute same or sql console

dhwani,

validate above mentioned steps


Thanks,
Shailesh

[dhwani mathur]

Hi shailesh!!

Thanks a lot
my problem is solved......


Dhwani:>Winning is not important but it is the only thing.
[ February 06, 2008: Message edited by: dhwani mathur ]

[Shailesh Chandra]

glad to know that its working now


Thanks,
Shailesh