BMP -last inserted record alone gets fetched

[Nandini Sriram]

Hi,
I use JBoss and MySql. I am trying to run an entity bean (BMP). I have the following classes: ProdHome, ProdRem, ProdPK (Primary Key), ProdBean and ProdClient. Everything works fine, but the "findByName(String name)" always returns the last inserted row details.

ProdBean.java

 ......
 public Enumeration ejbFindByName(String name) throws RemoteException,
        FinderException {
        Vector vec=new Vector();        
        Connection con=null;
        PreparedStatement ps=null;
        ResultSet rs=null;
        try {
            String sql="SELECT *"+
            " FROM ProductsBMP"+
            " WHERE ProductName=?";
            con=getConnection();
            ps=con.prepareStatement(sql);
            ps.setString(1,name);                  
            rs=ps.executeQuery();
            while (rs.next()) {
                int prodID=rs.getInt(1);          
                vec.addElement (new ProdPK(Integer.toString(prodID)));               
            }           
        }
        catch (Exception ex) {ex.toString();}
        finally {
            try {
                if (rs!=null) {rs.close();}
                if (ps!=null) {ps.close();}
                if (con!=null) {con.close();}
            }
            catch(Exception ex) {ex.toString();}            
        }       
        return vec.elements();
       
    }//end findbyname
    ......

ProdClient.java

public class ProdClient {
    public static void main(String[] ag) {
        Properties props=new Properties();
        props.put(Context.INITIAL_CONTEXT_FACTORY,
                  "org.jnp.interfaces.NamingContextFactory");
        props.put(Context.PROVIDER_URL,"localhost:1099");        
        try {               
            ProdRem remote=null;
            InitialContext ic=new InitialContext(props);
            System.out.println("Got Context");
            Object ref=ic.lookup("Prod-BMP");
            System.out.println("Got Bean reference");
 
            ProdHome home=(ProdHome)PortableRemoteObject.narrow(ref,ProdHome.class);                 
            //inserting rows in the DB
            home.create(22,"Oswald Dinner Set","Porcelain 5-piece set",15.50);                     
            home.create(23,"Crystal Lotus Pairs","6-inch crystal piece",29.99);        
            home.create(24,"Sams Learn Java","Book for beginners",15.99);    
          
            Enumeration enu=home.findByName("Crystal Lotus Pair");             
            while(enu.hasMoreElements()) {        
                remote=(ProdRem)enu.nextElement();
                System.out.println("Id: "+remote.getProdID());
                System.out.println("Name: "+remote.getProdName());
                System.out.println("Description: "+remote.getDesc());
                System.out.println("Price: "+remote.getPrice());
            }                                              
        }
        catch(Exception ex) {ex.toString();}        
    }// end main method
}// end class
 

The records get inserted in the DB. But it keeps printing the "Sams Learn Java" details for the findByName() method.
Please help me figure out where my mistake lies.

Regards,
Nandini

[Kyle Brown]

It might be helpful to see your ejbLoad() method.

Kyle

[Nandini Sriram]

Hello,
Here is the ejbLoad().

...
public void ejbLoad() {
        Connection con=null;
        PreparedStatement ps=null;
        ResultSet rs=null;
        try {
            String sql="SELECT ProductName,Description,Price"+
            " FROM ProductsBMP"+
            " WHERE ProductID=?";
            con=getConnection();
            ps=con.prepareStatement(sql);
            ps.setInt(1,prodID);
            rs=ps.executeQuery();
            if (rs.next()) {
                prodName=rs.getString("ProductName");
                desc=rs.getString("Description");
                price=rs.getDouble("Price");
            }
        }
        catch (Exception ex) {ex.toString();}
        finally {
            try {
                if (rs!=null) {rs.close();}
                if (ps!=null) {ps.close();}
                if (con!=null) {con.close();}
            }
            catch(Exception ex) {ex.toString();}            
        }                                  
    }// end ejbLoad
...

Regards,
Nandini

[Kyle Brown]

In your ejbLoad, where are you getting the prodID instance variable value from? Normally in a BMP wha happens is you go to the EntityContext to get the primary key object, and then use THAT value for the key value of your WHERE statement. My guess is since you're not doing that that prodID gets set once somewhere in your EJB class, and you keep using that same value.

I can't be certain because I don't see where you've set the prodID instance variable in your class.

Also -- you're eating all possible exceptions in your ejbLoad() method -- that will make it hard to debug problems -- print out the exception values instead of just dropping them.

Kyle

[Nandini Sriram]

Kyle,
Thanks for your help. I don't know how I missed these lines in ejbLoad().

ProdPK key=(ProdPK)ec.getPrimaryKey();
int prodID=Integer.parseInt(key.prodID);

The problem is this - JBoss server requires to be re-started every time for the correct values to be fetched by the ejbFindByName() method.

Regards,
Nandini