UnZip error

[benny rusli]

Hello Everybody,
i have a following code to unzip a zip file, but if i try to unzip
with the command: java UnZip C:\backup_11-02-05_10-03-PM.zip.
There is a error which throw :
Extracting : c:\DA\backup_pro.java
java.io.FileNotFoundException : c:\DA\backup_pro.java
at.java.io.FileOutputStream.open<Native Method>
at.java.io.FileOutputStream.<init><FileOutputStream.java:179>
at.java.io.FileOutputStream.<init><FileOutputStream.java:131>
at UnZip.main<UnZip.java:64>
if i try to open with winzip there is no error, besides that i try to open another zip file with this program and the program could be opened without problem.

import java.util.zip.*;
import java.io.*;
import java.util.*;
 
public class UnZip
{
  public static final int EOF = -1;
  public static void main( String args[] )
  {
    Enumeration e;
    if ( args.length == 1 )
    {
      try {
        ZipFile zf = new ZipFile( args[0] );
        e = zf.entries();
        while ( e.hasMoreElements() )
        {
          ZipEntry target = (ZipEntry)e.nextElement();
          saveEntry( zf, target );
        }
      }
      catch( FileNotFoundException ee ) 
      {
        System.out.println( "zipfile not found"+ee );
      }
      catch( ZipException ee ) 
      {
        System.out.println( "zip error..."+ee );
      }
      catch( IOException ee ) 
      {
        System.out.println( "IO error..."+ee );
      }
    }
    else
      System.out.println( "Usage:java UnZip zipfile" );
  }
  public static void saveEntry( ZipFile zf, ZipEntry target ) throws ZipException,IOException
  {
    try
    {
      File file = new File( target.getName() );
      if ( target.isDirectory() )
        file.mkdirs();
      else
      {
        InputStream is = zf.getInputStream( target );
        BufferedInputStream bis = new BufferedInputStream( is );
        File dir = new File( file.getParent() );
        dir.mkdirs();
        FileOutputStream fos = new FileOutputStream( file );
        BufferedOutputStream bos = new BufferedOutputStream(fos);
        int c;
        while ( ( c = bis.read() ) != EOF )            
        bos.write( (byte)c );
        bos.close();
        fos.close();
      }
    }
    catch( IOException ioe ) 
    {
        System.out.println(ioe);
    }
  }
}

And i try another program from http://www.devshed.com/c/a/Java/Zip-Meets-Java/2/ but without success

import java.io.BufferedInputStream;
import java.io.BufferedOutputStream;
import java.io.File;
import java.io.FileOutputStream;
import java.io.IOException;
import java.util.Enumeration;
import java.util.zip.ZipEntry;
import java.util.zip.ZipFile;
public class ZipUncompressExample
{
 
   // specify buffer size for extraction
   static final int BUFFER = 2048;
 
   public static void main(String[] args)
   {
     try
     {
       System.out.println("Example of ZIP file decompression.");
 
       // Specify file to decompress
       String inFileName = "c:\\backup_11-02-05_10-03-PM.zip";
       // Specify destination where file will be unzipped
       String destinationDirectory = "c:\\temp";
 
       File sourceZipFile = new File(inFileName);
       File unzipDestinationDirectory = new File(destinationDirectory);
 
       // Open Zip file for reading
       ZipFile zipFile = new ZipFile(sourceZipFile, ZipFile.OPEN_READ);
 
       // Create an enumeration of the entries in the zip file
       Enumeration zipFileEntries = zipFile.entries();
 
       // Process each entry
       while (zipFileEntries.hasMoreElements())
       {
         // grab a zip file entry
         ZipEntry entry = (ZipEntry) zipFileEntries.nextElement();
 
         String currentEntry = entry.getName();
         System.out.println("Extracting: " + entry);
 
         File destFile =
           new File(unzipDestinationDirectory, currentEntry);
 
         // grab file's parent directory structure
         File destinationParent = destFile.getParentFile();
 
         // create the parent directory structure if needed
         destinationParent.mkdirs();
 
         // extract file if not a directory
         if (!entry.isDirectory())
         {
           BufferedInputStream is =
             new BufferedInputStream(zipFile.getInputStream(entry));
           int currentByte;
           // establish buffer for writing file
           byte data[] = new byte[BUFFER];
 
           // write the current file to disk
           FileOutputStream fos = new FileOutputStream(destFile);
           BufferedOutputStream dest =
           new BufferedOutputStream(fos, BUFFER);
 
           // read and write until last byte is encountered
           while ((currentByte = is.read(data, 0, BUFFER)) != -1)
           {
             dest.write(data, 0, currentByte);
           }
           dest.flush();
           dest.close();
           is.close();
         }
       }
       zipFile.close();
     }
     catch (IOException ioe)
     {
     ioe.printStackTrace();
     }
   }
}

I think the problem special character such as "_/-%���" from within(or because the name of zip file "backup_11-02-05_10-03-PM.zip") the zip file, but i do not sure, if yes ? how do i overcome the problem ?
Can someone give me a hint ? thank you very much

[Stefan Wagner]

Unfortunately, line 64 is...

    catch( IOException ioe ) 
    {
        System.out.println(ioe);
    }
  } // <---------- here!
}

Why does the jvm tell you the linenumber?
Perhaps to make the source of error easy to find?

Try in the saveEntry Method:

InputStream is = zf.getInputStream( target );
BufferedInputStream bis = new BufferedInputStream( is );
System.out.println ("Target: " + target.toString ());

and ask yourself, if it is, what you expected...

[benny rusli]

Hallo everybody,
hallo Stefan, what do you mean with line 64, i think line 64 is not wrong.
I try another program code, but i got not success, the error is the same and if the zip file consist of subdirectory and ���(umlaute or special character), the program won't unzip it but if the zip file only consist of one directory without special character, it will be successfully. I have read many forum, they said that the problem is in encode and decode the special character(it is recommended to use UTF-8 or UTF-16). Is that right ? but how should i use it. Any Help will be appreciated.

import java.io.*;
import java.util.*;
import java.util.zip.*;
 
public class Unzip {
 
  public static final void copyInputStream(InputStream in, OutputStream out)
  throws IOException
  {
    byte[] buffer = new byte[1024];
    int len;
 
    while((len = in.read(buffer)) >= 0)
      out.write(buffer, 0, len);
 
    in.close();
    out.close();
  }
 
  public static final void main(String[] args) {
    Enumeration entries;
    ZipFile zipFile;
 
    if(args.length != 1) {
      System.err.println("Usage: Unzip zipfile");
      return;
    }
 
    try {
      zipFile = new ZipFile(args[0]);
 
      entries = zipFile.entries();
 
      while(entries.hasMoreElements()) {
        ZipEntry entry = (ZipEntry)entries.nextElement();
 
        if(entry.isDirectory()) {
          // Assume directories are stored parents first then children.
          System.err.println("Extracting directory: " + entry.getName());
          // This is not robust, just for demonstration purposes.
          (new File(entry.getName())).mkdir();
          continue;
        }
 
        System.err.println("Extracting file: " + entry.getName());
        copyInputStream(zipFile.getInputStream(entry),
           new BufferedOutputStream(new FileOutputStream(entry.getName())));
      }
 
      zipFile.close();
    } catch (IOException ioe) {
      System.err.println("Unhandled exception:");
      ioe.printStackTrace();
      return;
    }
  }
 
}

[benny rusli]

Hallo everybody,
i have a new problem, if i jar a 11GB Files with my programm code, there is no problem but if i unjar it, there is an error like this :
java.util.zip.ZipException : zip file too large
how can i overcome the problem ?

public static void extractjar(String destDir,String jarFile)
    {
try
{
   int buffersize = 1024;
   byte[] buffer = new byte[buffersize];
           java.util.jar.JarFile jar = new java.util.jar.JarFile(jarFile);
           java.util.Enumeration e = jar.entries();
           while(e.hasMoreElements()) 
           {
      java.util.jar.JarEntry file = (java.util.jar.JarEntry)e.nextElement();
      java.io.File f = new java.io.File(destDir + java.io.File.separator + file.getName());
      if(file.isDirectory()) 
      { // if its a directory, create it
f.mkdir();
continue;
      }
      java.io.InputStream is = jar.getInputStream(file); // get the input stream
      java.io.BufferedInputStream bis = new java.io.BufferedInputStream(is);
      java.io.FileOutputStream fos = new java.io.FileOutputStream(f);
      java.io.BufferedOutputStream bos = new java.io.BufferedOutputStream(fos);
      int count = 0;
      while (( count = bis.read(buffer,0,buffersize)) != -1)      
      {  // write contents of 'is' to 'fos'
bos.write(buffer,0,count);  
      }
      bos.close();
      bis.close();
      fos.close();
      is.close();
   }
        }
catch(java.io.IOException ioe)
{
            System.out.println(ioe);
}
}