Problems with encoding and files

[Mercurio Savedra]

Hi friends pls some help my problems is the following

I have a ftp server running on linux and in my program I download files from the ftp server using class specified below.When I download the file content not all content is coming ok. For example I have a string with
Ra�l����1234%#=?[a_@ and when I read content using my methods this part is retirved ok Ra and this one is retrived wrong �����
whith characteres very stranges.

I suppose that the problem is with the encoding, then all day I tried some settings in the class new InputStreamReader.First the encoding UTF-8 because I have created the file using this encoding. Something like this:

in = new InputStreamReader(new GZIPInputStream(localFtp.get(serverFile)),"UTF-8");

but does not work

After I realized that I use the statement localFtp.ascii();
declaring that the content will be downloaded in ascii encoding so
I made this change :

in = new InputStreamReader(new GZIPInputStream(localFtp.get(serverFile)),"US-ASCII");

but still does not work

Please somebody can help me this is very urgent

Here is my code

Tkx

import java.io.BufferedInputStream;
import java.io.BufferedReader;
import java.io.FileInputStream;
import java.io.IOException;
import java.io.InputStreamReader;
import java.util.ArrayList;
import java.util.Vector;
import java.util.ResourceBundle;
import java.util.regex.Pattern;
import java.util.zip.GZIPInputStream;
 
import org.apache.log4j.Logger;
import org.apache.log4j.PropertyConfigurator;
 
import com.banesco.lynx.common.SunFtpWrapper;
import com.banesco.lynx.exceptions.FtpManagerException;
 
import org.apache.log4j.Logger;
import org.apache.log4j.PropertyConfigurator;
 

 
public class FtpManager extends SunFtpWrapper{
 
ProcessParametersHelper parametersManager=ProcessParametersHelper.newInstance();
ResourceBundle rb = ResourceBundle.getBundle("com.banesco.lynx.exceptions.lynx_exceptions");
private Logger logger =null;
 
public FtpManager(int i) throws FtpManagerException {
logger = Logger.getLogger(FtpManager.class);
PropertyConfigurator.configure(parametersManager.getLog4j_path());
 
//0 connect to source server 
//1 connect to destiny server
 
if(i==0)  
connectToSourceServer(this);
else if (i==1)
connectToDestinyServer(this); 
}
 
private void connectToSourceServer(FtpManager ftp)throws FtpManagerException{
try{
ftp.openServer(parametersManager.getSourceServerInfo().getIp());
ftp.login(parametersManager.getSourceServerInfo().getUserName(), parametersManager.getSourceServerInfo ().getPassword());
}
catch (IOException e) {
//log error
logger.error("Ha ocurrido un error la descripcion del error  es :" + e.getMessage());
throw new FtpManagerException(Integer.toString(FtpManagerException.CRITICAL),rb.getString("error.ftpmanager.openconnection"));
}
}
 
private void connectToDestinyServer(FtpManager ftp)throws FtpManagerException{
try{
ftp.openServer(parametersManager.getDestinyServerInfo().getIp());
ftp.login(parametersManager.getDestinyServerInfo().getUserName(), parametersManager.getDestinyServerInfo().getPassword());
}
catch (IOException e) {
//log error
logger.error("Ha ocurrido un error la descripcion del error  es :" + e.getMessage());
throw new FtpManagerException(Integer.toString(FtpManagerException.CRITICAL),rb.getString("error.ftpmanager.openconnection"));
}
}
 
public ArrayList downloadFileIntoMemory (String path,String serverFile, boolean isZipped) throws FtpManagerException {
 
int i = 0;
InputStreamReader in = null;
ArrayList response = new ArrayList();
FtpManager localFtp=null;
 
try{
localFtp=new FtpManager(0);
localFtp.cd(path);
//TODO modifico encoding
// moving file content from ftp server into memory 
if (isZipped)
{  localFtp.binary();
in = new InputStreamReader(new GZIPInputStream(localFtp.get(serverFile)));
}
else
{ 
localFtp.ascii();
in = new InputStreamReader(localFtp.get(serverFile));
}
// moving file content from memory into arraylist
BufferedReader reader = new BufferedReader(in);
String l = null;
while ( (l = reader.readLine()) != null)
{
response.add(l);
}
}
catch(IOException e){
//TODO quitar esto
e.printStackTrace();
//log error
logger.error("Ha ocurrido un error la descripcion del error  es :" + e.getMessage());
throw new FtpManagerException(Integer.toString(FtpManagerException.CRITICAL),rb.getString            ("error.ftpmanager.downloadfile"));
 
} 
catch (FtpManagerException e) {
//log error
logger.error("Ha ocurrido un error la descripcion del error  es :" + e.getMessage());
throw new FtpManagerException(Integer.toString(FtpManagerException.CRITICAL),rb.getString               ("error.ftpmanager.downloadfile"));
 
}
finally{
try{
localFtp.disconnect();
}catch(FtpManagerException e){
//log error
logger.error("Ha ocurrido un error la descripcion del error  es :" + e.getMessage());
throw new FtpManagerException(Integer.toString(FtpManagerException.CRITICAL),rb.getString                   ("error.ftpmanager.closeconection"));
 
}
}
return response;
}
 

 

}

[Mercurio Savedra]

I forgot this

import sun.net.ftp.FtpClient;
 
import java.util.ArrayList;
import java.util.Vector;
import java.io.*;
import java.util.zip.*;
 
/**
 * This is a basic wrapper around the sun.net.ftp.FtpClient
 * class, which is an undocumented class which is included
 * with Sun Java that allows you to make FTP connections
 * and file transfers.
 * <p>
 * Program version 1.0. Author Julian Robichaux, <a href="http://www.nsftools.com" target="_blank" rel="nofollow">http://www.nsftools.com</a>
 *
 * @author Julian Robichaux ( <a href="http://www.nsftools.com" target="_blank" rel="nofollow">http://www.nsftools.com</a> )
 * @author Jpuerta (modified by)
 * @version 1.0
 */
public class SunFtpWrapper extends FtpClient {
/*
 * Methods you might use from the base FtpClient class
 * // set the transfer type to ascii
 * public void ascii()
 * 
 * // set the transfer type to binary
 * public void binary()
 *// change to the specified directory
 * public void cd(String remoteDirectory)
 * 
 * // download the specified file from the FTP server
 * public TelnetInputStream get(String filename)
 */
 
}

Tkx

[Alonso Faust]

To make sure I understand your problem correctly:
Your string should be received as: "Ra�l����1234%#=?[a_@"
Your string is received as Ra+jibber
Correct?

[Peter Chase]

Surely, if you've downloaded a non-ASCII file using ASCII encoding, you've already broken it. So it doesn't matter what encoding you use for reading after downloading it - you may be unable to fix it, because information may have been lost/corrupted. Trying to use "US-ASCII" for reading is never going to give good values for non-ASCII characters.

Shouldn't you download the file in binary?