add a Canvas to a JPanel within a JFrame

[samifox]

hi there!
i extends Canvas and i draw image in it like this :

public class testImage extends JFrame{

  public testImage(){
    imageViewer m = new imageViewer("http://127.0.0.1/image/samifox.gif");
    getContentPane().add(m);
  }
  public static void main(String[] args) {
    JFrame frame = new testImage();
    frame.addWindowListener(new WindowAdapter() {
        public void windowClosing(WindowEvent e) {
          System.exit(0);
        }
      });
      //frame.pack();
      frame.setSize(300,300);
      frame.setVisible(true);
  }
}
class imageViewer extends Canvas{
  Image image;
  URL url;
  Toolkit tool;
  public imageViewer(String path){
    initImage(path);
  }
  public void initImage(String path){
    try{
      url = new URL(path);
    }catch(Exception e){
      System.out.println(e.toString());
    }
    image = Toolkit.getDefaultToolkit().getImage(url);
    setImage(image);
  }
  void setImage(Image image){
    this.image = image ;
    repaint() ;
  }
  public void paint(Graphics g){
    super.paint(g) ;
    try{
       g.drawImage(image,0,0,this) ;
       g.drawString("ssss",25,25);
    } catch (NullPointerException e) {
          System.out.println(e.toString());
    }
  }
}

th problem is when i try to put the class instance on a JFrame and user add() , the Canvas doesnt appear ,
this is how i test it :

//xxx
import javax.swing.*;
import javax.swing.text.*;
import java.awt.*;              //for layout managers
import java.awt.event.*;        //for action and window events
import com.borland.jbcl.layout.*;
public class testPanel extends JFrame{
  myJPane mypanel;
  imageViewer imgViewer;
   public testPanel(){
   mypanel = new myJPane();
  }

  public static void main(String[] args) {
    JFrame frame = new testPanel();
    frame.addWindowListener(new WindowAdapter() {
        public void windowClosing(WindowEvent e) {
          System.exit(0);
        }
      });
      //frame.pack();
      frame.setSize(300,300);
      frame.setVisible(true);
  }
}

class myJPane extends JPanel{
  imageViewer imgViewer;
  public myJPane(){
  setLayout(new GridLayout(2,2));
  imgViewer = new imageViewer("http://127.0.0.1/image/samifox.gif");
  add(imgViewer);
  validate();
  }
}

thanks in advance
Shay



[This message has been edited by samifox (edited September 03, 2001).]

[Cindy Glass]

Please change your name to be compliant with JavaRanch's naming policy.
Your ID should be 2 separate names with more than 1 letter each. We really want this to be a professional forum and would prefer that you use your REAL name.
Thanks,
Cindy
I am moving this thread to the AWT/Swing forum.

[Geoffrey Falk]

You need to do two things (I think):
- Use a layout managerin your Frame; e.g. GridLayout(1,1)
- implement getPreferredSize() in your Canvas so that the layout manager knows how big it should be.
Note this is based on AWT. I don't know if Swing works exactly the same way.

[Paul Stevens]

Remove the call to super in the paint method and the string gets drawn. I didn't see the image though.