Not refreshing...

[Chris Stewart]

I'm basically trying to move cards left or right based on their starting location. I have some logic which selects two cards (JLabels) and passes them to this method. After each movement (setBounds()), I try and refresh to show their current position but it doesn't happen. Any ideas?

private void moveCards(JLabel card1, JLabel card2)
  {
    boolean flag = true;
    int xOneIn, xTwoIn;
    int xOne = card1.getX();
    int xTwo = card2.getX();
    if(xOne > xTwo)
    {
      System.out.println("xOne was greater than xTwo");
      while(flag)
      {
        xOneIn = card1.getX();
        xTwoIn = card2.getX();
        try
        {
          Thread.sleep(50);
        } catch (InterruptedException ex) {}
        card1.setBounds((xOneIn - 10), 110, 73, 97);
        card2.setBounds((xTwoIn + 10), 110, 73, 97);
        System.out.println("xOneIn After set: " + xOneIn);
        System.out.println("xTwoIn After set: " + xTwoIn);
        this.repaint();
        if(xOne == card2.getX())
        {
          System.out.println("Movement done...");
          flag = false;
        }
      }
    }
    else
    {
      System.out.println("xTwo was greater than xOne");
      while(flag)
      {
        xOneIn = card1.getX();
        xTwoIn = card2.getX();
        try
        {
          Thread.sleep(50);
        } catch (InterruptedException ex) {}
        card1.setBounds((xOneIn + 10), 110, 73, 97);
        card2.setBounds((xTwoIn - 10), 110, 73, 97);
        System.out.println("xOneIn After set: " + xOneIn);
        System.out.println("xTwoIn After set: " + xTwoIn);
        this.repaint();
        if(xOne == card2.getX())
        {
          System.out.println("Movement done...");
          flag = false;
        }
      }
    }
  }

[Nathan Pruett]

Two suggestions... call validate() on the component that holds the card JLabels. And make sure that you are using setLayout( null ) on the parent component, otherwise setBounds() won't work.

[Chris Stewart]

If I set the layout method to null, nothing shows up in my JFrame. I'm using setBounds all over the place in this and it works, I just can't get it to refresh after each loop.
I tried calling the validate method, but that didn't work either.
Here is my entire Layout class: (the moveCards method is at the very bottom)

package vcu.info350.finalproject;
import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
import java.applet.*;
import javax.swing.event.*;
import sun.audio.*;
import java.io.*;
import java.net.*;
public class Layout extends JFrame implements ActionListener, MouseListener, WindowListener
{
  private Container container;
  private JLayeredPane layeredPane;
  private JMenuItem exitItem, aboutItem, rulesItem, docsItem, newGameItem;
  private JMenu fileMenu;
  private JMenuBar bar;
  private ImageIcon backgroundImage, card1, card2, card3;
  private JLabel backLabel, betAmountLabel, totalAmountLabel, card1Label, card2Label, card3Label, currentMoney;
  private JButton startGameButton, tenDollarBetButton, twentyDollarBetButton, fiftyDollarBetButton, betComplete;
  private int betAmount;
  private Sounds sounds;
  private int userMoney = 500;
  private boolean canPickCard = false;
  private String guessedCard = "", chosenCard = "";
  private int round = 1, movements = 2, rand1 = 0, rand2 = 0;
  /**
   * Sets up the GUI
   */
  public Layout()
  {
    super("Find that card!");
    container = getContentPane();
    container.setLayout(new BorderLayout());
    layeredPane = new JLayeredPane();
    layeredPane.setOpaque(true);
    container.add(layeredPane, BorderLayout.CENTER);
    buildMenu();
    buildGameArea();
    //centerFrame();
    //sounds = new Sounds();
    this.addWindowListener(this);
    this.setResizable(false);
    this.setSize(640, 480);
    this.setVisible(true);
  }
  public void actionPerformed(ActionEvent event)
  {
    if(event.getSource().equals(startGameButton))
    {
      start();
    }
    else if(event.getSource().equals(newGameItem))
    {
      takeBet();
    }
    else if(event.getSource().equals(tenDollarBetButton))
    {
      betAmount += 10;
      betAmountLabel.setText("Current Bet: $ " + betAmount);
    }
    else if(event.getSource().equals(twentyDollarBetButton))
    {
      betAmount += 20;
      betAmountLabel.setText("Current Bet: $ " + betAmount);
    }
    else if(event.getSource().equals(fiftyDollarBetButton))
    {
      betAmount += 50;
      betAmountLabel.setText("Current Bet: $ " + betAmount);
    }
    else if(event.getSource().equals(betComplete))
    {
      if(betAmount == 0)
      {
        JOptionPane.showMessageDialog(null,
          "You must bet something!", "ERROR!",
          JOptionPane.INFORMATION_MESSAGE);
      }
      else if(betAmount > userMoney)
      {
        JOptionPane.showMessageDialog(null,
          "You only have $" + userMoney + ".  You can't bet more than that!",
          "ERROR!",
          JOptionPane.INFORMATION_MESSAGE);
        betAmount = 0;
        betAmountLabel.setText("Current Bet: $0");
      }
      else
      {
        JOptionPane.showMessageDialog(null, "your bet is: " + betAmount, "", JOptionPane.INFORMATION_MESSAGE);
        playGame();
      }
    }
    else if(event.getSource().equals(exitItem))
    {
      if(userMoney > 500)
      {
        JOptionPane.showMessageDialog(null, "You got lucky this time!", "GET OUT!", JOptionPane.INFORMATION_MESSAGE);
      }
      else if(userMoney < 500)
      {
        JOptionPane.showMessageDialog(null, "Thanks for your hard earned cash!", "GET OUT!", JOptionPane.INFORMATION_MESSAGE);
      }
      else
      {
        JOptionPane.showMessageDialog(null, "How can you win anything like that?", "GET OUT!", JOptionPane.INFORMATION_MESSAGE);
      }
      this.dispose();
      sounds.stopSoundsThread();
    }
    else if(event.getSource().equals(docsItem))
    {
      new ShowInformation("docsItem");
    }
    else if(event.getSource().equals(rulesItem))
    {
      new ShowInformation("rulesItem");
    }
    else if(event.getSource().equals(aboutItem))
    {
      JOptionPane.showMessageDialog(null, "Final Project: Find that card!\n" +
        "Programmer: Chris Stewart\nClass: INFO 350 - 901", "About", JOptionPane.INFORMATION_MESSAGE);
    }
  }
  public void mouseReleased(MouseEvent event)
  {
    if(canPickCard == true)
    {
      if(event.getSource().equals(card1Label))
      {
        guessedCard = "card1Label";
      }
      else if(event.getSource().equals(card2Label))
      {
        guessedCard = "card2Label";
      }
      else if(event.getSource().equals(card3Label))
      {
        guessedCard = "card3Label";
      }
      if(guessedCard.equals(chosenCard))
      {
        userMoney += (2 * betAmount);
        currentMoney.setText("Current Money $" + userMoney);
        round++;
        if(round == 6)
        {
          JOptionPane.showMessageDialog(null, "Congrats!  You owned this game!  That's all I got for now!", "Congrats!", JOptionPane.INFORMATION_MESSAGE);
        }
        JOptionPane.showMessageDialog(null, "Nice job, you won $" + (2 * betAmount) + ".  You're now moving on to round " + round + ".", "Congrats!", JOptionPane.INFORMATION_MESSAGE);
        movements += 3;
      }
      else
      {
        JOptionPane.showMessageDialog(null, "You lost $" + betAmount + ".  You are on round " + round + ".", "D'oh!", JOptionPane.INFORMATION_MESSAGE);
        userMoney -= betAmount;
        currentMoney.setText("Current Money $" + userMoney);
        if(userMoney <= 0)
        {
          JOptionPane.showMessageDialog(null, "You lost all of your money sucka!", "GET OUT!", JOptionPane.INFORMATION_MESSAGE);
          this.dispose();
          sounds.stopSoundsThread();
        }
      }
      canPickCard = false;
      betAmount = 0;
      int result = JOptionPane.showConfirmDialog(null, "Would you like to play again?",
        "Play again!", JOptionPane.YES_NO_OPTION, JOptionPane.QUESTION_MESSAGE, null);
      if(result == 0)
      {
        takeBet();
      }
      else if(result == 1)
      {
        if(userMoney > 500)
        {
          JOptionPane.showMessageDialog(null, "You got lucky this time!", "GET OUT!", JOptionPane.INFORMATION_MESSAGE);
        }
        else if(userMoney < 500)
        {
          JOptionPane.showMessageDialog(null, "Thanks for your hard earned cash!", "GET OUT!", JOptionPane.INFORMATION_MESSAGE);
        }
        else
        {
          JOptionPane.showMessageDialog(null, "How can you win anything like that?", "GET OUT!", JOptionPane.INFORMATION_MESSAGE);
        }
        userMoney = 500;
      }
    }
  }
  public void mouseClicked(MouseEvent event) {}
  public void mousePressed(MouseEvent event) {}
  public void mouseExited(MouseEvent event) {}
  public void mouseEntered(MouseEvent event) {}
  public void windowOpened(WindowEvent event) {}
  public void windowIconified(WindowEvent event) {}
  public void windowDeiconified(WindowEvent event) {}
  public void windowDeactivated(WindowEvent event) {}
  public void windowClosed(WindowEvent event) {}
  public void windowActivated(WindowEvent event) {}
  public void windowClosing(WindowEvent event)
  {
    if(userMoney > 500)
    {
      JOptionPane.showMessageDialog(null, "You got lucky this time!", "GET OUT!", JOptionPane.INFORMATION_MESSAGE);
    }
    else if(userMoney < 500)
    {
      JOptionPane.showMessageDialog(null, "Thanks for your hard earned cash!", "GET OUT!", JOptionPane.INFORMATION_MESSAGE);
    }
    else
    {
      JOptionPane.showMessageDialog(null, "How can you win anything like that?", "GET OUT!", JOptionPane.INFORMATION_MESSAGE);
    }
    this.dispose();
    sounds.stopSoundsThread();
  }
  /**
   * This method builds our menu
   */
  private void buildMenu()
  {
    // Section 1
    fileMenu = new JMenu("File");
    fileMenu.setMnemonic('F');
    newGameItem = new JMenuItem("New Game");
    newGameItem.setMnemonic('n');
    newGameItem.addActionListener(this);
    fileMenu.add(newGameItem);
    rulesItem = new JMenuItem("Rules");
    rulesItem.setMnemonic('u');
    rulesItem.addActionListener(this);
    fileMenu.add(rulesItem);
    docsItem = new JMenuItem("Documents");
    docsItem.setMnemonic('o');
    docsItem.addActionListener(this);
    fileMenu.add(docsItem);
    aboutItem = new JMenuItem("About");
    aboutItem.setMnemonic('a');
    aboutItem.addActionListener(this);
    fileMenu.add(aboutItem);
    exitItem = new JMenuItem("Exit");
    exitItem.setMnemonic('x');
    exitItem.addActionListener(this);
    fileMenu.add(exitItem);
    bar = new JMenuBar();
    setJMenuBar(bar);
    bar.add(fileMenu);
  }
  private void buildGameArea()
  {
    try
    {
      backgroundImage = new ImageIcon(new URL("http://www.isy.vcu.edu/~cstewart/info350/images/bg.jpg"));
    }
    catch(MalformedURLException ex) {}
    backLabel = new JLabel(backgroundImage);
    addLayeredComponent(backLabel, 0, 0, 640, 480, 0);
    startGameButton = new JButton("Start Game");
    startGameButton.addActionListener(this);
    addLayeredComponent(startGameButton, 270, 335, 100, 30, 5);
    card1Label = new JLabel("");
    card2Label = new JLabel("");
    card3Label = new JLabel("");
    currentMoney = new JLabel("Current Money $" + userMoney);
    addLayeredComponent(currentMoney, 270, 40, 150, 30, 5);
  }
  private void centerFrame()
  {
    //Get the dimensions of the screen
    Dimension screenSize = Toolkit.getDefaultToolkit().getScreenSize();
    int screenWidth = screenSize.width;
    int screenHeight= screenSize.height;
    //Get the dimensions of the frame
    Dimension frameSize = getSize();
    int x = (screenWidth - frameSize.width) / 2;
    int y = (screenHeight - frameSize.height) / 2;
    setLocation(x,y);
  }
  /**
   * This method places the given component on the frame, thanks may!
   */
  private void addLayeredComponent(Component c, int x, int y, int w, int h, int layer)
  {
    c.setBounds(x, y, w, h);
    layeredPane.add(c, new Integer(layer));
  }
  private void start()
  {
    startGameButton.setVisible(false);
    takeBet();
  }
  private void takeBet()
  {
    // Clean up area
    startGameButton.setVisible(false);
    card1Label.setVisible(false);
    card2Label.setVisible(false);
    card3Label.setVisible(false);
    Icon tenIcon = null, twentyIcon = null, fiftyIcon = null;
    try
    {
      tenIcon = new ImageIcon(new URL("http://www.isy.vcu.edu/~cstewart/info350/images/money10.gif"));
      twentyIcon = new ImageIcon(new URL("http://www.isy.vcu.edu/~cstewart/info350/images/money20.gif"));
      fiftyIcon = new ImageIcon(new URL("http://www.isy.vcu.edu/~cstewart/info350/images/money50.gif"));
    }
    catch(MalformedURLException ex) {}
    tenDollarBetButton = new JButton(tenIcon);
    tenDollarBetButton.addActionListener(this);
    addLayeredComponent(tenDollarBetButton, 30, 315, 55, 69, 5);
    twentyDollarBetButton = new JButton(twentyIcon);
    twentyDollarBetButton.addActionListener(this);
    addLayeredComponent(twentyDollarBetButton, 100, 315, 55, 69, 5);
    fiftyDollarBetButton = new JButton(fiftyIcon);
    fiftyDollarBetButton.addActionListener(this);
    addLayeredComponent(fiftyDollarBetButton, 170, 315, 55, 69, 5);
    betAmountLabel = new JLabel("Current Bet: $0");
    addLayeredComponent(betAmountLabel, 270, 335, 120, 30, 5);
    betComplete = new JButton("Place Bet");
    betComplete.addActionListener(this);
    addLayeredComponent(betComplete, 470, 335, 100, 30, 5);
  }
  private void playGame()
  {
    tenDollarBetButton.setVisible(false);
    twentyDollarBetButton.setVisible(false);
    fiftyDollarBetButton.setVisible(false);
    betAmountLabel.setVisible(false);
    betComplete.setVisible(false);
    Deck deck = new Deck();
    Object[] deckOfCards = deck.getDeck();
    Card c1, c2, c3;
    c1 = (Card)deckOfCards[1];
    c2 = (Card)deckOfCards[2];
    c3 = (Card)deckOfCards[3];
    try
    {
      card1 = new ImageIcon(new URL("http://www.isy.vcu.edu/~cstewart/info350/images/" + c1.getImage()));
      card1Label = new JLabel(card1);
      card2 = new ImageIcon(new URL("http://www.isy.vcu.edu/~cstewart/info350/images/" + c2.getImage()));
      card2Label = new JLabel(card2);
      card3 = new ImageIcon(new URL("http://www.isy.vcu.edu/~cstewart/info350/images/" + c3.getImage()));
      card3Label = new JLabel(card3);
    }
    catch(MalformedURLException ex) {}
    addLayeredComponent(card1Label, 120, 110, 73, 97, 5);
    addLayeredComponent(card2Label, 270, 110, 73, 97, 5);
    addLayeredComponent(card3Label, 420, 110, 73, 97, 5);
    card1Label.addMouseListener(this);
    card2Label.addMouseListener(this);
    card3Label.addMouseListener(this);
    /**
     * 1. Pick one card to be "it".
     * 2. Flip the others over to show which has been chosen.
     * 3. Display message saying which card has been chosen.
     * 4. Flip the final card over.
     */
    int chosenCardPosition = 1 + (int)(Math.random() * 3);
   // try
    //{
      if(chosenCardPosition == 1)
      {
        //card2Label.setIcon(new ImageIcon(new URL("http://www.isy.vcu.edu/~cstewart/info350/images/" + c2.getBackImage())));
        //card3Label.setIcon(new ImageIcon(new URL("http://www.isy.vcu.edu/~cstewart/info350/images/" + c3.getBackImage())));
        chosenCard = "card1Label";
      }
      else if(chosenCardPosition == 2)
      {
       // card1Label.setIcon(new ImageIcon(new URL("http://www.isy.vcu.edu/~cstewart/info350/images/" + c1.getBackImage())));
        //card3Label.setIcon(new ImageIcon(new URL("http://www.isy.vcu.edu/~cstewart/info350/images/" + c3.getBackImage())));
        chosenCard = "card2Label";
      }
      else if(chosenCardPosition == 3)
      {
        //card1Label.setIcon(new ImageIcon(new URL("http://www.isy.vcu.edu/~cstewart/info350/images/" + c1.getBackImage())));
        //card2Label.setIcon(new ImageIcon(new URL("http://www.isy.vcu.edu/~cstewart/info350/images/" + c2.getBackImage())));
        chosenCard = "card3Label";
      }
    //}
    //catch(MalformedURLException ex) {}
    JOptionPane.showMessageDialog(null, "The remaining card is what you should follow!",
      "Card Picked!",
      JOptionPane.INFORMATION_MESSAGE);
    /*try
    {
      card1Label.setIcon(new ImageIcon(new URL("http://www.isy.vcu.edu/~cstewart/info350/images/" + c1.getBackImage())));
      card2Label.setIcon(new ImageIcon(new URL("http://www.isy.vcu.edu/~cstewart/info350/images/" + c2.getBackImage())));
      card3Label.setIcon(new ImageIcon(new URL("http://www.isy.vcu.edu/~cstewart/info350/images/" + c3.getBackImage())));
      this.repaint();
    }
    catch(MalformedURLException ex) {}*/
    /**
     * 1. Algorithm to move cards around.
     */
    for(int i = 0; i < movements; i++)
    {
      rand1 = 1 + (int)(Math.random() * 3);
      rand2 = 1 + (int)(Math.random() * 3);
      while(rand1 == rand2)
      {
        System.out.println("Picked same number...");
        rand2 = 1 + (int)(Math.random() * 3);
      }
      System.out.println("rand1: " + rand1);
      System.out.println("rand2: " + rand2);
      if(rand1 == 1 && rand2 == 2)
      {
        moveCards(card1Label, card2Label, round);
      }
      else if(rand1 == 1 && rand2 == 3)
      {
        moveCards(card1Label, card3Label, round);
      }
      else if(rand1 == 2 && rand2 == 1)
      {
        moveCards(card2Label, card1Label, round);
      }
      else if(rand1 == 2 && rand2 == 3)
      {
        moveCards(card2Label, card3Label, round);
      }
      else if(rand1 == 3 && rand2 == 1)
      {
        moveCards(card3Label, card1Label, round);
      }
      else if(rand1 == 3 && rand2 == 2)
      {
        moveCards(card3Label, card2Label, round);
      }
    }
    /**
     * 1. Give the user access to pick a card.
     * 2. Check to see if this selected card is "it".
     *
     *    2.1 If it is, give them their bet x2.
     *    2.2 Otherwise, they lose their bet.
     *
     *  NOTE: The game logic is handled in the mouse event!
     */
    canPickCard = true;
  }
  private void moveCards(JLabel card1, JLabel card2, int round)
  {
    boolean flag = true;
    int xOneIn, xTwoIn, sleepTime = 0;
    int xOne = card1.getX();
    int xTwo = card2.getX();
    System.out.println("round: " + round
    );
    switch(round)
    {
      case 1:
        sleepTime = 1000;
      case 2:
        sleepTime = 40;
      case 3:
        sleepTime = 30;
      case 4:
        sleepTime = 20;
      case 5:
        sleepTime = 10;
    }
    if(xOne > xTwo)
    {
      while(flag)
      {
        xOneIn = card1.getX();
        xTwoIn = card2.getX();
        try
        {
          Thread.sleep(sleepTime);
        } catch (InterruptedException ex) {}
        card1.setAlignmentX(xOneIn - 10);
        card1.setAlignmentY(110);
        card2.setAlignmentX(xTwoIn - 10);
        card2.setAlignmentY(110);
        //card1.setBounds((xOneIn - 10), 110, 73, 97);
        //card2.setBounds((xTwoIn + 10), 110, 73, 97);
        this.validate();
        this.repaint();
        if(xOne == card2.getX())
        {
          flag = false;
        }
      }
    }
    else
    {
      System.out.println("xTwo was greater than xOne");
      while(flag)
      {
        xOneIn = card1.getX();
        xTwoIn = card2.getX();
        try
        {
          Thread.sleep(sleepTime);
        } catch (InterruptedException ex) {}
        card1.setBounds((xOneIn + 10), 110, 73, 97);
        card2.setBounds((xTwoIn - 10), 110, 73, 97);
        System.out.println("xOneIn After set: " + xOneIn);
        System.out.println("xTwoIn After set: " + xTwoIn);
        this.validate();
        this.repaint();
        if(xOne == card2.getX())
        {
          System.out.println("Movement done...");
          flag = false;
        }
      }
    }
  }
}

[ July 05, 2003: Message edited by: Chris Stewart ]

[Chris Stewart]

I fixed this problem, I just needed to put the movement into a thread of its own.