Problem with radio button

[Smriti Anchu]

Hi,

I have a screen with 2 radio buttons. I have manually selected the second radio button to be in selected mode when the screen in visible. So i have set property saying 'rdb1.setSelected(true);' when the screen activates. The radio button2 is actually selected but i find that there is a border around the text for the first radio button rather than for the second one. How do i hide this border ? I tried making the border to be empty but even then when the screen is loaded, we find a border around the text in the radio button.

Does anybody has any idea as to why this is happening? If so, please help me.

Thanks and regards
smriti

[Michael Dunn]

that line is for focus

there are a couple of things you can do

1) at the end of the GUI construction add radioButton2.requestFocus(),
but you must have setVisible(true) set prior to requesting focus

2) add these lines
radioButton1.setFocusPainted(false);
radioButton2.setFocusPainted(false);

[Smriti Anchu]

Hi Michel

thanks for your help...

1. I tried adding radioButton2.requestFocus() after adding the radio button to the panel, but even then radio button1 has border.

2. Later i tried adding these lines
radioButton1.setFocusPainted(false);
radioButton2.setFocusPainted(false);
Now the radioButton1 doesnt have border. But when the particular screen is focussed, since the radioButton2 is selected, it should have border, but it doesnt display the border inspite of setting the radioButton2.setFocusPainted(true); Only when they are clicked in mouse listener, i have set the ofcusPainted to true.

Is there any way such that when the screen is focussed, the radioButton2 to have a border around hte text.

[Alexandru Popescu]

Quoting the API:

This component must be displayable, visible, and focusable for the request to be granted.

--
:alex |.::the_mindstorm::.

[Michael Dunn]

>Is there any way such that when the screen is focussed, the radioButton2 to
>have a border around hte text.

You mustn't have read line 2 of (1)
>1) at the end of the GUI construction add radioButton2.requestFocus(),
>but you must have setVisible(true) set prior to requesting focus//<---------

here's a small demo program

import java.awt.*;
import javax.swing.*;
 
class Testing extends JFrame
{
  public Testing()
  {
    setLocation(400,300);
    setDefaultCloseOperation(EXIT_ON_CLOSE);
    JRadioButton rb1 = new JRadioButton("1");
    JRadioButton rb2 = new JRadioButton("2");
    ButtonGroup rbGroup = new ButtonGroup();
    rbGroup.add(rb1);
    rbGroup.add(rb2);
    JPanel jp = new JPanel(new GridLayout(2,1));
    jp.add(rb1);
    jp.add(rb2);
    getContentPane().add(jp);
    rb2.setSelected(true);
    pack();
    setVisible(true);//<-------------
    rb2.requestFocus();//<------------
  }
  public static void main(String[] args){new Testing();}
}

[Rohit Bhagwat]

Hello Michael

I have a class that extends BasicRadioButtonUI and in that class I have written code to traverse the radiobutton in a button group using arrow keys. Using arrow keys I am successfully able to select the radio buttons. However the problem I am facing is I am not able to see the focus line on the selected radio button. I used requestFocus method but still not able to see the focus line. All my radio buttons are visible. I even tried setFocusPainted method of the AbstractButton to set the focus line but invain.

Can you please help me as to how can I get the focus line on the selected radio button ?

Waiting for your reply.
Thanks and Regards
Rohit.

[Michael Dunn]

> I used requestFocus method

see if requestFocusInWindow() makes a difference

here's a simple demo of traversing the button group with 'Down' arrow key,
(reverse the logic for 'Up'arrow key)

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
class Testing extends JFrame
{
  JRadioButton[] rb = new JRadioButton[4];
  int rbSelection = 0;
  public Testing()
  {
    setLocation(400,300);
    setDefaultCloseOperation(EXIT_ON_CLOSE);
    JPanel jp = new JPanel(new GridLayout(4,1));
    ButtonGroup group = new ButtonGroup();
    for(int x = 0; x < rb.length; x++)
    {
      rb[x] = new JRadioButton("RB "+x);
      group.add(rb[x]);
      jp.add(rb[x]);
      rb[x].addKeyListener(new KeyAdapter(){
        public void keyPressed(KeyEvent ke){
        if(ke.getKeyCode() == KeyEvent.VK_DOWN)
        {
          rbSelection = (rbSelection+1)%rb.length;
          ke.consume();
          rb[rbSelection].setSelected(true);
          rb[rbSelection].requestFocusInWindow();
        }}});
    }
    getContentPane().add(jp);
    pack();
    rb[rbSelection].setSelected(true);
  }
  public static void main(String[] args){new Testing().setVisible(true);}
}

[Ilja Preuss]

Originally posted by Smriti Anchu:

Is there any way such that when the screen is focussed, the radioButton2 to have a border around hte text.

The "border" you are talking about is the focus. Being selected and having focus are two orthogonal things, though - the latter means that the component currently can be operated via the keyboard.

If you want the radioButton two to get the focus every time the screen is focussed, you will have to implement this. What exactly do you mean by "screen"? Is it a JDialog or something?

[Rohit Bhagwat]

Originally posted by Michael Dunn:
> I used requestFocus method

see if requestFocusInWindow() makes a difference

here's a simple demo of traversing the button group with 'Down' arrow key,
(reverse the logic for 'Up'arrow key)

I tried requestFocusInWindow too still now working. Here is what I have written.
public class MyRadioButtonUI extends BasicRadioButtonUI
{
@Override
public static ComponentUI createUI(JComponent c)
{
if (null == sInstance)
{
sInstance = new MyRadioButtonUI();
}
return sInstance;
}
// ///////////// Protected member functions ////////
@Override
protected void installListeners(AbstractButton button)
{
super.installListeners(button);
// map the correct actions to the arrow keys (Issue 45)
button.getActionMap().put(NEXT_ACTION, new NextAction());
button.getActionMap().put(PREVIOUS_ACTION, new PreviousAction());
button.getInputMap(JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT).put(
sDownKS, NEXT_ACTION);

button.getInputMap(JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT).put(
sUpKS, PREVIOUS_ACTION);

button.getInputMap(JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT).put(
sRightKS, NEXT_ACTION);

button.getInputMap(JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT).put(
sLeftKS, PREVIOUS_ACTION);
}

@Override
protected void uninstallListeners(AbstractButton button)
{
super.uninstallListeners(button);
// unmap the actions from the arrow keys
button.getActionMap().remove(NEXT_ACTION);
button.getActionMap().remove(PREVIOUS_ACTION);
button.getInputMap(JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT)
.remove(sDownKS);
button.getInputMap(JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT)
.remove(sUpKS);
button.getInputMap(JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT)
.remove(sRightKS);
button.getInputMap(JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT)
.remove(sLeftKS);
}
// /////////////////////// Private member functions////////////////////////

/**
* The evt, from which we can get the event source and the operation type.
* The operation tyep can be NEXT or PREVIOUS.
*
* @param evt,
* The event object.
*
* @param operation
* The type of the operation performed.
*/
private void selectRadioButton(ActionEvent evt, int operation)
{
// Get the source of the event.
Object evtSource = evt.getSource();
// Check whether the source is JRadioButton, it so, whether it is
// visible
if (!(evtSource instanceof JRadioButton
&& ((JRadioButton) evtSource).isVisible() && ((JRadioButton) evtSource)
.isEnabled()))
{
return;
}

// Get the button model from the source.
ButtonModel model = ((AbstractButton) evtSource).getModel();

if (!(model instanceof DefaultButtonModel))
return;

// If the button model is DefaultButtonModel, and use it, otherwise
// return.
DefaultButtonModel bm = (DefaultButtonModel) model;

if (bm == null)
return;

// get the ButtonGroup of the button from the button model
ButtonGroup group = bm.getGroup();
if (group == null)
return;

// Get all the buttons in the group
Enumeration<AbstractButton> e = group.getElements();

if (e == null)
return;

// First button and last button are used, so that if next is clicked and
// the current selected button is last button, we can move to first
// button and so on.
JRadioButton firstButton = null;

JRadioButton lastButton = null;

JRadioButton previousButton = null;

JRadioButton nextButton = null;

boolean srcFound = false;

AbstractButton currentElement = null;

while (e.hasMoreElements())
{
currentElement = e.nextElement();
if (currentElement instanceof JRadioButton
&& ((JRadioButton) currentElement).isVisible()
&& ((JRadioButton) currentElement).isEnabled())
{
// If firstButton is not set yet, currentElement is that first
// button
if (null == firstButton)
{
firstButton = (JRadioButton) currentElement;
}

if (evtSource == currentElement)
{
srcFound = true;
} else if (!srcFound)
{
// if we are here, the source has not been yet found but
// it's a valid
// button closer to the source that the last previousButton
// value
previousButton = (JRadioButton) currentElement;
} else if (srcFound && nextButton == null)
{
// if we are here, that's because the source has been found
// and that current element
// is the next valid button of the list
nextButton = (JRadioButton) currentElement;
}
// if we found a new "valid" JRadioButton, it become the new
// last "valid" JRadioButton
// of the list
lastButton = (JRadioButton) currentElement;
}
}

if (srcFound)
{
JRadioButton newSelectedButton = null;
if (NEXT == operation)
{
// Select Next button.
// Cycle to the first button if the source button is the
// last of the group.
newSelectedButton = (null == nextButton) ? firstButton
: nextButton;
} else
{
// Select previous button
// Cycle to the last button if the source button is the
// first button of the group.
newSelectedButton = (null == previousButton) ? lastButton
: previousButton;
}
if (newSelectedButton != null)
{
newSelectedButton.requestFocusInWindow();
newSelectedButton.setSelected(true);
}
}
}

// /////////////////////// Inner Classes ////////////////////////
private class NextAction extends AbstractAction
{
public NextAction()
{
super(NEXT_ACTION);
}
public void actionPerformed(ActionEvent e)
{
MyRadioButtonUI.this.selectRadioButton(e, NEXT);
}
}

private class PreviousAction extends AbstractAction
{
public PreviousAction()
{
super(PREVIOUS_ACTION);
}
public void actionPerformed(ActionEvent e)
{
MyRadioButtonUI.this.selectRadioButton(e, PREVIOUS);
}
}
// /////////////////////// Class Data ////////////////////////
private static final int NEXT = 1;
private static final int PREVIOUS = 2;
private static final String NEXT_ACTION = "Next";
private static final String PREVIOUS_ACTION = "Previous";
private static MyRadioButtonUI sInstance;
private static KeyStroke sDownKS = KeyStroke.getKeyStroke("pressed DOWN");
private static KeyStroke sUpKS = KeyStroke.getKeyStroke("pressed UP");
private static KeyStroke sRightKS = KeyStroke.getKeyStroke("pressed RIGHT");
private static KeyStroke sLeftKS = KeyStroke.getKeyStroke("pressed LEFT");
}

Can you please help me in this regards.

Thanks and Regards
Rohit.

[Michael Dunn]

change the super class

public class MyRadioButtonUI extends javax.swing.plaf.metal.MetalRadioButtonUI //BasicRadioButtonUI

[Rohit Bhagwat]

Thanks very much. It did worked.

Thanks and Regards
Rohit