JDialog components not refreshing

[bob mccloud]

Hello all.

I have searched for an answer for the following problem and have found none.

Basically I have created a setting dialog by extending JDialog. It has some radio buttons, text fields, etc. In addition to save and cancel buttons, I also have a reset button (to display defaults).

When I open the dialog and press the defaults button, the fields are updated. I then press cancel and reopen the dialog expecting to see the original values. However, I see the default values on the GUI, but if I examine the values of the fields themselves they are correct.

What am I missing?

Thanks in advance,

SWING Newbie

[Stuart Gray]

Sounds like you should call your update (reset) code immediately before first displaying the dialog. Though without code to examine this is just a guess.

[Craig Wood]

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
 
public class DialogTest
{
    CustomDialog dialog;
    JTextArea textArea;
 
    public DialogTest()
    {
        JFrame f = new JFrame();
        createDialog(f);
        textArea = new JTextArea();
        f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        f.getContentPane().add(getUIPanel(), "North");
        f.getContentPane().add(new JScrollPane(textArea));
        f.setSize(300,175);
        f.setLocation(200,200);
        f.setVisible(true);
    }
 
    private void createDialog(Frame f)
    {
        dialog = new CustomDialog(f);
        dialog.setSize(360,240);
        dialog.setLocation(525,200);
        dialog.setVisible(true);
    }
 
    private void showSavedData()
    {
        int index = dialog.selectedIndex;
        String text = dialog.text;
        textArea.append("saved selectedIndex = " + index + "\n" +
                        "saved text = " + text + "\n");
    }
 
    private JPanel getUIPanel()
    {
        final JButton
            report = new JButton("get saved data"),
            reopen = new JButton("reopen");
        ActionListener l = new ActionListener()
        {
            public void actionPerformed(ActionEvent e)
            {
                JButton button = (JButton)e.getSource();
                if(button == report)
                    showSavedData();
                if(button == reopen)
                    dialog.setVisible(true);
            }
        };
        report.addActionListener(l);
        reopen.addActionListener(l);
        JPanel panel = new JPanel();
        panel.add(report);
        panel.add(reopen);
        return panel;
    }
 
    public static void main(String[] args)
    {
        new DialogTest();
    }
}
 
class CustomDialog extends JDialog
{
    JRadioButton[] radios;
    JTextField textField;
    JPanel center;
    int selectedIndex;                    // member variables
    String text;                          // for 'saved' state
 
    public CustomDialog(Frame f)
    {
        super(f);
        initComponents();
        selectedIndex = -1;               // initialize 'saved'
        text = "nothing saved yet...";    //   state variables
        add(getNorthPanel(), "North");
        add(center);
        add(textField, "South");
    }
 
    private void save()
    {
        for(int j = 0; j < radios.length; j++)
            if(radios[j].isSelected())
                selectedIndex = j;
        text = textField.getText();
    }
 
    private void reset()
    {
        // restore initial state,
        // which is independent of saved state
        radios[2].setSelected(true);
        textField.setText("initial text");
    }
 
    private JPanel getNorthPanel()
    {
        final JButton
            save = new JButton("save"),
            reset = new JButton("reset");
        ActionListener l = new ActionListener()
        {
            public void actionPerformed(ActionEvent e)
            {
                JButton button = (JButton)e.getSource();
                if(button == save)
                    save();
                if(button == reset)
                    reset();
            }
        };
        save.addActionListener(l);
        reset.addActionListener(l);
        JPanel panel = new JPanel();
        panel.add(save);
        panel.add(reset);
        return panel;
    }
 
    private void initComponents()
    {
        radios = new JRadioButton[4];
        ButtonGroup group = new ButtonGroup();
        center = new JPanel(new GridBagLayout());
        GridBagConstraints gbc = new GridBagConstraints();
        gbc.weightx = 1.0;
        gbc.weighty = 1.0;
        for(int j = 0; j < radios.length; j++)
        {
            radios[j] = new JRadioButton("option " + (j+1));
            group.add(radios[j]);
            if(j % 2 == 0)
                gbc.gridwidth = gbc.RELATIVE;
            else
                gbc.gridwidth = gbc.REMAINDER;
            center.add(radios[j], gbc);
        }
        textField = new JTextField(12);
        Dimension d = textField.getPreferredSize();
        d.height = 25;
        textField.setPreferredSize(d);
        reset();                          // set initial component values
    }
}

[bob mccloud]

Thanks for the example (Stuart) and hint (Craig).

A buddy of mine pointed out that my function to create the dialog components was in the wrong place (actionPerformed versus constructor). Thus, I was generating new compnents each time.