How to add new tabs from JMenu

[Med Shabe]

I have a JMenu class (GoofyMenuBar.java) and a JTabbedPane class (LoginTabbedPane.java) that I�m putting into a splitPane (SplitPane.java).

Clicking on the Go button opens a new tab. I need to invoke the same action from the menu but somehow I�m not making the connection between the components.

Regardless of the ugliness, how can I invoke a method on JTabbedPane from the JMenu, and later from the JToolBar. Apparently, simply instantiating the class does not do the trick.

Appreciate the input.


LoginTabbedPane

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import com.programix.gui.*;
import com.programix.gui.layout.*;
 
class LoginTabbedPane extends JPanel {
    private JTabbedPane tabbedPane;
    private JPanel panel1;
    private JPanel panel2;
    private JPanel topPanel;
    
    public LoginTabbedPane() {
        setSize( 300, 200 );
 
        topPanel = new JPanel();
        topPanel.setLayout( new BorderLayout() );
 
        // Create the tab pages
        createLoginPage();
        createInfoPage();
 
        // Create a tabbed pane
        tabbedPane = new JTabbedPane();
        tabbedPane.addTab( "Login page", panel1 );
        topPanel.add( tabbedPane, BorderLayout.CENTER );
        add( topPanel );
    }
 
    public void createLoginPage() {
        panel1 = new JPanel();
        panel1.setLayout( new FormLayout(AnchorPoint.NORTHWEST));
 
        JLabel label1 = new JLabel( "Username:" );
        panel1.add( label1 );
 
        JTextField field = new JTextField(15);
        panel1.add( field );
 
        JLabel label2 = new JLabel( "Password:" );
        panel1.add( label2 );
 
        JPasswordField fieldPass = new JPasswordField(15);
        panel1.add( fieldPass );
        
        JButton jGo = new JButton("Go");
        panel1.add(jGo);
        jGo.setMnemonic('G');
        jGo.addActionListener(new ActionListener() {
            public void actionPerformed(ActionEvent e) {
                createInfoPage();
                tabbedPane.addTab("Info Page", panel2);
            }
        });
    }
    public void createInfoPage() {
        panel2 = new JPanel();
        panel2.setLayout( new FormLayout() );
 
        panel2.add( new JLabel( "Field 1:" ) );
        panel2.add( new TextArea() );
        panel2.add( new JLabel( "Field 2:" ) );
        panel2.add( new TextArea() );
        panel2.add( new JLabel( "Field 3:" ) );
        panel2.add( new TextArea() );
    }
 
    // Main method to get things started
    public static void main( String args[] ) {
        LoginTabbedPane mainFrame = new LoginTabbedPane();
        mainFrame.setSize(800, 700);
        mainFrame.setVisible( true );
    }
 
    public JPanel getTopPanel() {
        return topPanel;
    }
}

GoofyMenuBar.java

  
import java.awt.event.*;
import javax.swing.*;
 
public class GoofyMenuBar {
    private LoginTabbedPane tabbedPane;
    
    public JMenuBar createMenuBar() {
        tabbedPane = new LoginTabbedPane();
        
        JMenuBar menuBar = new JMenuBar();
        menuBar.add(createMenu("Item 1"));
        menuBar.add(createMenu("Item 2"));
        return menuBar;
    }
 
    public JMenu createMenu(String title) {
        JMenu m = new JMenu(title);
        JMenuItem item1 = new JMenuItem("Item 1");
        m.add(item1);
        m.add(new JMenuItem(title));
        item1.addActionListener(new ActionListener() {
            public void actionPerformed(ActionEvent e) {
                tabbedPane.createInfoPage();
                //System.exit(0);
            }
        });
        return m;
    }
}
 

SplitPane

import java.awt.*;
import java.awt.event.*;
 
import javax.swing.*;
 
class SplitPane extends JPanel {
    private JSplitPane  splitPaneH;
    private JPanel topPanel;
    private LoginTabbedPane tabbedPane;
    private GoofyMenuBar menuBar;
 
    public SplitPane() {
        tabbedPane = new LoginTabbedPane();
        menuBar = new GoofyMenuBar();
 
        topPanel = new JPanel();
        topPanel.setLayout( new BorderLayout() );
        add( topPanel );
 
        splitPaneH = new JSplitPane(JSplitPane.HORIZONTAL_SPLIT,
            menuBar.createMenuBar(), tabbedPane.getTopPanel());
        splitPaneH.setOneTouchExpandable(true);
        topPanel.add(splitPaneH);
    }
 
    public static void main( String args[] ) {
 
        JFrame.setDefaultLookAndFeelDecorated(true);
        JDialog.setDefaultLookAndFeelDecorated(true);
 
        JFrame f = new JFrame("SplitPane");
        f.setDefaultCloseOperation(JFrame.DO_NOTHING_ON_CLOSE);
        f.setContentPane(new SplitPane());
 
        f.setSize(600, 450);
        f.setVisible(true);
 
        f.addWindowListener(new WindowAdapter() {
            public void windowClosing(WindowEvent e) {
                System.exit(0);
            }
        });
    }
}

[Michael Dunn]

you want item1 of the menu to create/add an info page?
(same as clickig the 'Go' button)

if so, follow the changes here, and you should get it to work OK

the main differences are the passing of the LoginTabbedPane reference to the
GoofyMenuBar class, and the creation of a separate method to create/add
the info page - this can then be called by both the Go button and the menu item

note: lots of 'comment-outs', just to get it to compile - I don't have
programix.* stuff, or FormLayout stuff. I put them all in one java file,
but you have 2 x main()

you will probably need to handle a second click on the menu item - do you
want a second info page created/added etc etc

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
//import com.programix.gui.*;
//import com.programix.gui.layout.*;
 
class LoginTabbedPane extends JPanel {
    private JTabbedPane tabbedPane;
    private JPanel panel1;
    private JPanel panel2;
    private JPanel topPanel;
 
    public LoginTabbedPane() {
        setSize( 300, 200 );
 
        topPanel = new JPanel();
        topPanel.setLayout( new BorderLayout() );
 
        // Create the tab pages
        createLoginPage();
        createInfoPage();
 
        // Create a tabbed pane
        tabbedPane = new JTabbedPane();
        tabbedPane.addTab( "Login page", panel1 );
        topPanel.add( tabbedPane, BorderLayout.CENTER );
        add( topPanel );
    }
 
    public void createLoginPage() {
        panel1 = new JPanel();
        //panel1.setLayout( new FormLayout(AnchorPoint.NORTHWEST));
 
        JLabel label1 = new JLabel( "Username:" );
        panel1.add( label1 );
 
        JTextField field = new JTextField(15);
        panel1.add( field );
 
        JLabel label2 = new JLabel( "Password:" );
        panel1.add( label2 );
 
        JPasswordField fieldPass = new JPasswordField(15);
        panel1.add( fieldPass );
 
        JButton jGo = new JButton("Go");
        panel1.add(jGo);
        jGo.setMnemonic('G');
        jGo.addActionListener(new ActionListener() {
            public void actionPerformed(ActionEvent e) {
              jGoButtonAction();//<----------------------------------
            }
        });
    }
    public void jGoButtonAction()//<---------------------------------
    {
      createInfoPage();
      tabbedPane.addTab("Info Page", panel2);
    }
    public void createInfoPage() {
        panel2 = new JPanel();
        //panel2.setLayout( new FormLayout() );
 
        panel2.add( new JLabel( "Field 1:" ) );
        panel2.add( new TextArea() );
        panel2.add( new JLabel( "Field 2:" ) );
        panel2.add( new TextArea() );
        panel2.add( new JLabel( "Field 3:" ) );
        panel2.add( new TextArea() );
    }
/*
    // Main method to get things started
    public static void main( String args[] ) {
        LoginTabbedPane mainFrame = new LoginTabbedPane();
        mainFrame.setSize(800, 700);
        mainFrame.setVisible( true );
    }
*/
    public JPanel getTopPanel() {
        return topPanel;
    }
}
 
class GoofyMenuBar {
    private LoginTabbedPane tabbedPane;
public GoofyMenuBar(LoginTabbedPane ltp){tabbedPane = ltp;}//<------------
    public JMenuBar createMenuBar() {
        //tabbedPane = new LoginTabbedPane();//<------------
 
        JMenuBar menuBar = new JMenuBar();
        menuBar.add(createMenu("Item 1"));
        menuBar.add(createMenu("Item 2"));
        return menuBar;
    }
 
    public JMenu createMenu(String title) {
        JMenu m = new JMenu(title);
        JMenuItem item1 = new JMenuItem("Item 1");
        m.add(item1);
        m.add(new JMenuItem(title));
        item1.addActionListener(new ActionListener() {
            public void actionPerformed(ActionEvent e) {
                //tabbedPane.createInfoPage();
                tabbedPane.jGoButtonAction();//<------------
 
                //System.exit(0);
            }
        });
        return m;
    }
}
 
class SplitPane extends JPanel {
    private JSplitPane  splitPaneH;
    private JPanel topPanel;
    private LoginTabbedPane tabbedPane;
    private GoofyMenuBar menuBar;
 
    public SplitPane() {
        tabbedPane = new LoginTabbedPane();
        //menuBar = new GoofyMenuBar();
        menuBar = new GoofyMenuBar(tabbedPane);//<---------------------------
        topPanel = new JPanel();
        topPanel.setLayout( new BorderLayout() );
        add( topPanel );
 
        splitPaneH = new JSplitPane(JSplitPane.HORIZONTAL_SPLIT,
            menuBar.createMenuBar(), tabbedPane.getTopPanel());
        splitPaneH.setOneTouchExpandable(true);
        topPanel.add(splitPaneH);
    }
 
    public static void main( String args[] ) {
 
        JFrame.setDefaultLookAndFeelDecorated(true);
        JDialog.setDefaultLookAndFeelDecorated(true);
 
        JFrame f = new JFrame("SplitPane");
        f.setDefaultCloseOperation(JFrame.DO_NOTHING_ON_CLOSE);
        f.setContentPane(new SplitPane());
 
        f.setSize(600, 450);
        f.setVisible(true);
 
        f.addWindowListener(new WindowAdapter() {
            public void windowClosing(WindowEvent e) {
                System.exit(0);
            }
        });
    }
}

[Med Shabe]

Thanks Michael.