repaint() won't call paint() and I'm out of ideas why

[Jeff Finn]

I've been banging my head on this for a while now. In run() everything is peachy if I use show(). I'm pretty sure I need to use repaint() if I want to move the figure around the board without tracers. also, the thread doesn't quit when I close the app, but that's not my big problem now.

heres the code (all of it) edited, compiled and run in BlueJ

import java.awt.*;
import javax.swing.*;
 
public class puyo extends JFrame implements Runnable
{
    private static final int        APP_WIDTH   = 200;
    private static final int        APP_HEIGHT  = 418;        
    
    
    Thread theThread; 
    protected boolean done = false;
    
    Image iconRed;
    
    public puyo()
    {
         this.setSize(APP_WIDTH, APP_HEIGHT);
         this.setTitle("PuyoPuyo App");
         theThread = new Thread(this);
         theThread.start();
         
    }
    
    
    
    public void getImages(){
        iconRed = getToolkit().getImage("puyo/puyo_red.png");
    }
 
   
    
    public void run(){
        this.getImages();
        while (!done)
        {
            try
            {
                Thread.sleep(20);
            }
            catch (InterruptedException e)
            {
                break;
            }
            repaint();
        }
    }
    
    public void shutDown(){
        done = true;
    }
    
   
   
    public void drawIcon(Graphics g, int x, int y){
       g.drawImage(iconRed, (x*32)+4, ((y+32)) - 2, this);
    }
    
    
    public void paint(Graphics g){
        Container c = this.getContentPane();
        g = c.getGraphics();
        g.setColor(Color.white);
        int width = c.getWidth();
        int height = c.getHeight();
        g.fillRect(0, 0, width, height);
        g.drawImage(iconRed, 0, 0, this);
    }
    
    
    public void update(Graphics g){
        paint(g);
    }
    
    
    public static void main(String[] args) {
         new puyo();
    }
}
 

[Ernest Friedman-Hill]

Hi,

Welcome to JavaRanch!

First, I note that in your haste to come in and ask a question, you seem to have missed reading our policy on display names, which quite clearly states that you must use a real (sounding) first and last name for your display name -- no joke names, "handles," or last initials are acceptable. You can fix your display name here. We take this policy rather seriously. Thanks for your cooperation!

Second, your problem: this ought to work, more or less, if you get the JFrame to appear on the screen by calling setVisible(true) in your constructor.

As far as the threads not stopping: graphics programs simply won't quit unless you, one way or another, arrange to have System.exit() be called; usually just by calling setDefaultCloseOperation() on your JFrame.

I should point out that you're mixing AWT and Swing techniques here. With Swing, you don't override paint(), but rather paintComponent(); you always call super.paintComponent(); and you don't need to override update(). Typically you'd write a subclass of a JPanel, not a JFrame, and add that JPanel to an "off-the-shelf" JFrame.

Finally, we've got a Swing/AWT forum here where this post would fit right in. I'm going to move it there. See you around the Ranch!

[Jeff Finn]

Thank You for your Help, I've fixed my name, too.

[Jeff Finn]

now that It moves, how do I get rid of the flicker? or is it just my compiler?

import java.awt.*;
import javax.swing.*;
 
public class puyo extends JFrame implements Runnable
{
    Container c;
 
    private static final int        APP_WIDTH   = 200;
    private static final int        APP_HEIGHT  = 418;        
    
    
    Thread theThread; 
    protected boolean done = false;
    
    Image iconRed;
    int redX;
    int redY;
    
    
    public puyo()
    {
         redX = 0;
         redY = 0;
         this.setSize(APP_WIDTH, APP_HEIGHT);
         this.setTitle("PuyoPuyo App");
         this.setVisible(true);
         c = this.getContentPane();
         theThread = new Thread(this);
         theThread.start();
         
    }
    
    
    
    public void getImages(){
        iconRed = getToolkit().getImage("puyo/puyo_red.png");
    }
 
   
    
    public void run(){
        this.getImages();
        while (!done)
        {
            try
            {
                Thread.sleep(50);
                repaint()
            }
            catch (InterruptedException e)
            {
                break;
            }
            
        }
    }
    
    
    
   
   
    public void drawIcon(Graphics g, int x, int y){
       g.drawImage(iconRed, (x*32)+4, ((y+32)) - 2, this);
    }
    
    
    public void paint(Graphics g){
        
        g = c.getGraphics();
        g.setColor(Color.white);
        int width = c.getWidth();
        int height = c.getHeight();
        g.fillRect(0, 0, width, height);
        dropImage(g);
    }
    
    public void dropImage(Graphics g){
        g.drawImage(iconRed, redX, (redY++)%418, this);
        
    }   
    
    public void setDefaultCloseOperation(){
        done = true;
    }
    
    
    
    
    
    public static void main(String[] args) {
         new puyo();
    }
}
 
  

[Michael Dunn]

see if this is any better

import java.awt.*;
import javax.swing.*;
class puyo extends JFrame implements Runnable
{
  private final int APP_WIDTH   = 200;
  private final int APP_HEIGHT  = 418;
  Image iconRed = getToolkit().getImage("Save.gif");
  int redX = 0;
  int redY = 0;
  DrawPanel dp = new DrawPanel();
  public puyo()
  {
    setLocation(300,200);
    setSize(APP_WIDTH, APP_HEIGHT);
    setDefaultCloseOperation(EXIT_ON_CLOSE);
    getContentPane().add(dp);
    Thread theThread = new Thread(this);
    theThread.start();
  }
  public void run()
  {
    while (true)
    {
      try
      {
          Thread.sleep(50);
          dp.repaint();
      }
      catch (InterruptedException e)
      {
          break;
      }
    }
  }
  class DrawPanel extends JPanel
  {
    public DrawPanel(){setBackground(Color.WHITE);}
    public void paintComponent(Graphics g)
    {
      super.paintComponent(g);
      g.drawImage(iconRed, redX, (redY++)%APP_HEIGHT, this);
    }
  }
  public static void main(String[] args){new puyo().setVisible(true);}
}

[Ernest Friedman-Hill]

I'm sure Michael's code is going to be a big improvement flicker-wise; the JPanel class implements double-buffering internally, and he's doing things the Swing way, as I suggested.

Art Vandelay is the fake name George Costanza gave to prospective dates and employers, etc. A famous fake name is worse, I think, than what you started with! Can we go with something a bit less flashy, please? "Joe Finn" sounds nice.

[Jeff Finn]

wow. that's slick; I got a long way to go...
thanks for your help,
Jeff