close window when new one opens

[Brandi Love]

I've made a menu screen that has a series of buttons that, when clicked on, open up a new window. I want the menu screen to close when a button is clicked and the new window pops up but I can't figure out how to get it to work. Its not a big deal, just a little nuisance thats drivin' me nuts. Any ideas?

[Ben Zung]

I don't know which part you could not figure out. Do you have some code at all? If you can post them you may get more help.

  
JFrame menu; //or JDialog depends
JFrame frameToBeOpened; 
...
//in the action listener of button clicks
menu.setVisible(false);
frameToBeOpened.setVisible(true);
...
  

Good Luck.

[Brandi Love]

Here's a login screen, which takes in a user ID and last name and checks it against a text file. After the user has logged in a menu pops up with various buttons that, when clicked on, open up new forms. When the user logs in I want the login screen to no longer be visible after the menu screen pops up. Part of the problem may be that I have setVisible for the screen in its own seperate run method, do you think that I should change my code so it works in the action listener? I was avoiding that at all possible costs as the frames for all of the windows I've made are coded like that.

import java.awt.Container;
import java.awt.FlowLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.*;
import java.io.*;
import java.lang.String;
import java.util.*;
import java.awt.LayoutManager;
import javax.swing.JSeparator;
import javax.swing.JLabel;
 
//****************************** Login Screen ******************************
 
public class LoginScreen extends JApplet 
{
  private JButton 
    login = new JButton("Login"), 
    exit = new JButton("Exit");
    //initializes login and exit buttons
  
   class LoginButtonListener implements ActionListener //Controls the action if the login button is clicked.
    {
      public void actionPerformed(ActionEvent e)
      {
        String name, id;
        
        name = JOptionPane.showInputDialog("Enter your last name:");
        
        if (name.equals(""))
          JOptionPane.showMessageDialog(null, "Error: You did not enter a name. Please try again.", "ERROR", JOptionPane.WARNING_MESSAGE);
        //User is prompted to enter their last name. If they do not enter anything in the text box an error message pops up.
        
        id = JOptionPane.showInputDialog("Enter your 4 digit employee id number:");
   
        boolean isNum = true;
        for (int i = 0; i < id.length() && isNum; i++) 
        { 
          char c = id.charAt(i); 
          String numbers = "0123456789";
          if (numbers.indexOf(c) == -1) 
          {
            isNum = false;
          }
          else
          {
            isNum = true;
          }
        }
        //Checks if ID is a valid number.
 
        if (id.equals(""))
          JOptionPane.showMessageDialog(null, "Error: You did not enter an employee ID number. Please try again.", "ERROR", JOptionPane.WARNING_MESSAGE);
        else if (id.length() != 4 || isNum == false)
          JOptionPane.showMessageDialog(null, "Error: The employee ID you entered was not four numerical digits. Please try again.", "ERROR", JOptionPane.WARNING_MESSAGE);
        //User is prompted to enter their 4 digit employee ID. If they enter nothing or a string that is not 4 numbers an error message pops up.
        else
        {
          try
          {
            String filename = "c:/RFBAW/files/employees.txt";
            FileReader fr =
              new FileReader(filename);
            BufferedReader br =
              new BufferedReader(fr);
            //Needed for reading the file with the employee information.
  
            String inLine = ""; //Variable which will contain a line from the employees file.
            String lastName = ""; //Variable which will contain an employee last name pulled from inLine.
            String employeeID = ""; //Variable which will contain an employee ID pulled from inLine.
            boolean isValid = false; //Changed to true if the employee's information is verified.
            
            while (!inLine.equals("!EOF!") && isValid == false) 
            //Continues to check the file until the end is reached or the employee is verified.
            {
              inLine = br.readLine();
              if (!inLine.equals("!EOF!")) //Checks for end of file before pulling any more employee information.
              {
                StringTokenizer st =
                  new StringTokenizer(inLine); //Needed to seperate the last name from the employee ID.
                lastName = st.nextToken(); //Pulls the last name from inLine.
                employeeID = st.nextToken(); //Pulls the employee ID from inLine.
                if (name.equalsIgnoreCase(lastName) && id.equals(employeeID))
                  isValid = true;
                //If a match is found in the file with the employee ID and password the user has entered isValid is true and it breaks out of the loop.
              }
            }
            
            if (isValid == false)
              JOptionPane.showMessageDialog(null, "Error: The name and employee ID you entered did not match. Please try again.", "ERROR", JOptionPane.WARNING_MESSAGE);
            //If the employee information is not verified an error message pops up.
            else 
            {
              run(new MenuScreen(), 625, 550);
            }
              
          }
          catch (IOException error) 
          {
            JOptionPane.showMessageDialog(null, "Error - IO exception caught", "ERROR", JOptionPane.WARNING_MESSAGE);
            //Catchs any IO exceptions. Needed for file IO.
          }
      }
    }
   }
    
    class ExitButtonListener implements ActionListener //Controls the action if the exit button is clicked.
    {
      public void actionPerformed(ActionEvent e)
      {
        System.exit(0); //Exits when the exit button is clicked.
      }
    }
    
    private LoginButtonListener lhandler = new LoginButtonListener();
    private ExitButtonListener ehandler = new ExitButtonListener();
    //Adds the handlers to the login and exit buttons.
    
    public void init()
    {
      login.addActionListener(lhandler);
      exit.addActionListener(ehandler);
      Container cp = getContentPane();
      cp.setLayout(new BoxLayout(cp, BoxLayout.LINE_AXIS));
      cp.add(Box.createVerticalStrut(10));
      cp.add(new JLabel(new ImageIcon("c:/RFBAW/files/RedFox.jpg")));
      cp.add(Box.createVerticalStrut(10));
      cp.add(new JSeparator(SwingConstants.VERTICAL));
      cp.add(Box.createVerticalStrut(10));
      cp.add(login);
      cp.add(Box.createHorizontalStrut(10));
      cp.add(exit);
      cp.add(Box.createVerticalStrut(10));
      //Sets layout for login window, adds buttons.
    }
 
    public static void run(JApplet applet, int width, int height)
    {
      JFrame frame = new JFrame("Red Fox Books and Wax - Employee Login");
      frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
      frame.getContentPane().add(applet);
      frame.setSize(width, height);
      applet.init();
      applet.start();
      frame.setVisible(true);
      //Sets size for login applet and initializes it.
    }
    
    public static void main(String[] args) 
    {
      run(new LoginScreen(), 314, 200); //Calls run, which runs the applet.
    }
}

[ March 20, 2006: Message edited by: Brandi Love ]

[Brandi Love]

Here's the code for the menu screen as well, I'm not sure whether I need to code it into the login screen or menu screen...

import java.awt.Container;
import java.awt.FlowLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.BorderLayout;
import javax.swing.*;
import java.io.*;
import java.lang.String;
import java.util.*;
import java.awt.GridLayout;
 
//****************************** Menu Screen ******************************
 
public class MenuScreen extends JApplet 
{
  private JButton registerNewMem = new JButton("Register new member"),
    customerOrder = new JButton("Place a customer order"),
    fillOrder = new JButton("Fill an order"),
    stockOrder = new JButton("Place a stock order"),
    changeMemInfo = new JButton("Change member information"),
    updateOrder = new JButton("Update an order"),
    completeReturn = new JButton("Complete a return"),
    logOff = new JButton("Exit");
  
  class RegisterButtonListener implements ActionListener 
  {
    public void actionPerformed(ActionEvent e)
    {
      run(new RegisterNewMember(), 350, 325);
    }
  }
  
  class CustomerOrderButtonListener implements ActionListener 
  {
    public void actionPerformed(ActionEvent e)
    {
      run(new PlaceAnOrder(), 400, 450);
    }
  }
  
  class FillOrderButtonListener implements ActionListener 
  {
    public void actionPerformed(ActionEvent e)
    {
      run(new FillAnOrder(), 400, 450);
    }
  }
  
  class StockOrderButtonListener implements ActionListener 
  {
    public void actionPerformed(ActionEvent e)
    {
      System.exit(0); //Here will go the implementation of 'Place a stock order'. For now it just exits when clicked.
    }
  }
  
  class ChangeMemInfoButtonListener implements ActionListener 
  {
    public void actionPerformed(ActionEvent e)
    {
      run(new EditCustomerInfo(), 400, 450);
    }
  }
  
  class UpdateOrderButtonListener implements ActionListener 
  {
    public void actionPerformed(ActionEvent e)
    {
      System.exit(0); //Here will go the implementation of 'Update an order'. For now it just exits when clicked.
    }
  }
  
  class ReturnButtonListener implements ActionListener 
  {
    public void actionPerformed(ActionEvent e)
    {
      System.exit(0); //Here will go the implementation of 'Complete a return'. For now it just exits when clicked.
    }
  }
  
  class LogOffButtonListener implements ActionListener 
  {
    public void actionPerformed(ActionEvent e)
    {
      System.exit(0); //Here will go the implementation of 'Log off'. For now it just exits when clicked.
    }
  }
  
  private RegisterButtonListener regHandler = new RegisterButtonListener();
  private CustomerOrderButtonListener custOrderHandler = new CustomerOrderButtonListener();
  private FillOrderButtonListener fillOrderHandler = new FillOrderButtonListener();
  private StockOrderButtonListener stockOrderHandler = new StockOrderButtonListener();
  private ChangeMemInfoButtonListener changeInfoHandler = new ChangeMemInfoButtonListener();
  private UpdateOrderButtonListener updateOrderHandler = new UpdateOrderButtonListener();
  private ReturnButtonListener returnHandler = new ReturnButtonListener();
  private LogOffButtonListener logOffHandler = new LogOffButtonListener();
  
  public void init()
  {
    registerNewMem.addActionListener(regHandler);
    customerOrder.addActionListener(custOrderHandler);
    fillOrder.addActionListener(fillOrderHandler);
    stockOrder.addActionListener(stockOrderHandler);
    changeMemInfo.addActionListener(changeInfoHandler);
    updateOrder.addActionListener(updateOrderHandler);
    completeReturn.addActionListener(returnHandler);
    logOff.addActionListener(logOffHandler);
    
    Container cp = getContentPane();
    cp.setLayout(new GridLayout(3, 1, 5, 5));
    cp.add(registerNewMem);
    cp.add(customerOrder);
    cp.add(fillOrder);
    cp.add(stockOrder);
    cp.add(new JLabel(new ImageIcon("c:/RedFox.jpg")));
    cp.add(changeMemInfo);
    cp.add(updateOrder);
    cp.add(completeReturn);
    cp.add(logOff);
  }
  
  public static void run(JApplet applet, int width, int height)
  {
    JFrame frame = new JFrame("Red Fox Books and Wax - Main Menu");
    frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    frame.getContentPane().add(applet);
    frame.setSize(width, height);
    applet.init();
    applet.start();
    frame.setVisible(true);
  }
  
  public static void main(String[] args) 
  {
    run(new MenuScreen(), 625, 550);
  }
}

[Ben Zung]

Here is a little quick way to do what you wanted.
Move the JFrame variable in your run method in LoginScreen up to be a class level variable(don't forget to say static). And after you verified the 4-digit id, in front of run(new MenuScreen()...) add this code
frame.setVisible(false);
this ought to get rid of the login screen.

Good luck.

[Brandi Love]

I made those changes, but now when I click the logon button it, for lack of a better word, melded with the menu screen to make this:



Here's the changes I made to the code, bolded...

//****************************** Login Screen ******************************
 
public class LoginScreen extends JApplet 
{
  private JButton 
    login = new JButton("Login"), 
    exit = new JButton("Exit");
    //initializes login and exit buttons
  
  [B]static JFrame frame = new JFrame("Red Fox Books and Wax - Employee Login");[/B]
  
   class LoginButtonListener implements ActionListener //Controls the action if the login button is clicked.
    {
      public void actionPerformed(ActionEvent e)
      {
        String name, id;
        
        name = JOptionPane.showInputDialog("Enter your last name:");
        
        if (name.equals(""))
          JOptionPane.showMessageDialog(null, "Error: You did not enter a name. Please try again.", "ERROR", JOptionPane.WARNING_MESSAGE);
        //User is prompted to enter their last name. If they do not enter anything in the text box an error message pops up.
        
        id = JOptionPane.showInputDialog("Enter your 4 digit employee id number:");
   
        boolean isNum = true;
        for (int i = 0; i < id.length() && isNum; i++) 
        { 
          char c = id.charAt(i); 
          String numbers = "0123456789";
          if (numbers.indexOf(c) == -1) 
          {
            isNum = false;
          }
          else
          {
            isNum = true;
          }
        }
        //Checks if ID is a valid number.
 
        if (id.equals(""))
          JOptionPane.showMessageDialog(null, "Error: You did not enter an employee ID number. Please try again.", "ERROR", JOptionPane.WARNING_MESSAGE);
        else if (id.length() != 5 || isNum == false)
          JOptionPane.showMessageDialog(null, "Error: The employee ID you entered was not four numerical digits. Please try again.", "ERROR", JOptionPane.WARNING_MESSAGE);
        //User is prompted to enter their 5 digit employee ID. If they enter nothing or a string that is not 4 numbers an error message pops up.
        else
        {
          try
          {
            String filename = "c:/RFBAW/files/employees.txt";
            FileReader fr =
              new FileReader(filename);
            BufferedReader br =
              new BufferedReader(fr);
            //Needed for reading the file with the employee information.
  
            String inLine = ""; //Variable which will contain a line from the employees file.
            String lastName = ""; //Variable which will contain an employee last name pulled from inLine.
            String employeeID = ""; //Variable which will contain an employee ID pulled from inLine.
            boolean isValid = false; //Changed to true if the employee's information is verified.
            
            while (!inLine.equals("!EOF!") && isValid == false) 
            //Continues to check the file until the end is reached or the employee is verified.
            {
              inLine = br.readLine();
              if (!inLine.equals("!EOF!")) //Checks for end of file before pulling any more employee information.
              {
                StringTokenizer st =
                  new StringTokenizer(inLine); //Needed to seperate the last name from the employee ID.
                lastName = st.nextToken(); //Pulls the last name from inLine.
                employeeID = st.nextToken(); //Pulls the employee ID from inLine.
                if (name.equalsIgnoreCase(lastName) && id.equals(employeeID))
                  isValid = true;
                //If a match is found in the file with the employee ID and password the user has entered isValid is true and it breaks out of the loop.
              }
            }
            
            if (isValid == false)
              JOptionPane.showMessageDialog(null, "Error: The name and employee ID you entered did not match. Please try again.", "ERROR", JOptionPane.WARNING_MESSAGE);
            //If the employee information is not verified an error message pops up.
            else 
            {
              [B]frame.setVisible(false);[/B]
              run(new MenuScreen(), 625, 550);
            }
              
          }
          catch (IOException error) 
          {
            JOptionPane.showMessageDialog(null, "Error - IO exception caught", "ERROR", JOptionPane.WARNING_MESSAGE);
            //Catchs any IO exceptions. Needed for file IO.
          }
      }
    }
   }
    
    class ExitButtonListener implements ActionListener //Controls the action if the exit button is clicked.
    {
      public void actionPerformed(ActionEvent e)
      {
        System.exit(0); //Exits when the exit button is clicked.
      }
    }
    
    private LoginButtonListener lhandler = new LoginButtonListener();
    private ExitButtonListener ehandler = new ExitButtonListener();
    //Adds the handlers to the login and exit buttons.
    
    public void init()
    {
      login.addActionListener(lhandler);
      exit.addActionListener(ehandler);
      Container cp = getContentPane();
      cp.setLayout(new BoxLayout(cp, BoxLayout.LINE_AXIS));
      cp.add(Box.createVerticalStrut(10));
      cp.add(new JLabel(new ImageIcon("c:/RFBAW/files/RedFox.jpg")));
      cp.add(Box.createVerticalStrut(10));
      cp.add(new JSeparator(SwingConstants.VERTICAL));
      cp.add(Box.createVerticalStrut(10));
      cp.add(login);
      cp.add(Box.createHorizontalStrut(10));
      cp.add(exit);
      cp.add(Box.createVerticalStrut(10));
      //Sets layout for login window, adds buttons.
    }
 
    public static void run(JApplet applet, int width, int height)
    {
      frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
      frame.getContentPane().add(applet);
      frame.setSize(width, height);
      applet.init();
      applet.start();
      frame.setVisible(true);
      //Sets size for login applet and initializes it.
    }
    
    public static void main(String[] args) 
    {
      run(new LoginScreen(), 314, 200); //Calls run, which runs the applet.
    }
}

[Ben Zung]

Forgot to mention, instead of

  run(new MenuScreen(),625,550);
  

call it static way

  
MenuScreen.run(new MenuScreen(), 625, 550); //open in a new frame
  

should get rid of the overlap. And if not
try add

 
validate();
repaint();

to force a paint.
[ March 20, 2006: Message edited by: Ben Zung ]

[Brandi Love]

Yay, that fixed it! Thanks Ben!