Calculator Problem

[Samarth Barthwal]

HI,I made this small calculator which asks yser to enter two number and then performs the operation selected by user on clicking the button on the form.but it is giving error.The error comes when I want to write on the text field.Another error is the NullpointerException in main thread.How can i solve this problem.the code is as following:
Thanks in advance

import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
 

public class calcu extends JFrame implements ActionListener{
JTextField t1,t2,t3;
JButton b1,b2,b3,b4,b5;
JLabel l1,l2,l3;
JPanel p;
public calcu(String s)
{
 super(s);
 
 JTextField t1 = new JTextField();
 JTextField t2 = new JTextField();
 JTextField t3 = new JTextField();
 JButton b1 = new JButton("+");
 JButton b2 = new JButton("-");
 JButton b3 = new JButton("*");
 JButton b4 = new JButton("/");
 JButton b5 = new JButton("quit");
 JLabel l1 = new JLabel("enter the first number");
 JLabel l2 = new JLabel("enter the second number");
 JLabel l3 = new JLabel("result after the opearation");
 getContentPane().add(p);
 p.add(l1);
 p.add(t1);
 p.add(l2);
 p.add(t2);
 p.add(l3);
 p.add(t3);
 p.add(b1);
 p.add(b2);
 p.add(b3);
 p.add(b4);
 p.add(b5);
 b1.addActionListener(this);
 b2.addActionListener(this);
 b3.addActionListener(this);
 b4.addActionListener(this);
 b5.addActionListener(this);
}
 
 
  public void actionPerformed(ActionEvent ae)
  {
     String s1 = ae.getActionCommand();
     int  x = Integer.parseInt(t1.getText());
     int  y = Integer.parseInt(t2.getText());
     int z;
     float f;
     if(s1.equals("+"))
      {
       z = y+x;
       t3.setText(valueOf(z)); 
      }
    if(s1.equals("-"))
     {
       z = x-y;
       t3.setText(valueOf(z));
     }
    if(s1.equals("*"))
     {
      z = x*y;
      t3.setText(valueOf(z)); 
     }
   if(s1.equals("/"))
    {
     f = (float)x/y;
    t3.setText(valueOf(f)); 
    }
   if(s1.equals("quit"))
    {
     System.exit(0);
    }
 }
 

 
  public static void main(String sam[])
  {
    calcu w = new calcu("CALCULATOR");
    w.setSize(400,400);
    w.setVisible(true);
  }
 
} 

[Michael Dunn]

t3.setText(valueOf(z));

setText() requires a String argument.
what is valueOf(..)?
is it your own method?
perhaps it should be
String.valueOf(..)

next problem
JPanel p;
...
getContentPane().add(p);

somewhere, in between the declaration and its use, you will need
p = new JPanel(); //and set the layout if not FlowLayout

next problem
class variables
JButton b1,b2,b3,b4,b5;
local variables (to the constructor)
JButton b1 = new JButton("+");
JButton b2 = new JButton("-");
JButton b3 = new JButton("*");
JButton b4 = new JButton("/");
JButton b5 = new JButton("quit");

these will cause you problems in actionPerformed
change them to
b1 = new JButton("+");
b2 = new JButton("-");
b3 = new JButton("*");
b4 = new JButton("/");
b5 = new JButton("quit");

[EDIT] - same for the JTextFields, and the JLabels
[ April 15, 2006: Message edited by: Michael Dunn ]

[Campbell Ritchie]

I have come to the conclusion that there are three Exceptions which should not be tolerated:-

NullPointerException

XYZIndexOutOfBoundsException, and

ArithmeticException

They all mean you need to go back to your code and find out what you ahve done wrong.
In your case, you don't tell us what sort of error messages you are getting.
What are you getting from your compiler? Have you put in a method without its class?
In the case of your NullPointerException, go to the line in question, and immediately before it put in a line like this:
System.out.printf("this: %s, p %s%n", this, p);//test
What that will do is print out the "toString()" method of each of the objects which might or might not be null. You will get a printout something like this:-

this: calcu 8a2dfc7, f: null

One of those is the name of the class with its hashcode, the other is null.
Whichever of the two comes out as null, go back and find it, then:-

Check you haven't declared it twice by mistake; if you declare

JTextField t1, t2, t3; . . .
JTextField t1 = new JTextField();

you have got a local variable with the same name.

Check you have actually instantiated it. You can write, add(p = new JPanel());

[Samarth Barthwal]

I Thank you very much for your suggestions.They helped me a lot.