optimize tablemodel

[nomeaning]

hi all, after some changes in my implementation, my code has been now horrible.... i would like to optimize it. could you give me some ideas? Since i know i am using some elements of the view inside this model, i need to separate, thanks

public class TheTableModel extends AbstractTableModel {
 
    /**
     * field used for determining when the column correspond to groups: channel, tx type or hour
     */
    private static final int GROUP = 0;
 
    /**
     * field used to evaluate the column HIGH RISK
     */
    private static final int HIGH_RISK = 1;
 
    /**
     * field used to evaluate the column total.
     */
    private static final int TOTAL = 2;
 
    /**
     * field used to evaluate the column percentage
     */
    private static final int PERCENTAGE = 3;
 
    /**
     * field used to evaluate in column 0 (group) if it is Transfer when the group is 'Transaction Type'
     */
    private static final String TRANSFER = "100";
 
    /**
     * field used to evaluate in column 0 if it is Payment when the group is 'Transaction Type'
     */
    private static final String PAYMENT = "200";
 
    /**
     * field used to evaluate in column 0 if it is Withdrawal when the group is 'Transaction Type'
     */
    private static final String WITHDRAWAL = "300";
 
    /**
     * Constructor of the tablemodel which receives the column names
     * and the bunch of data of Object1 objects
     *
     * @param colNames
     * @param listOfObjects1
     */
    public SummaryTableModel(String[] colNames, ArrayList<Object1> listOfObjects1) {
        super(colNames, listOfObjects1);
    }
 
    /**
     * this method return the object (string) to set in the cell determined by the rowIndex and the column index.
     *
     * @param rowIndex
     * @param columnIndex
     * @return
     */
    public Object getValueAt(int rowIndex, int columnIndex) {
        String transactionType = null;
        Object1 object1 = (Object1) super.getElementAt(rowIndex);
        NumberFormat nf = NumberFormat.getInstance(Locale.getDefault());
 
        switch (columnIndex) {
            case GROUP:
                if (object1.getDimension() instanceof String) {
                    //checking if the data is transaction types or channel names 
                    if (object1.getDimension().equals(TRANSFER) ||
                            object1.getDimension().equals(PAYMENT) ||
                            object1.getDimension().equals(WITHDRAWAL)) {
                        transactionType = (String) object1.getDimension();
                        return getAppBundle().getString("transaction.type." + transactionType + ".name");
                    } else {
                        //Its the channel
                        return object1.getDimension();
                    }
                } else {
                    //it's an integer = the hour
                    return getAppBundle().getString("summary.tablemodel." + object1.getDimension() + ".msg");
                }
 
            case HIGH_RISK:
                return nf.format(object1.getDaily());
 

            case TOTAL:
                return nf.format(object1.getTotalDay());
 

            case PERCENTAGE:
                float percentToday = 0;
 
                if (object1.getTotalDay() != 0) {
                    percentToday = ((float) object1.getDaily() / (float) object1.getTotalDay()) * 100;
                }
                return String.format("%.1f%%", percentToday);
        }
        return null;
    }
 
    /**
     * @param i
     * @return
     */
    public Class getColumnClass(int i) {
        return String.class;
    }
}

[Ted Smyth]

How large a data set are you using?

[Rob Spoor]

What does object1.getDimension() do? You're potentially calling this method 5 times. If that method performs lengthy executions or creates several objects each time, you might want to cache the results at the start and use that cached value.

[Maneesh Godbole]

Hello "nomeaning".
Do take out time to read the naming policy.
You can change your display name here