ActionListener problem

[Swapnil Sonawane]

I have 4 java files:

MainFrame.java
MainFrameListener.java
ArenaPanel.java
ArenaListener.java

MainFrame extends JFrame and is the main window of my application. ArenaPanel is one of the several panels I have. MainFrame has a menu bar which has menu buttons to go to different panels. The arenaPanel has a SAVE button, actions for which have been defined in arenaListener. Actions for MainFrame menu have been defined in MainFrameListener. Here are my codes. I have removed the irrelavent parts at places as the codes are very long.

/**************** ArenaPanel.java *************/

    
import java.awt.*;
import javax.swing.*;
import java.awt.event.*;
import java.util.Calendar;
import java.sql.*;
/**
 * @author Swapnil Sonawane
 */
public class ArenaPanel extends JPanel {

private MainFrame parentFrame;
private String[] values;
private Connection conn;
private int delay;
private String expectedTime; 
private DefaultListModel model;
private DefaultComboBoxModel model2, model3;
private String hh, mm, ss;
private int h,m,s;
public ArenaPanel(MainFrame mainFrame) {
parentFrame = mainFrame;
initComponents();
}
    
    public int getActivityIndex() {
    return comboBox2.getSelectedIndex();
    }
    
    public void enableDescription(boolean myBoolean) {
    comboBox1.setEnabled(myBoolean);
    }
    
    public void enableTimeFields(boolean myBoolean) {
    comboBox3.setEnabled(myBoolean);
    comboBox4.setEnabled(myBoolean);
    textField1.setEnabled(myBoolean);
    textField2.setEnabled(myBoolean);
    }
    
    public void enableExplanation(boolean myBoolean) {
    textArea1.setEnabled(myBoolean);
    }
     
private void initComponents() {

ArenaListener arenaListener = new ArenaListener(this);
conn = parentFrame.getConnection();
label1 = new JLabel();
scrollPane1 = new JScrollPane();
label2 = new JLabel();
label3 = new JLabel();
label4 = new JLabel();
comboBox1 = new JComboBox();
label5 = new JLabel();
comboBox2 = new JComboBox();
comboBox5 = new JComboBox();
label6 = new JLabel();
label7 = new JLabel();
scrollPane3 = new JScrollPane();
textArea1 = new JTextArea();
comboBox3 = new JComboBox();
comboBox4 = new JComboBox();
label8 = new JLabel();
textField1 = new JTextField();
label9 = new JLabel();
label10 = new JLabel();
textField2 = new JTextField();
saveButton = new JButton();
label11 = new JLabel();
button2 = new JButton();
label13 = new JLabel();
label12 = new JLabel();
model = new DefaultListModel();
        list1 = new JList(model);
 
//======== this ========
 
setLayout(null);
 
//---- label1 ----
label1.setText("Library Arena");
label1.setHorizontalAlignment(SwingConstants.CENTER);
label1.setFont(new Font("Levenim MT", Font.BOLD, 18));
add(label1);
label1.setBounds(200, 25, 195, label1.getPreferredSize().height);
 
//======== scrollPane1 ========
{

//---- list1 ----
model.addElement("-----Select-----");
for(int i=0;i<parentFrame.emp.size();i++) {
model.addElement(parentFrame.emp.get(i).getFirstName()+" "+parentFrame.emp.get(i).getLastName());
}  
list1.setFont(new Font("Levenim MT", Font.BOLD, 12));
list1.setSelectedIndex(0);
scrollPane1.setViewportView(list1);
}
add(scrollPane1);
scrollPane1.setBounds(50, 120, 150, 185);
 
//---- label2 ----
label2.setText("Select Employee");
label2.setHorizontalAlignment(SwingConstants.CENTER);
label2.setFont(new Font("Tahoma", Font.BOLD, 12));
add(label2);
label2.setBounds(45, 90, 135, label2.getPreferredSize().height);
 
//---- label3 ----
label3.setText("Activity");
label3.setFont(new Font("Levenim MT", Font.BOLD, 12));
label3.setHorizontalAlignment(SwingConstants.CENTER);
add(label3);
label3.setBounds(255, 90, 75, label3.getPreferredSize().height);
 
//---- button1 ----
saveButton.setText("Save");
saveButton.addActionListener(arenaListener);
saveButton.setActionCommand("SAVE");
add(saveButton);
saveButton.setBounds(230, 445, 60, 30);
 
//---- label11 ----
label11.setText(" Shift ID  ");
label11.setFont(new Font("Levenim MT", Font.BOLD, 12));
add(label11);
label11.setBounds(70, 330, 90, 18);
 
//---- RESET button ----
button2.setText("Reset");
add(button2);
button2.setActionCommand("RESET");
button2.addActionListener(arenaListener);
button2.setBounds(310, 445, 65, 30);
 
//---- label12 ----

    add(comboBox5);
comboBox5.setBounds(135, 330, 45, comboBox5.getPreferredSize().height);
comboBox5.setModel(new DefaultComboBoxModel(new String[] {
"1",
"2",
"3",
}));
comboBox5.addActionListener(arenaListener);
comboBox5.setActionCommand("ACT");
 
//---- label13 ----
label13.setText("text");
label13.setFont(new Font("Verdana", Font.BOLD, 12));
add(label13);
label13.setBounds(425, 125, 90, 20);
 
setPreferredSize(new Dimension(620, 515));
// JFormDesigner - End of component initialization  //GEN-END:initComponents

javax.swing.Timer t = new javax.swing.Timer(1000, new ClockListener());
        t.start();
}
public int isInputValid() {

// Check if activity has been selected or not
if(comboBox2.getSelectedIndex()==0) {
return 1;
}

// Check if Description is needed and has been selected or not
if(((comboBox2.getSelectedIndex()>2))&&(comboBox1.getSelectedIndex()==0)) {
return 2;
}

// Check if any employee has been selected or not
if(list1.getSelectedIndex() <= 0) {
return 3;
}
return 0;
}
 
public void validate() {

int returnCode = isInputValid();
switch(returnCode) {

// The input is valid. Submit the information.
case 0:
submitInfo();
break;

// Activity has not been selected.
case 1: 
JOptionPane.showMessageDialog(null,"You have not selected any Activity.");
break;

// Description has not been selected.
case 2:
JOptionPane.showMessageDialog(null,"You have not selected any Description.");
break;

// Employee has not been selected.
case 3:
JOptionPane.showMessageDialog(null,"You have not selected any Employee.");
break;
}


}
     public void clear () {
     //Use this method to clear all fields in ArenaPanel 
     //ActionPerformed in case of Reset Button
     JOptionPane.showMessageDialog(null,"cleared");
     comboBox2.setSelectedIndex(0);
     comboBox1.setSelectedIndex(0);
     comboBox3.setSelectedIndex(0);
     comboBox4.setSelectedIndex(0);
     enableDescription(true);
     enableExplanation(true);
     enableTimeFields(true);
     list1.setSelectedIndex(0);
     textArea1.setText("");
     textField1.setText("0");
     textField2.setText("0");
     }
 
private JLabel label1;
private JScrollPane scrollPane1;
private JList list1;
// so on . . .not all mentioned here
// JFormDesigner - End of variables declaration  //GEN-END:variables
}
 

[Swapnil Sonawane]

/************* ArenaListener.java *******************/

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import javax.swing.table.*;


/**
* @author Swapnil Sonawane
*/

public class ArenaListener implements ActionListener {

ArenaPanel arenaPanel;

public ArenaListener(ArenaPanel panel) {
arenaPanel = panel;
}

public void actionPerformed(ActionEvent evt) {

String actionCommand = evt.getActionCommand();
if(actionCommand.equals("SAVE")) {
arenaPanel.validate();
}

else if(actionCommand.equals("RESET")) {
arenaPanel.clear();
}

else if(actionCommand.equals("ACT")) {
int selectedIndex = arenaPanel.getActivityIndex();
if((selectedIndex==1) || (selectedIndex==2)) {
arenaPanel.enableDescription(false);
arenaPanel.enableExplanation(false);
arenaPanel.enableTimeFields(false);
}
else {
arenaPanel.enableDescription(true);
arenaPanel.enableExplanation(true);
arenaPanel.enableTimeFields(true);
}

}

}
}

[Swapnil Sonawane]

    
/********************MainFrame.java ****************/
 
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import javax.swing.table.*;
import java.beans.*;
import javax.swing.border.*;
import javax.swing.plaf.metal.*;
import java.sql.*;
import java.util.ArrayList;
 
 
/**
 * @author Swapnil Sonawane
 */
public class MainFrame extends JFrame {
public MainFrame() {
importData();
initComponents();
}

// Database constants
private String url = "jdbc:mysql://localhost:3306/"; // Database URL
    private String dbName = "library"; // Database name
    private String driver = "com.mysql.jdbc.Driver"; // Driver name
    private String userName = "root"; // User name
    private String password = "chirkut"; // Password
    private Connection conn;
    
    // Database tables attributes
    public ArrayList<Employee>emp;
 
    
    // GUI attributes
private JLabel label1;
private JLabel label2;
private JLabel label3;
private JLabel label4;
        // more here..
 
       private void initComponents() {

   MainFrameListener mainFrameListener = new MainFrameListener(this);
   menuBar1 = new JMenuBar();
   menu5 = new JMenu();
           // so on..
 
//======== this ========
setTitle("Library Time Manager 1.0");
setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
setResizable(false);
loginPanel = new LoginPanel(this);
infoScreen = new InformationScreen(this);
arenaPanel = new ArenaPanel(this);
staticDetails = new StaticDetails(this);
recordBook = new RecordBook(this);
statistics = new Statistics(this);
shiftScheduler = new ShiftScheduler(this);

Toolkit theKit = (new JFrame()).getToolkit();
screenSize = theKit.getScreenSize();
BorderLayout border = new BorderLayout(screenSize.width/5,screenSize.height/8);
getContentPane().setLayout(border);
getContentPane().add(label1, BorderLayout.WEST);
getContentPane().add(label2, BorderLayout.NORTH);
getContentPane().add(label3, BorderLayout.SOUTH);
getContentPane().add(loginPanel, BorderLayout.CENTER);
getContentPane().add(label4, BorderLayout.EAST);

loginPanel.setVisible(true);
infoScreen.setVisible(false);
arenaPanel.setVisible(false);
staticDetails.setVisible(false);
recordBook.setVisible(false);
statistics.setVisible(false);
shiftScheduler.setVisible(false);
 
               //now the menu bar  ========
{
//======== menu5 ========
{
  menu5.setText("GoTo");
    menu5.add(menuItem11);
                 menuItem11.setText("Arena");
                 menuItem11.addActionListener(mainFrameListener);
                 menuItem11.setActionCommand("Arena");
                 menuItem11.setEnabled(false);
 menuItem12.setText("Information Screen");
 menuItem12.setEnabled(false);
                 // so on .. but i have only added the mainFrameListener for menu items.
   

/***************** MainFrameListener.java *************/

   
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import javax.swing.table.*;
 
 
/**
 * @author Swapnil Sonawane
 */
 
public class MainFrameListener implements ActionListener {

private MainFrame mainFrame;

public MainFrameListener(MainFrame frame) {
mainFrame = frame;
}

public void actionPerformed(ActionEvent evt) {

String actionCommand = evt.getActionCommand();
if(actionCommand.equals("EXIT")) {
System.exit(0);

}
else if (actionCommand.equals("Information Screen")){
     mainFrame.getInfoScreen();//RadioButton Info Screen is Clicked

}
else if(actionCommand.equals("Arena")){
mainFrame.getArena(); // RadioButton Arena is selected
}

else if(actionCommand.equals("STATIC")) {
mainFrame.getStaticDetails();
}

else if(actionCommand.equals("SCREEN")) {
mainFrame.editInfoScreen();
}

else if(actionCommand.equals("RECORD")) {
mainFrame.getRecordBook();
}

else if(actionCommand.equals("STATISTICS")) {
mainFrame.getStatistics();
}

else if(actionCommand.equals("SHIFT")) {
mainFrame.getShiftScheduler();
}

else if(actionCommand.equals("About")){
String about="     Library Time Manager 1.0 \n\n An Application To Manage Staff Details \n\n\n Developed By: NITD_Developers";
JOptionPane.showMessageDialog(mainFrame,about);
}
else if(actionCommand.equals("Help Topics")){
mainFrame.openHelpWindow();

}
else if(actionCommand.equals("Credits")) {
String credits= "    Library Time Manager 1.0 \n\n\n Developed By:NITD_developers";
JOptionPane.showMessageDialog(mainFrame,credits);
}
else if(actionCommand.equals("Settings")) {
mainFrame.openPrefsWindow();
}

}

}
 

The problem is that once I visit ArenaPanel, I mean click on that menu and then move to other panels, clicking on any other menu options in the MainFrame menu bar activates that button and it listens to ArenaListener. I tried to debug but didn't get it. It's strange.
I am trying to say that even if I remove the save button from the arenapanel the job that should be done after clicking on save button is done without clicking on it and clicking somewhere else in the menu bar. And this happens after I visit arenapanel once and not before that. Strange enough for me



Thanks.
[ October 14, 2008: Message edited by: Swapnil Sonawane ]

[Swapnil Sonawane]

got it solved after renaming validate() to validateIt()

[Campbell Ritchie]

Well done and it saves us reading all that code.

The validate() method is a standard API method in Container which checks the alignment and location of all the added Components before displaying them.