Need advise with this servlet please!!!!

[Andres Gonzalez]

Hi guys. The general idea of this servlet is:
1o.) makes a connection to a database. For every record in the resultSet, the servlet creates a bean and stores it in a vector. Then, when the resultset is finished, I put the vector in the request (request,setAttribute(...)), so I can have access to it in the JSP page. Here's the code my friends:

public class Controller extends HttpServlet {
.....
    public void doGet (HttpServletRequest request,HttpServletResponse response) throws ServletException, IOException 
    {
        processRequest(request, response);
    }
    
    public void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, java.io.IOException 
    {
        processRequest(request, response);
    }
    
    
    private void processRequest(HttpServletRequest request, HttpServletResponse response) throws ServletException, java.io.IOException 
    {
        Connection conn = null;
        Statement stmt = null;
        int thisConnection;
        ResultSet results;
        PrintWriter out = response.getWriter();
        response.setContentType ("text/html");
        try 
        {
            // Get a DB connection from the Broker
            conn = myBroker.getConnection();
            String queryFormat = "SELECT * from ITEM where ITEM_TYPE = 'special'";
            Statement statement = conn.createStatement();
            results = statement.executeQuery(queryFormat);
            //creates a vector            
            Vector listResults = new Vector();
            //a bean is added to the vector, check makeBean
            while (results.next())
            {
                listResults.add(makeBean(results));
            }
            // now the vector is set in the request
            request.setAttribute("list",listResults);

        } 
         catch (SQLException e1) 
           {
        out.println("<i><b>Error code:</b> " + e1 + "</i>");
   } 
         finally 
         {
            try{if(stmt != null) {stmt.close();}} catch(SQLException e1){};
             // The connection is returned to the Broker
            myBroker.freeConnection(conn);
            gotoPage("/index2.jsp",request,response);
         }
    } 
    private ProductBean makeBean(ResultSet results) throws SQLException
    {
        
        ProductBean bean = new ProductBean(results.getInt("ITEM_ID"));
        bean.setCategory_id(results.getInt("CATEGORY_ID"));
        bean.setCompany_id(results.getInt("COMPANY_ID"));
        bean.setItem_date_posted(results.getString("ITEM_DATE_POSTED"));
        bean.setItem_exp_date(results.getString("ITEM_EXP_DATE"));
        bean.setItem_long_description(results.getString("ITEM_LONG_DESCRIPTION"));
        bean.setItem_price(results.getInt("ITEM_PRICE"));
        bean.setItem_short_description(results.getString("ITEM_SHORT_DESCRIPTION"));
        bean.setItem_status(results.getString("ITEM_STATUS"));
        bean.setItem_type(results.getString("ITEM_TYPE"));
        bean.setUser_email(results.getString("USER_EMAIL"));
        return bean;
    }
    private void gotoPage(String address, HttpServletRequest request, HttpServletResponse response) throws ServletException, java.io.IOException 
    {
        RequestDispatcher dispatcher = getServletContext().getRequestDispatcher(address);
        dispatcher.forward(request,response);
    }
}

So far so good. Now, in the JSP page I do this:

 
public class Controller extends HttpServlet {
.....
    public void doGet (HttpServletRequest request,HttpServletResponse response) throws ServletException, IOException 
    {
        processRequest(request, response);
    }
    
    public void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, java.io.IOException 
    {
        processRequest(request, response);
    }
    
    
    private void processRequest(HttpServletRequest request, HttpServletResponse response) throws ServletException, java.io.IOException 
    {
        Connection conn = null;
        Statement stmt = null;
        int thisConnection;
        ResultSet results;
        PrintWriter out = response.getWriter();
        response.setContentType ("text/html");
        try 
        {
            // Get a DB connection from the Broker
            conn = myBroker.getConnection();
            String queryFormat = "SELECT * from ITEM where ITEM_TYPE = 'special'";
            Statement statement = conn.createStatement();
            results = statement.executeQuery(queryFormat);
            //creates a vector            
            Vector listResults = new Vector();
            //a bean is added to the vector, check makeBean
            while (results.next())
            {
                listResults.add(makeBean(results));
            }
            // now the vector is set in the request
            request.setAttribute("list",listResults);

        } 
         catch (SQLException e1) 
           {
        out.println("<i><b>Error code:</b> " + e1 + "</i>");
   } 
         finally 
         {
            try{if(stmt != null) {stmt.close();}} catch(SQLException e1){};
             // The connection is returned to the Broker
            myBroker.freeConnection(conn);
            gotoPage("/index2.jsp",request,response);
         }
    } 
    private ProductBean makeBean(ResultSet results) throws SQLException
    {
        
        ProductBean bean = new ProductBean(results.getInt("ITEM_ID"));
        bean.setCategory_id(results.getInt("CATEGORY_ID"));
        bean.setCompany_id(results.getInt("COMPANY_ID"));
        bean.setItem_date_posted(results.getString("ITEM_DATE_POSTED"));
        bean.setItem_exp_date(results.getString("ITEM_EXP_DATE"));
        bean.setItem_long_description(results.getString("ITEM_LONG_DESCRIPTION"));
        bean.setItem_price(results.getInt("ITEM_PRICE"));
        bean.setItem_short_description(results.getString("ITEM_SHORT_DESCRIPTION"));
        bean.setItem_status(results.getString("ITEM_STATUS"));
        bean.setItem_type(results.getString("ITEM_TYPE"));
        bean.setUser_email(results.getString("USER_EMAIL"));
        return bean;
    }
    private void gotoPage(String address, HttpServletRequest request, HttpServletResponse response) throws ServletException, java.io.IOException 
    {
        RequestDispatcher dispatcher = getServletContext().getRequestDispatcher(address);
        dispatcher.forward(request,response);
    }
}
 

The problem is that the JSP doesn't show anything at all! . I've tested with println in the servlet and the servlet is creating the bean correctly with the information and it is added propertly to the vector, but when I try to access it from the JSP page the vector has the number of records but no data at all...
Any ideas guys? i really apreciate it...
cheers

[Andres Gonzalez]

Sorry guys, the JSP is this one:

<%@page contentType="text/html"%>
<%@ page import ="java.util.*" %>
<html>
<head><title>Welcome!! </title></head>
<body>
<jsp:useBean id="item" class="Bulletin.ProductBean"/>
<b>Current products</b>
<ul>
<%
   Vector v = (Vector)request.getAttribute("list");
   Iterator i = v.iterator();
   int num = 0;
   while (i.hasNext())
   {
      item = (Bulletin.ProductBean)i.next();
%>
<li>
test Short description : <jsp:getProperty name="item" property="item_short_description"/>
<jsp:getProperty name="item" property="item_long_description"/>
<%
   }
%>
</ul>
</body>
</html>
  

[Craig Jackson]

I believe the soluction to your problem is that you need to declare an import statement which imports Bulletin.ProductBean instead of using the <jsp:usebean> command and then declare either a global or local reference to the bean which you will access in your while loop.
such as...
<%@ page import Bulletin.ProductBean %>
<%! ProductBean items; %> or
ProductBean items = (ProductBean)i.next();
What do you think.

[Andres Gonzalez]

Yes, that was the "error". thank you so much. This is really weird. I've been following an example like this one in web development with JavaServer pages book. THis means the book is wrong, coz I was using the same conventions as they were..
thanks again. This is the code:

<%@page contentType="text/html"%>
<%@ page import ="java.util.*,Bulletin.ProductBean" %>
<html>
<head><title>Welcome!! </title></head>
<body>
<b>Current products</b>
<ul>
<%
   ProductBean item;
   Vector v = (Vector)request.getAttribute("list");
   Iterator i = v.iterator();
   int num = v.size();
   while (i.hasNext())
   {
     item = (ProductBean)i.next();
%>
<li>
Description test : <%= item.getItem_long_description() %>
<%
   }
%>
</ul>
</body>
</html>

cheers