File APIs for Java Developers
Manipulate DOC, XLS, PPT, PDF and many others from your application.
http://aspose.com/file-tools
The moose likes Servlets and the fly likes Is it costly to do req.getParameter() multiple times?? Big Moose Saloon
  Search | Java FAQ | Recent Topics | Flagged Topics | Hot Topics | Zero Replies
Register / Login


JavaRanch » Java Forums » Java » Servlets
Bookmark "Is it costly to do req.getParameter() multiple times??" Watch "Is it costly to do req.getParameter() multiple times??" New topic
Author

Is it costly to do req.getParameter() multiple times??

Sajee Joseph
Ranch Hand

Joined: Jan 17, 2001
Posts: 200
Hello all,
Please have a look at the statement below? Do u think there is an overheade in the statement (since req.getParameter() is done twice when the paramenet is not null).
String sSearchBy = req.getParameter("SearchBy")==null?"" String)req.getParameter("SearchBy");
Is there a better way to optimize the code??
Thanks,
Sajee Joseph
Frank Carver
Sheriff

Joined: Jan 07, 1999
Posts: 6920
You wrote: String sSearchBy = req.getParameter("SearchBy")==null ? "" : ( String)req.getParameter("SearchBy");
Sure, there's plenty of ways to improve this, for example:

Personally, I don't particularly like to hard code the default value ("") in situations like this, so I'd probably take a few minutes to write something like:

The in my code I could use the more expressive:

The biggest advantage of this approach is that it makes it so simple to appy a default value when reading parameters, that I'm much more likely to consider doing it every time, and not risk risk run-time failures through laziness.


Read about me at frankcarver.me ~ Raspberry Alpha Omega ~ Frank's Punchbarrel Blog
 
Don't get me started about those stupid light bulbs.
 
subject: Is it costly to do req.getParameter() multiple times??