Problem with sending E-mail

[Azz Romaysa]

Hi,

I've a problem with sending an E-mail to multiple reciepients.

This is the method that gets all the E-mail addresses I have:

  public String[] getAlleEmails(){
 conn.openConnection();
 String selectQuery = "select * from website_nieuwsbrief_gebruiker";

Vector emails = new Vector();
ResultSet rs = conn.getInformation(selectQuery,1);
System.out.println("===== De E-mails zijn goed geselecteerd.");
 
try{
while(rs.next()){
emails.add (rs.getString("NIEUSBRIEF_GEBRUIKER_EMAIL"));

}
if (emails.size() == 0)
System.out.println("===== De value van de geselecteerde E-mails is leeg.");
}
    catch( Exception e ) {
System.out.println(e);
System.out.println("===== Er kan geen E-mails geselecteerd worden.");
}
 finally{
 conn.disconnect();
}
String[] mijnEmails = new String[emails.size()];
emails.toArray();

return mijnEmails;

 
 }
 

Here I call my methode:

     public void doPost(HttpServletRequest req, HttpServletResponse res)
        throws ServletException, IOException
    {
        
        String query = "";
        
        String emailTitel = req.getParameter("titel");
        String emailContent = req.getParameter("bericht");
            
   System.out.println("************************ EN NU ZIJN DE EMAILS: ****************************"+pf.getAlleEmails());
   Mail mail = new Mail();
   mail.setTO(pf.getAlleEmails());
   mail.setFROM(pf.getUitgaandeEmail(req, res));
   mail.setContent(emailTitel,emailContent);
   mail.send();
       System.out.println("===== Het versturen van e-mail naar IRN is gelukt");
       mail = null;
 

 
req.setAttribute("succesMelding", "8" );
gotoPage("/succes.jsp", req, res);
 
 }
 

My Mail.java:

     public void setTO(String to[]){
        try{
            InternetAddress internetAddresses[] = new InternetAddress[to.length];
            for(int i = 0; i < to.length; i++)
                internetAddresses[i] = new InternetAddress("" + to);
 
            message.setRecipients(javax.mail.Message.RecipientType.TO, internetAddresses);
        }
        catch(MessagingException e){
            e.printStackTrace();
        }
    }
 

And this is the Exception what I still get:

 ************************ EN NU ZIJN DE EMAILS: ****************************[Ljav
a.lang.String;@1bbd23f javax.mail.internet.AddressException: Missing ']' in string ``[Ljava.lang.String
;@186df0f'' at position 27
        at javax.mail.internet.InternetAddress.parse(InternetAddress.java:660)
        at javax.mail.internet.InternetAddress.<init>(InternetAddress.java:61)
        at Mail.setTO(Mail.java:25)
        at NewsLetter.doPost(NewsLetter.java:30)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:165)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:103)
        at com.caucho.server.http.FilterChainServlet.doFilter(FilterChainServlet
.java:96)
        at com.caucho.server.http.Invocation.service(Invocation.java:315)
        at com.caucho.server.http.CacheInvocation.service(CacheInvocation.java:1
35)
        at com.caucho.server.http.HttpRequest.handleRequest(HttpRequest.java:246
)
        at com.caucho.server.http.HttpRequest.handleConnection(HttpRequest.java:
163)
        at com.caucho.server.TcpConnection.run(TcpConnection.java:139)
        at java.lang.Thread.run(Thread.java:534) 

Could soemone help me to fix this problem???

Abu Romaysa,

[Carl Trusiak]

You are getting the toString of the String array and not the String at an array position:

    public void setTO(String to[]){
        try{
            InternetAddress internetAddresses[] = new InternetAddress[to.length];
            for(int i = 0; i < to.length; i++)
                internetAddresses[i] = new InternetAddress("" + to);
 
            message.setRecipients(javax.mail.Message.RecipientType.TO, internetAddresses);
        }
        catch(MessagingException e){
            e.printStackTrace();
        }
    }

Change this to:

    public void setTO(String to[]){
        try{
            InternetAddress internetAddresses[] = new InternetAddress[to.length];
            for(int i = 0; i < to.length; i++)
                internetAddresses[i] = new InternetAddress("" + to[i]);
 
            message.setRecipients(javax.mail.Message.RecipientType.TO, internetAddresses);
        }
        catch(MessagingException e){
            e.printStackTrace();
        }
    }

Try it again.

[Paul Sturrock]

You seem to be trying to pass an array of strings to a constructor which does not accept string arrays in Mail.java:

internetAddresses[i] = new InternetAddress("" + to);

Thats not going to work.

[Azz Romaysa]

Thanks for your replays,

I tried what you said but still get this Exception:

 javax.mail.SendFailedException: Sending failed;
  nested exception is:
        javax.mail.MessagingException: 550 Invalid recipient: ,
 
        at javax.mail.Transport.send0(Transport.java:219)
        at javax.mail.Transport.send(Transport.java:81)
        at Mail.send(Mail.java:79)
        at NewsLetter.doPost(NewsLetter.java:33)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:165)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:103)
        at com.caucho.server.http.FilterChainServlet.doFilter(FilterChainServlet
.java:96)
        at com.caucho.server.http.Invocation.service(Invocation.java:315)
        at com.caucho.server.http.CacheInvocation.service(CacheInvocation.java:1
35)
        at com.caucho.server.http.HttpRequest.handleRequest(HttpRequest.java:246
)
        at com.caucho.server.http.HttpRequest.handleConnection(HttpRequest.java:
163)
        at com.caucho.server.TcpConnection.run(TcpConnection.java:139)
        at java.lang.Thread.run(Thread.java:534) 

[Carl Trusiak]

Print out the list of email addresses you are sending this to. That should clarify things

[Paul Sturrock]

So the addresses are now valid SMTP email addresses (otherwise you'd still see the AddressException) but your SMTP server is sending back a 550 message. That means the requested action cannot be taken, because the mailbox is unavailable to whichever user tried to preform the action, either because it doesn't exist or access is denied (you can find this out by reading the right RFC by the way).

[Carl Trusiak]

InternetAdress validates the String is a valid Internet Address and not a valid Email address (not even in form) A lot of Strings are valid Internet Addresses but, not a validly formed email address. The failure he is getting now is caused by one of the Strings in the list. It appears to be a comma or empty String. Scrubbing a List of String to ensure each is a valid appearing email address takes a bit more work.

[Azz Romaysa]

Yes the problem is in the method that gets the e-mails addresses from the database.

When I printed out the result of my array I got this: [Ljava.lang.String;@d17ec3
and that means an invalid e-mail address.

is something wrong with my methode?

 public String[] getAlleEmails(){
 conn.openConnection();
 String selectQuery = "select * from website_nieuwsbrief_gebruiker";

Vector emails = new Vector();
ResultSet rs = conn.getInformation(selectQuery,1);
System.out.println("===== De E-mails zijn goed geselecteerd.");
 
try{
while(rs.next()){
emails.add (rs.getString("NIEUSBRIEF_GEBRUIKER_EMAIL"));

}
if (emails.size() == 0)
System.out.println("===== De value van de geselecteerde E-mails is leeg.");
}
    catch( Exception e ) {
System.out.println(e);
System.out.println("===== Er kan geen E-mails geselecteerd worden.");
}
 finally{
 conn.disconnect();
}
String[] mijnEmails = new String[emails.size()];
emails.toArray();

return mijnEmails;

 
 } 

[Carl Trusiak]

You need to read up on Arrays in Java but, try this:

    public void setTO(String to[]){
        try{
            InternetAddress internetAddresses[] = new InternetAddress[to.length];
            for(int i = 0; i < to.length; i++){
                internetAddresses[i] = new InternetAddress("" + to[i]);
                 System.out.println("Address # " + i + " : " + to[i]);
            }
 
            message.setRecipients(javax.mail.Message.RecipientType.TO, internetAddresses);
        }
        catch(MessagingException e){
            e.printStackTrace();
        }
    }

[Azz Romaysa]

Thanks Carl,

Here is what I got when I tried to send an e-mail:

Address # 0 : null
Address # 1 : null
[ January 31, 2005: Message edited by: Azz Romaysa ]

[Azz Romaysa]

Thanks very very much ...

The problem is fixed. The problem was in the method that gets the e-mail addresses, it returned a null, cause the way how I converted my Vector to an Array was wrong.

This has fixed the problem: String[] mijnEmails = (String[]) emails.toArray(new String[emails.size()]);

Abu Romaysa,

[Paul Sturrock]

InternetAdress validates the String is a valid Internet Address and not a valid Email address (not even in form) A lot of Strings are valid Internet Addresses but, not a validly formed email address. The failure he is getting now is caused by one of the Strings in the list. It appears to be a comma or empty String. Scrubbing a List of String to ensure each is a valid appearing email address takes a bit more work

Well actually the InternetAddresses class parses the String to ensure its RFC822 compliant, unless you tell it not to. 822 compliant == a valid SMTP email address. Passing a null to the constructor is not valid, unless you do as Azz Romaysa has done and concatenate a blank string onto it.