File APIs for Java Developers
Manipulate DOC, XLS, PPT, PDF and many others from your application.
http://aspose.com/file-tools
The moose likes Servlets and the fly likes What do you think of my filter ? Big Moose Saloon
  Search | Java FAQ | Recent Topics | Flagged Topics | Hot Topics | Zero Replies
Register / Login
JavaRanch » Java Forums » Java » Servlets
Bookmark "What do you think of my filter ?" Watch "What do you think of my filter ?" New topic
Author

What do you think of my filter ?

Hussein Baghdadi
clojure forum advocate
Bartender

Joined: Nov 08, 2003
Posts: 3479

Hi.
I'm creating a small web forum, this forum uses cookies to store username and password.
This app contains a servlet filter, this filter is responsible to try to collect the cookies and create a session scope object contains the informations (this filter is applied to all pages in the app).
Some code:

getUserFromCookies(request, session); is a method iterates over the cookies in user's cache and try to create a session scope object.
What do you think of my design ? is it good (implementation, performance, a hole ....)
Thanks guys.
Jeanne Boyarsky
author & internet detective
Marshal

Joined: May 26, 2003
Posts: 31882
    
197

John,
The logic/design are sound. My only question is why you are passing both request and session to the getUserFromCookies method. As you can get either from the other, this is a redundant parameter.

I would also move the chain doFilter() call outside the if statement since it is done either way. The intent is a bit clearer that way.



[OCA 8 book] [Blog] [JavaRanch FAQ] [How To Ask Questions The Smart Way] [Book Promos]
Blogging on Certs: SCEA Part 1, Part 2 & 3, Core Spring 3, OCAJP, OCPJP beta, TOGAF part 1 and part 2
 
With a little knowledge, a cast iron skillet is non-stick and lasts a lifetime.
 
subject: What do you think of my filter ?