HttpServletRequest, getServletPath as controller

[Jesus Angeles]

Any one has experience where getServletPath is not useful (not reliable) in determining which path was used to connect to the servlet?

Servlet 2.4 specs

 getServletPath()
public java.lang.String getServletPath()
Returns the part of this request�s URL that calls the servlet. This path starts
with a �/� character and includes either the servlet name or a path to the servlet,
but does not include any extra path information or a query string. Same as
the value of the CGI variable SCRIPT_NAME.
This method will return an empty string (��) if the servlet used to process this
request was matched using the �/*� pattern.
Returns: a String containing the name or path of the servlet being called,
as specified in the request URL, decoded, or an empty string if the servlet
used to process the request is matched using the �/*� pattern.

My code

  public void doPost(HttpServletRequest req, HttpServletResponse resp)
throws ServletException, IOException {
 
String accessPath = req.getServletPath();
 
if (accessPath.equals("/XXXXSPPFlatDetailSold")) {
                        <codes here>
processSoldAndRent(req, resp);
} else if (accessPath.equals("/XXXXSPPFlatDetailRent")) {
                        <codes here>
processSoldAndRent(req, resp);
} else
processSelected(req, resp);
 
}  

My descriptor

  <servlet>
<servlet-name>XXXXSPPFlatDetailController</servlet-name>
<display-name>XXXXSPPFlatDetailController</display-name>
<servlet-class>Main.XXXXSPPFlatDetailController</servlet-class>
</servlet>
 
<servlet-mapping>
<servlet-name>XXXXSPPFlatDetailController</servlet-name>
<url-pattern>/XXXXSPPFlatDetailSold</url-pattern>
</servlet-mapping>
<servlet-mapping>
<servlet-name>XXXXSPPFlatDetailController</servlet-name>
<url-pattern>/XXXXSPPFlatDetailRent</url-pattern>
</servlet-mapping>
<servlet-mapping>
<servlet-name>XXXXSPPFlatDetailController</servlet-name>
<url-pattern>/XXXXSPPFlatDetailSelected</url-pattern>
</servlet-mapping>  

(As you can see, I did not use /*)

[ December 15, 2006: Message edited by: Jesus Angeles ]
[ December 15, 2006: Message edited by: Jesus Angeles ]

[Bear Bibeault]

First and foremost, why on earth use if-then-else rather than separate servlets? What a mess!

If you are trying to create a unified Front Controller, if-then-else is still not the way to go. Look into the Command pattern.

Secondly, things can get complicated when dealing with includes and forwards. Is this the case?
[ December 15, 2006: Message edited by: Bear Bibeault ]

[Bear Bibeault]

By the way, I have no idea what the "req" in your subject is supposed to mean. Please use real words when posting.

[Jesus Angeles]

My design (although working) may need improvement. (I have an excuse, its my first, and only 6 months into j2ee design/implement. But yes, there is no excuse for stuff blowing up in production.)

But the application was installed already last week, and I am researching if that sole logic on 'control' is bullet-proof.

That is:
1. The (j2ee) system will allow entry, only on those 3 servlet mapping (The class are inside web-inf, therefore are not accessible directly? ; whether server was set to allow direct or indirect component access).

2. That that method getServletPath will return those 3 exact String.

(The system is on https and has authentication.)

[Jesus Angeles]

I might have used some sort of pattern, but I did not intend to do so. My design was simply brought by a huge logic that I could have broken down to methods or classes.

(I edited the title, for the 'req')
[ December 15, 2006: Message edited by: Jesus Angeles ]