Session Attribute value Ertatic

[Steve Dyke]

I have a JSP that acts as a logon page. It requests a servlet(jQuery). That servlet calls a class that returns a user default value. Then the value is set to a session attribute. Now, I click a link on the same JSP to request another servlet(jQuery) using the attribute value as "${myAttribute}".

Sometimes all is well but then at times my request fails because the attribute value is blank.

The only way I can get it to consistantly work is to bring the default value back as a parameter in my jQuery call.

[William Brogden]

"blank" or null?

That servlet calls a class that returns a user default value.

Suspicion immediatly falls on this "class" - is that really a static method or is there a class instance?

Bill

[Steve Dyke]

From my doGet of the servlet I have:

GetUserPrefs gupConn = new GetUserPrefs();
 
gupConn.setUserPrefs(p0, gConn.getAs400Conn());
 

My Class:

 
public class GetUserPrefs {
private String errorString;
private String deptdefault;
private String userp2;
private String userp3;
private String userp4;
private String userp5;


public GetUserPrefs() {

}
    
public void setUserPrefs(String arg0, Connection arg1){
        
        try{
     
        this.deptdefault = "";
        this.userp2 = "";
        this.userp3 = "";
        
        Statement stmt = arg1.createStatement();
        Statement stmta = arg1.createStatement();
        Statement stmtb = arg1.createStatement();
        
        String sql = "SELECT * From webprddt6.resmngt10 Where userid = '" + arg0.toUpperCase() + "'";
            
        ResultSet rs = stmt.executeQuery(sql);
        if(rs.next()){
        this.deptdefault = rs.getString("deptno").trim();
        this.userp2 = rs.getString("userp2").trim();
        this.userp3 = rs.getString("userp3").trim();
        
        this.errorString =  "NoError";
                
                rs.close();
                //System.out.println(this.deptdefault);
        }
        else{
        
        String sqla = "Insert Into webprddt6.resmngt10(userid) Values('" + arg0.toUpperCase() + "')";
        stmta.executeUpdate(sqla);
        this.errorString =  "NoError";
        
        String sqlb = "SELECT * From webprddt6.resmngt10 Where userid = '" + arg0.toUpperCase() + "'";
                
            ResultSet rsb = stmt.executeQuery(sqlb);
            if(rsb.next()){
            this.deptdefault = rsb.getString("deptno").trim();
            this.userp2 = rsb.getString("userp2").trim();
            this.userp3 = rsb.getString("userp3").trim();
            
            this.errorString =  "NoError";
                    
                    
            }
            rsb.close();
        }
        
        stmtb.close();
        stmta.close();
            stmt.close();
                               
        }
        catch (SQLException sqle){
        this.errorString = "Error";
        System.out.println(sqle);
     }
}
   
public String getDeptDefault(){
if(this.deptdefault.equals("All")){
return "";
}
else{
return this.deptdefault;
}
}

public String getUserp2(){
return this.userp2;
}

public String getUserp3(){
if(this.userp3.equals("")){
return "All";

}
else{
return this.userp3;
}
}

public String getErrorString(){
return this.errorString;
}


public static GetUserPrefs getUPString() {
return new GetUserPrefs();

}
}
 

[Steve Dyke]

Still need some help with this.

[William Brogden]

IF - attributes occasionally show up blank - ie empty string
THEN - there must be a path through your code that fails before the initialized value of "" gets set to another value

I would look for Exceptions that are not correctly reported.

Bill