code too long

[sanjeev mehra]

I am getting data from excel sheet & creating a two dim object array.
I am able to generate java code successfully file based on that data excel
But while compilation of that file, I am getting code too long error.
I am able to create two dim object array of 2425 rows but more than that is not working.
I am surprised that there is limit for writing code in java file.
I will appreciate your comments.
Thanks.

[Paul Sturrock]

I am surprised that there is limit for writing code in java file.

There isn't. Show us your code (or a truncated version if it is very long).

[sanjeev mehra]

  
 
package com.abc.xyz;
 
import java.io.Serializable;
import java.util.ListResourceBundle;
import com.abc.xyz.qwe.resources.ReflectionHelperBundle;
import com.abc.cvb.logging.xyzLogger;
 
/**
 * Provides a list of Data Objects to be used when performing unit test cases.
 * @author 
 * @version
 */
 
public class ForPartyBundle extends ReflectionHelperBundle implements Serializable {
    protected static xyzLogger logger =       xyzLogger.getXYZLogger(ForPartyBundle.class);
    /**
     * getContents
     * @return Object[][]
     */
    protected Object[][] getContents () {
        return contents;
    }
 
  
    static final Object[][] contents = {
    
        {"1", newBundleObject((int)5022.0)}
        ,
        {"2", newBundleObject((int)5023.0)}
        ,
        {"3", newBundleObject((int)5024.0)}
        ,
        {"4", newBundleObject((int)5025.0)}
        ,
        {"5", newBundleObject((int)5026.0)}
        ,
        {"6", newBundleObject((int)5027.0)}
        ,
        {"7", newBundleObject((int)5028.0)}
        ,
        {"8", newBundleObject((int)5029.0)}
        ,
        {"9", newBundleObject((int)5031.0)}
        ,
        {"10", newBundleObject((int)5032.0)}
        ,
        .
        .
        .
        .
        
        {"2425", newBundleObject((int)135968.0)}
        
    };
 
 
 
    private static ActivityTestDataObject newBundleObject(int forPartyId) {
        ActivityTestDataObject ret = new ActivityTestDataObject();
try{
ret.setPartyId(forPartyId);
}
catch(Exception e){
         logger.fatal("exception in bundle for Key:"+key,e);
}

        return ret;
    }
}

able to compile this file.

if I add more records in excel file, I am able to generate java file properly but when I compile it, it gives me error.
[ October 04, 2005: Message edited by: sanjeev mehra ]

[Ernest Friedman-Hill]

There is indeed a limit to the amount of bytecode in a method. Initializing a long array can exceed that limit. Instead of hardcoding the data, write it into a file, and have the class read it in at runtime.

[Stan James]

Yikes, I'd guess you've run into a system or compiler limit that's not necessarily part of the language spec.

Can you change your code generator to write all the data to a file and read the file in your Java program? Then your code could be very short:

while not eof
   read data for next entry
   parse & create objects
   put in map
end while

You could probably even open the spreadsheet as a database with JDBC/ODBC or one of the Java COM bridges like JACOB or a special office IO project like POI.

Any of those choices sound appealing?

[Ernest Friedman-Hill]

Originally posted by Stan James:
Yikes, I'd guess you've run into a system or compiler limit that's not necessarily part of the language spec.

It's not explicitly part of the language, but it's implicitly included because it's part of the VM spec. The size of a method's bytecode is kept in a UINT16, so 65535 bytes is the maximum. Not everyone realizes this, but when you write

int[] x = { 1, 2, 3 };

The compiler emits code that looks like

int[] x = new int[3];
x[0] = 1;
x[1] = 2;
x[2] = 3;

and each of those assignments can take quite a few bytes to encode, as the values have to be fetched from the constant pool and put on the stack, the array reference put on the stack, and then the assignment bytecode invoked.
[ October 04, 2005: Message edited by: Ernest Friedman-Hill ]

[sanjeev mehra]

Thanks to all of you for quick reply & suggestions.

Regards,
Sanjeev.