window closes when it shouldn't

[chris barr]

i am making a simple game program and during the create account it askes you for your account name and i type in my account name and when i hit enter for it to accept the name it just closes the window without reading the account name that i enter.

  class CreateAccount
{
String playname;
String directory = "/Plist/";
        String mainEnd = "_main.dat";
String itemEnd = "_item.dat";
String statsEnd = "_stats.dat";
String passEnd = "_pass.dat";
String accountname;
String userinput = "_user.dat";
String AccountName;
FileOutput accountfile;
int playlvl;
String userEnd;
FileInput currentuser;
public void createFiles(String accountName)
{

FileOutput playerMain = new FileOutput(directory + accountName + mainEnd);
FileOutput playerItems = new FileOutput(directory + accountName + itemEnd);
FileOutput playerStats = new FileOutput(directory + accountName + statsEnd);
FileOutput playerPass = new FileOutput(directory + accountName + passEnd);
}
public Boolean createAccount(String accountName)
{
       currentuser = new FileInput(directory + userinput + userEnd);
       accountfile = new FileOutput(directory + accountName);
       String useraccount = currentuser.readLine();
       System.out.println(useraccount);
       
       if (accountName == useraccount)
       {
       System.out.println("Account name already exists please choose another name.");
               return false;
       }
       else
       {
               accountfile.println(AccountName);
               return true;
       }
        }
        public Boolean createAccountPass(String accountName)
        {
               ConsoleIO console = new ConsoleIO();
               System.out.println("Enter Password");
       String Password = console.readLine();
       System.out.println("Confirm Password");
       String cPassword = console.readLine();
       accountfile.println(Password);
       return true;
        }
       
public void createCharacter(String playerName)
{
    int playlvl = 0;
    int playstr = 1;
    int playintel = 1;
    ConsoleIO console = new ConsoleIO();
    System.out.println("Enter Player name");
    playname =  console.readLine();
    System.out.println("Enter Password");
}
}
/* End Of accountCreate Class */  

[chris barr]

create charater and create files methods are not used at the moment and don'e give me any problems .. i had the program working before with them in...

[pascal betz]

hi


ok, im not clear about what you are trying to achieve and where you have troubles with your code (several pieces are missing: some classes like FileOutput and so on). but i have some tips for you:

- if your Fileinput/outpout classes have some try/catch, make sure you print the exception at least to the console (Exception.printStacktrace()). better would be to pass them on and react on them.
- don't compare Strings using '=='! use the equals() method. in short: '==' compares the reference while equals() compares the state
- when you write to streams (e.g.) a file then make sure you close them in a finally clause. i dont see you closing any stream but perhaps thats encapsulatet in the FileInput/output classes ?
- try to stick with java coding guidelines: the member "AccountName" should start lowercase.
- in your createAccount method you take have an "accountName" parameter but in the end you write the "AccountName" member/field to the file. if this is a null reference, and you "swallow" exceptions in your Fileoutput class, then this could be your problem: NullPointerException.
- your methods return Boolean (wrapper object) according to the signature but you return boolean (primitive). this is no problem because java 1.5 autoboxes/unboxes them.... but i was not sure if you understand the differences ?
- your createAccountPass method does always return "true"... therefore there is no sense in returning anything at all. just make the method "void"


have fun

pascal
[ May 08, 2006: Message edited by: pascal betz ]

[chris barr]

the program works up until it askes for the username .. i will input the user name and then the program with quit.

  public class RPG implements Runnable
{
public void run()
{
}
public static void main(String[] args)
{
    try
    {
    Thread t = new Thread();
    login l = new login();
    CreateAccount ac = new CreateAccount();
    RPG rpg = new RPG();
    ConsoleIO io = new ConsoleIO();
    UIStuff ui = new UIStuff();
    ui.startOutputConsole();
    System.out.print("(>^^)> ");
    t.sleep(200);
    System.out.print("R");
    t.sleep(200);
    System.out.print("P");
    t.sleep(200);
    System.out.print("G");
    t.sleep(200);
    System.out.print(" <(^^< :wink: ");
    t.sleep(200);
    System.out.println(" By Kyle Berry and Chris Barrett");
    t.sleep(200);
    System.out.println("The Menu");
    t.sleep(200);
    System.out.println("1. To Login");
    t.sleep(200);
    System.out.println("2. To Create an Account");
    t.sleep(200);
    System.out.println("3. To Quit");
    t.sleep(200);
    System.out.print("Enter Choice: ");
    int menuChoice =  io.readInt();
    if(menuChoice == 1)
    {
    System.out.println("Enter Accountname");
    ConsoleIO an = new ConsoleIO();
    String accountname = an.readLine();
    System.out.println("Enter Password");
    ConsoleIO console = new ConsoleIO();
    String Password = console.readLine();
    login getpass = new login();
    login getaccountname = new login();
    Boolean checkname = getaccountname.getaccountname(accountname);
    Boolean checkpass = getpass.getpass(Password);
    if (checkname.equals(true) && checkpass.equals(true))
    {
    System.out.println("login succefull");
    ui.createBattlePanel();
    t.sleep(200);
    ui.createAttackButton();
    t.sleep(200);
    ui.createFleeButton();
    t.sleep(200);
    ui.createSpellButtton();
    t.sleep(200);
    ui.createFleeButton();
    
    }
    
    }
    if(menuChoice == 2)
    {
    System.out.println("Enter your account name");
            ConsoleIO console = new ConsoleIO();
            String accountname = console.readLine();
            CreateAccount an = new CreateAccount();
            Boolean accountName = an.createAccount(accountname);
            if (accountName.equals(false))
            {
            System.out.println("Account already exist please choose another name.");
            }
            System.out.println("Enter your password");
           String Password = console.readLine();
            CreateAccount pw = new CreateAccount();
            Boolean password = pw.createAccountPass(Password);
            t.sleep(200);
            System.out.println("Your Account has been created.");
    }
    if(menuChoice == 3)
    {
      System.exit(0);
    }
    else
    {
    }
 }
    catch(InterruptedException e)
    {
    }
}
public void menu(int loginValid)
{
if(loginValid == 1)
{

}
}
public void physicalAttack(int attackPower)
{

}
public void magicAttack(int magicPower)
{

}

}
/* End Of Main Class File */  

the createaccount and createpassword class and methods are above.