File APIs for Java Developers
Manipulate DOC, XLS, PPT, PDF and many others from your application.
The moose likes Java in General and the fly likes Improving code Big Moose Saloon
  Search | Java FAQ | Recent Topics | Flagged Topics | Hot Topics | Zero Replies
Register / Login

Win a copy of Head First Android this week in the Android forum!
JavaRanch » Java Forums » Java » Java in General
Bookmark "Improving code" Watch "Improving code" New topic

Improving code

Tom Joiner
Ranch Hand

Joined: Sep 19, 2006
Posts: 47
Here is some code I am writing I am looking to improve. What it does is attempt to solve a puzzle of blocks, by orienting them in every possible permutation to see if they fit in.

Note that I am using enums for orientation, but not for the block position. Why? Because I am using the block position as an index into arraylists, and also walk through the positions in an incrementing manner (like an int). Is this a correct strategy, or should I use enums after all?

This particular routine counts the number of valid permutations which the blocks fit together correctly.

Am I cloning things properly? (I am trying to just do a shallow copy)

Thanks for any ideas on how to improve it.

Don't get me started about those stupid light bulbs.
subject: Improving code
It's not a secret anymore!