constructor

[mike hew]

I found I think my problem but not sure how to fix it, I was naming as shapes and not what was asked in the bold, could someone give me an example or where to go and look, the book I have is not a good teacher,

Thank you in advance.

 if  (myFields[c_shapeNameField].equals(ShapeName.circle)){
[B]//ASSIGN a new Circle object to shapes[index], passing the Circle constructor the following arguments:[/B]Shape[index] = new Circle(Integer.parseInt(myFields[c_xCoordinateField]),
Integer.parseInt(myFields[c_yCoordinateField]), Integer.parseInt(myFields[c_radiusField])); 
}
   else if  (myFields[c_shapeNameField].equals(ShapeName.cube)){
   [B]//ASSIGN a new Cube object to shapes[index], passing the Cube constructor the following arguments:[/B]
Cube shape = new Cube(Integer.parseInt(myFields[c_xCoordinateField]),
Integer.parseInt(myFields[c_yCoordinateField]), Integer.parseInt(myFields[c_sideField]));
   }
   else if  (myFields[c_shapeNameField].equals(ShapeName.sphere)){
   [B]//ASSIGN a new Sphere object to shapes[index], passing the Sphere constructor the following arguments:[/B]Sphere shape = new Sphere(Integer.parseInt(myFields[c_xCoordinateField]),
Integer.parseInt(myFields[c_yCoordinateField]), Integer.parseInt(myFields[c_radiusField]));
   }
   else if  (myFields[c_shapeNameField].equals(ShapeName.square)){
   [B]//ASSIGN a new Square object to shapes[index], passing the Square constructor the following arguments:[/B]Square shape = new Square(Integer.parseInt(myFields[c_xCoordinateField]),
Integer.parseInt(myFields[c_yCoordinateField]), Integer.parseInt(myFields[c_sideField]));
      } 

[Ernest Friedman-Hill]

Mike --

PLEASE stop starting new threads for this same exercise! Except for people that have talked to you already, nobody understands where you're coming from. If you left this all in one thread, then people would be able to see the context.

Now, anyway: the problem as I understood it was that Circle, Sphere, etc, need to extend Shape (if Shape is a class) or implement Shape (if Shape is an interface.) In other words:

public class Circle extends Shape { ...

[mike hew]

no, circle extends twodimensionshape, which extends to shape under the program

[mike hew]

As you can see, Circle DOESNOT extend to shape, and isnot suppose too!

//public class name
public class Circle extends  TwoDimensionalShape
{

 
//Using keyword super, call the superclass constructor
public Circle(int xCoordinate, int yCoordinate, int radius)
{
super(xCoordinate, yCoordinate, radius, radius);
} 
 
//RETURN ShapeName.circle
public String getName()
{
return ShapeName.circle;
}
 
//RETURN (double) (Math.PI * getRadius() * getRadius())
public double getArea()
{
return (double) (Math.PI * getRadius() * getRadius());
}
 
//CALL method setDimension2, passing it one argument: radius
public void setRadius(int radius)
{
setDimension1(radius);
setDimension2(radius);
}
 
//RETURN getDimension1()
public int getRadius()
{
return getDimension1();
}
 
//RETURN a formatted string (String.format)
 
public String toString()
{
return String.format("%s? %s:?%d\n", super.toString() + "radius", getRadius());
}
 
}//end circle class/[code]
 
[code]
 
//class file name
public class Cube extends  ThreeDimensionalShape
{
 

//Using keyword super, call the superclass constructor
public Cube(int xCoordinate, int yCoordinate, int side)
{
super(xCoordinate, yCoordinate, side, side, side);
}
 
//RETURN ShapeName.cube
public  String getName()
{
return ShapeName.cube;
}
 

//RETURN (double) (6 * getSide() * getSide())
public double getArea()
{
return (double) (6 * getSide() * getSide());
}
 
//RETURN (double) (getSide() * getSide() * getSide() )
public double getVolume()
{
return (double) (getSide() * getSide() * getSide());
}
 
//CALL method setDimension1, passing it one argument: side
//CALL method setDimension2, passing it one argument: side
//CALL method setDimension3, passing it one argument: side
public void setSide(int side)
{
setDimension1(side);
setDimension2(side);
setDimension3(side);
}
 
//RETURN getDimension1()
public int getSide()
{
return getDimension1();
}
 
//RETURN a formatted string (String.format)
public String toString()
{
return String.format("%s?%s:?%d\n", super.toString() + "side", getSide());
}  
 
}//end class cube

//class file name
public class Shape
{
 
private int xCoordinate;
private int yCoordinate;
 

 
//CALL method setXCoordinate, passing it one argument: xCoordinate
//CALL method setYCoordinate, passing it one argument: yCoordinate
public Shape(int xCoordinate, int yCoordinate)
{
setXCoordinate(xCoordinate);
setYCoordinate(yCoordinate);
}
 
//ASSIGN xCoordinate TO this.xCoordinate
public void setXCoordinate(int xCoordinate)
{
this.xCoordinate = xCoordinate;
}
 
//ASSIGN yCoordinate TO this.yCoordinate
public void setYCoordinate(int yCoordinate)
{
this.yCoordinate = yCoordinate;
}
 
//RETURN xCoordinate
public int getXCoordinate()
{
return xCoordinate;
}
 
//RETURN yCoordinate
public int getYCoordinate()
{
return yCoordinate;
}
 
//RETURN a formatted string (String.format)
public String toString()
{
return String.format("(%d,? %d)",getXCoordinate(), getYCoordinate());
}

}//end class shape

//class file name
public class ShapeName
{
 
public final static String circle = "Circle";// this field is final static
public final static String cube = "Cube";// this field is final static
public final static String sphere = "Sphere";// this field is final static
public final static String square = "Square";// this field is final static
 
}//end shapename class
 
//class file name
public class Sphere extends  ThreeDimensionalShape
{
 

//Using keyword super, call the superclass constructor
public Sphere(int xCoordinate, int yCoordinate, int radius)
{
super(xCoordinate, yCoordinate, radius, radius, radius);
}
 
//RETURN ShapeName.sphere
public String getName()
{
return ShapeName.sphere;
}
 
//RETURN (double) ( 4 * Math.PI * getRadius() * getRadius() )
public double getArea()
{
return (double) ( 4 * Math.PI * getRadius() * getRadius());
}
 
//RETURN (double) ( 4.0 / 3.0 * Math.PI * getRadius() * getRadius() * getRadius() )
public double getVolume()
{
return (double) ( 4.0 / 3.0 * Math.PI * getRadius() * getRadius() * getRadius());
}
 
//CALL method setDimension1, passing it one argument: radius
//CALL method setDimension2, passing it one argument: radius
//CALL method setDimension3, passing it one argument: radius
public void setRadius(int radius)
{
setDimension1(radius);
setDimension2(radius);
setDimension3(radius);
}
 
//RETURN getDimension1()
public int getRadius()
{
return getDimension1();
}
 
//RETURN a formatted string (String.format)
public String toString()
{
return String.format("%s?%s:?%d\n", super.toString() + "radius", getRadius());
}
 
}//end Sphere class

//class file name
public class Square extends  TwoDimensionalShape
{
 

//Using keyword super, call the superclass constructor 
public Square(int xCoordinate, int yCoordinate, int side)
{
super(xCoordinate, yCoordinate, side, side);
} 
 
//RETURN ShapeName.square
public String getName()
{
return ShapeName.square;
}

//RETURN (double) (getSide() * getSide())
public double getArea()
{
return (double) (getSide() * getSide());
}

//CALL method setDimension1, passing it one argument: side
//CALL method setDimension2, passing it one argument: side
public void setSide(int side)
{
setDimension1(side);
setDimension2(side);
}

//RETURN getDimension1()
public int getSide()
{
return getDimension1();
}

//RETURN a formatted string (String.format)
public String toString()
{
return String.format("%s? %s:?%d\n", super.toString() + "side", getSide());
}
 
}//end Square class

 
//class file name
public abstract class TwoDimensionalShape extends Shape
{
 
private int dimension1;
private int dimension2;
 

//Using keyword super, call the superclass constructor 
//CALL method setDimension1, passing it one argument: dimension1, an int
//CALL method setDimension2, passing it one argument: dimension2, an int
public TwoDimensionalShape(int xCoordinate, int yCoordinate, int dimension1, int dimension2)
{
super(xCoordinate, yCoordinate);
setDimension1(dimension1);
setDimension2(dimension2);
}

//ASSIGN dimension1 TO this.dimension1
public void setDimension1(int dimension1)
{
this.dimension1 = dimension1;
}

//ASSIGN dimension2 TO this.dimension2
public void setDimension2(int dimension2)
{
this.dimension2 = dimension2;
}

//RETURN dimension1
public int getDimension1()
{
return dimension1;
}

//RETURN dimension2
public int getDimension2()
{
return dimension2;
}
 
//This public abstract method has a double return value, and has no parameters.
public double getArea;
 


 
}//end TwoDimensionalShape class

 

//class file name
public class ThreeDimensionalShape extends  Shape
{
 
private int dimension1;
private int dimension2;
private int dimension3;
 
 
//Using keyword super, call the superclass constructor, passing it the following two arguments: xCoordinate, an int and yCoordinate, an int
//CALL method setDimension1, passing it one argument: dimension1, an int
//CALL method setDimension2, passing it one argument: dimension2, an int
//CALL method setDimension3, passing it one argument: dimension3, an int
public ThreeDimensionalShape(int xCoordinate, int yCoordinate, int dimension1, int dimension2,int dimension3)
{
super(dimension3, dimension3);
setDimension1(dimension1);
setDimension2(dimension2);
setDimension3(dimension3);
}

//ASSIGN dimension1 TO this.dimension1
public void setDimension1(int dimension1)
{
this.dimension1 = dimension1;
}

//ASSIGN dimension2 TO this.dimension2
public void setDimension2(int dimension2)
{
this.dimension2 = dimension2;
}

//ASSIGN dimension3 TO this.dimension3
public void setDimension3(int dimension3)
{
this.dimension3 = dimension3;
}

//RETURN dimension1
public int getDimension1()
{
return dimension1;
}

//RETURN dimension2
public int getDimension2()
{
return dimension2;
}

//RETURN dimension3
public int getDimension3()
{
return dimension3;
}
 
//This public abstract method has a double return value, and has no parameters.
public double getArea;
 
//This public abstract method has a double return value, and has no parameters. 
public double getVolume;
 
}//end ThreeDimensionalShape class

import java.awt.Shape;
//class file name
public class ShapeTest
{
private static Shape shapes[];
 
public static void main(String args[])
{
//DEFINE a local variable named recordNumber of type int and initialize its value to zero
int recordNumber = 0;
 
//CALL method loadShapesArray
loadShapesArray();

//DISPLAY 1st column headings line: "Record  Shape
System.out.printf("Record  Shape\n");
//DISPLAY 2nd column heading line
System.out.printf("Number  Name\t Dimensions  Coordinates  Radius  Side\t   Area\t   Volume\n");
 
for(Shape currentShape : shapes)
{
String thisShapeDimensions = (" ");
String thisRadius = String.format("%6s", "   -- ");
String thisSide = (" -- ");
String thisArea = (" -- ");
String thisVolume = ("    --  ");
String thisCoordinates = (" ");
 
if(currentShape instanceof TwoDimensionalShape)
{
thisShapeDimensions = String.format("  %-6s", "Two");
TwoDimensionalShape thisTwoDimensionalShape = (TwoDimensionalShape) currentShape;
thisArea = String.format("%,9.2f", ((Square) thisTwoDimensionalShape).getArea());
thisCoordinates = String.format("  (%2d,%2d) ", thisTwoDimensionalShape.getXCoordinate(), 
thisTwoDimensionalShape.getYCoordinate());
}
if(currentShape instanceof Square)
{
Square thisSquare = (Square) currentShape;
thisSide = String.format("%4d", thisSquare.getSide());
} // end if
else if(currentShape instanceof ThreeDimensionalShape)
{
thisShapeDimensions = String.format("  %-6s", "Three");
ThreeDimensionalShape thisThreeDimensionalShape = (ThreeDimensionalShape) currentShape;
thisArea = String.format("%,9.2f", ((Cube) thisThreeDimensionalShape).getArea());
thisVolume = String.format("%,9.2f", ((Cube) thisThreeDimensionalShape).getVolume());
thisCoordinates = String.format("  (%2d,%2d) ", thisThreeDimensionalShape.getXCoordinate(), 
thisThreeDimensionalShape.getYCoordinate());
if(currentShape instanceof Cube)
{
Cube thisCube = (Cube) currentShape;
thisSide = String.format("%4d", thisCube.getSide());
} // end if
} // end if

if(currentShape instanceof Circle)
{
Circle thisShape = (Circle) currentShape;
thisRadius = String.format("%6d", thisShape.getRadius());
} // end if
if(currentShape instanceof Sphere)
{
Sphere thisShape = (Sphere) currentShape;
thisRadius = String.format("%6d", thisShape.getRadius());
} // end if
 
recordNumber++;
 
if(currentShape instanceof Shape){
 
System.out.printf("\n%6s  %-6s    %-10s  %-11s  %6s  %-4s  %-9s  %-9s\n", String.format("  %d  ", recordNumber),
((Square) currentShape).getName(), thisShapeDimensions, thisCoordinates, thisRadius, thisSide, thisArea, thisVolume);

} // end if

} // end for

System.out.println("\nEnd of program");
 
} // end main method
 
//This private static method has no return value, and has no parameters.
private static void loadShapesArray()
{

 
    //INSTANTIATE a local variable named myFile of class MyCsvFile
MyCsvFile myFile = new MyCsvFile("shape_v01.txt");
 
//define local variables
int index = 0;
String [] myFields;
//CREATE the instance variable shapes, an array of Shape objects, with myFile.getCountOfRecords() elements
  Object Shapes =  myFile.getCountOfRecords();
 
final int c_shapeNameField = 0;
final int c_xCoordinateField = 1;
final int c_yCoordinateField = 2;
final int c_radiusField = 3;
final int c_sideField = 3;
 
//Get 1st record from CSV file
myFile.readARecord();
 
while (myFile.getEofFound() == false)
{
  myFields = myFile.getCsvRecordFieldArray();
 
if  (myFields[c_shapeNameField].equals(ShapeName.circle)){
Circle shape = new Circle(Integer.parseInt(myFields[c_xCoordinateField]),
Integer.parseInt(myFields[c_yCoordinateField]), Integer.parseInt(myFields[c_radiusField])); 
}
   else if  (myFields[c_shapeNameField].equals(ShapeName.cube)){
Cube shape = new Cube(Integer.parseInt(myFields[c_xCoordinateField]),
Integer.parseInt(myFields[c_yCoordinateField]), Integer.parseInt(myFields[c_sideField]));
   }
   else if  (myFields[c_shapeNameField].equals(ShapeName.sphere)){
Sphere shape = new Sphere(Integer.parseInt(myFields[c_xCoordinateField]),
Integer.parseInt(myFields[c_yCoordinateField]), Integer.parseInt(myFields[c_radiusField]));
   }
   else if  (myFields[c_shapeNameField].equals(ShapeName.square)){
Square shape = new Square(Integer.parseInt(myFields[c_xCoordinateField]),
Integer.parseInt(myFields[c_yCoordinateField]), Integer.parseInt(myFields[c_sideField]));
      }
   else
  {
//DISPLAY an error message which shows the value of the unknown shape name and its record number. 
System.out.printf("Found unexpected record type of ","Unknown Shape"," at record 5");

}//end if
 
//INCREMENT index
index++;
 
//Get next record, if any
myFile.readARecord();
 
}//end while
 
}//end loadShapesArray
 
} // end class ShapeTest

[Joanne Neal]

If Circle extends TwoDimensionalShape and TwoDimensionalShape extends Shape, then Circle also extends Shape
i.e.

Shape shape = new Circle();

is perfectly legal.
Without digging out your original post, I'm not sure if that is what your problem is, but maybe it will help.