Need Suggestion

[Harathi Rao]

Hi

I have a typical situation where i have setter and getter methods like this
Item item = new Item();
item.setValue1()
Item.getValue1()
.
.
.
.
item.setValue6()
item.getValue6()

And I got a List data = {"hello","good","morning"};

I need to set these values and get them using above setter and getters..
item.setValue1(data.get(0));
item.setValue2(data.get(1));

Now, is there a simple way to do this... by using for loop or any such logic...


Thanks in anticipation!

[Rob Spoor]

If those are really your method names, why not make them indexed?

So instead of the 6 setValue methods and 6 getValue methods, have one of each:

public void setValue(int index, Object value)
{
    switch (index)
    {
        case 1:
            // set value 1
            break;
        case 2:
            // set value 2
            break;
        case 3:
            // set value 3
            break;
        case 4:
            // set value 4
            break;
        case 5:
            // set value 5
            break;
        case 6:
            // set value 6
            break;
        default:
            throw new IndexOutOfBoundsException(index);
    }
}
 
public Object getValue(int index)
{
    switch (index)
    {
        case 1:
            // return value 1;
        case 2:
            // return value 2;
        case 3:
            // return value 3;
        case 4:
            // return value 4;
        case 5:
            // return value 5;
        case 6:
            // return value 6;
        default:
            throw new IndexOutOfBoundsException(index);
    }
}

Of course, if you store your values in an array as well, you can just use the array index; it will throw an IndexOutOfBoundsException of its own.
Do remember though that in Java, arrays are 0 based. So you might want to use "array[index - 1]" to keep your methods 1 based.

[Srikanth Basa]

You can plan to use Java reflections, if you are allowed to.