generics compiler warning

[Dan Murphy]

Hi,

   private static List<Object> storeInList(Object object) {
        
        List<Object> returnList = new ArrayList<Object>();
        
        if (object instanceof List) {
            returnList.addAll(( List<Object> )object);  // WARNING
            
        } else {
            returnList.add(object);
        }
        return returnList;
    }

The line marked WARNING generates the following compiler warning:
"Type safety: The cast from Object to List<Object> is actually checking against the erased type List"

I've tried changing ( List<Object> ) to just (List), but then I get the warning:
"Type safety: The expression of type List needs unchecked conversion to conform to Collection<? extends Object>"

How can I write this method without generating any compiler warnings?

Cheers,
DM

[ September 13, 2007: Message edited by: Dan Murphy ]
[ September 13, 2007: Message edited by: Dan Murphy ]

[Jim Yingst]

Try:

returnList.addAll((List<?>) object);

[Dan Murphy]

perfect, thanks!