a question in binary tree and factorisation

[alex lotel]

we have a class that some has in soeof him the folwing
getfirst()
getsecond()
splip()

i was told that the "split" method splits the number which
it was given into two numbers which by multpilication gives us the original number
for example if 8 the given number
then we get 4 as the first
and 2 as the second one
if we get a number 5
then the first will be 5
and the second one is 1

i was told to build a method which stores all the primal numbers of
a given number
i cant wright it on eclipse because its a theoretical question
which only says that there is such a method called "split"
and we can use it.

can you tell me if my logic ok??

public static void store(int num,BNode root)
{
root.info=num;
split(num)
int first;
int second;
first=getfirst();
second=getsecond();
 
if (second==1){
 root.left=new BNode(second);
root.right=new BNode(first);
}
else
{
store(first,root.right);
store(second,root.left);
}

[ February 20, 2008: Message edited by: donaldth smithts ]

[Campbell Ritchie]

Your title is confusing; it is neither about binary trees nor about gcd.

The algorithm for gcd is simple; it is called Euclid's algorithm because Euclid discovered it, and is the oldest named algorithm known. What you want appears to be factorisation. There is an example here.

[alex lotel]

can you tell me wether i did it ok??

there is no way for me to know that
exept you correcting me were i got wrong

[Campbell Ritchie]

Have you tried it? Have you run it? Where did it go wrong?

As people have already told you (I think it was Joanne Neal), you will not find out whether a program works without running it.
Show Some Effort Please run it and then try to work out what goes wrong.

[alex lotel]

this is a question from a test
i am theoreticly given a working method

i cant test it in eclipse

i have written a program by my logic
this is the only tool i've got

can you tell me if my method is ok??

[Joanne Neal]

Write a dummy version of the class that has the getfirst(), getsecond() and split() methods that you can use to test your code.
You could either hard code the values that the getfirst() and getsecond() methods return or you could pass them to the constructor. The split() method wouldn't actually have to do anything.