files are not beened deleted and renamed

[damodar kumar]

public class renameFiles {
    /**
     * DOCUMENT ME!
     */
    public void Fliesrenamed() {
        String Path = "C:\\sefl\\pdf";
        String newname = "";
        String newfilepath = "";
        File f = new File(Path);
 
        try {
            if (f.exists()) {
                System.out.println("File exsists");
 
                String[] fileslist = f.list();
                System.out.println(fileslist.length);
 
                for (int i = 0; i < fileslist.length; i++) {
                    System.out.println(fileslist[i]);
 
                    if ((null != fileslist) &&
                            (fileslist[i].substring(fileslist[i].length() - 4,
                                fileslist[i].length())).equals(".pdf") &&
                            !((fileslist[i].substring(fileslist[i].length() -
                                6, fileslist[i].length())).equals("_1.pdf"))) {
                        newname = fileslist[i].substring(0,
                                fileslist[i].length() - 4) + "_1.pdf";
                        System.out.println(newname + "in if loop");
                    }
 
                    String oldpath = Path + "\\" + fileslist[i];
                    String newpath = Path + "\\" + newname;
 
                    //System.out.println(oldpath + ":::   :-o	   ld path:::" + newpath +
                    //":::new path:::");
                    File f1 = new File(oldpath);
                    File f2 = new File(newpath);
 
                    InputStream in = new FileInputStream(f1);
                    OutputStream out = new FileOutputStream(f2);
 
                                        byte[] buf = new byte[1024];
                                        int len;
                    
                                        while ((len = in.read(buf)) > 0) {
                                            out.write(buf, 0, len);
                                        }
                                        
                    in.close();
                    out.close();
 
                    File f3 = new File(oldpath);
                    File f4 = new File(newpath);
                    String oldname = f3.getName();
                    System.out.println(f3.getName() + "::file exists::");
 
                    File f5 = new File(oldname);
 
                    if (f3.exists()) {
                        System.out.println(f3.exists() + "::file3 exists::");
 
                        f3.deleteOnExit();
 
                        //System.out.println(f3.delete() + "::   :mrgreen:   eleted:::");
                    }
 
                    if (f4.exists()) {
                        System.out.println(f4.exists() + "::file4 exists::");
 
                        String name = Path + "\\" +oldname;
 
                        File f6 = new File(name);
                        f4.renameTo(f6);
                        System.out.println(":::renamed:::");
                    }
                }
            }
        } catch (Exception e) {
            e.printStackTrace();
        }
    }
 
        /**
         * DOCUMENT ME!
        *
        * @param args DOCUMENT ME!
        */
       public static void main(String[] args) {
           renameFiles ef = new renameFiles ();
            ef.Fliesrenamed();
       }
}
 

mine aim is path contains a.txt it have to renamed to a_1.txt and have to delete the a.txt and a_1.txt have to rename to a.txt bt happening is

1) if that path contains a.txt

2) it is named to a_1.txt

3) its not deleting the a.txt and a_1.txt is not renamed to a.txt.

please suggest me by checking the above code.

Thanks

Damodar

[ June 16, 2008: Message edited by: damodar kumar ]
[ June 16, 2008: Message edited by: damodar kumar ]

[Joanne Neal]

Can you edit your post (click on the paper and pencil icon) and put your code into code tags. This will make it much easier to read.
It's difficult to read your code but the only code i could see that you might be using to delete a file is a call to deleteOnExit. This will not delete the file until you exit the JVM (i.e. your program finishes). Try using the delete method instead and see if that fixes your problem.

[Ravikanth kolli]

I dont think deleteOnExit works since the file is deleted only during the virtual machine termination.

More information can be found here

you can try something like delete.

file is not renamed because a file with the same name already exists.
[ June 16, 2008: Message edited by: Ravikanth kolli ]

[Jim Yingst]

Apparently, this is continued from here. Damodar, in general it's better to continue a topic in the same thread you started in, if you're really just continuing the exact same discussion. That way people have access to all the earlier info and don't waste time saying things that have already been said before. Thanks.

[damodar kumar]

hi Jim Yingst

may be this come under same thread, but i got some different answer, which i not got with previous thread. there was no time wasting as i not mentioned, that please refer previous thread for more information , i mentined every thing clearly in the present thread.Also the code what i metioned before is different with the previous thread.

[Yashpal Rawat]

Hey, I have some suggestions/queries

1. Is this a standalone program? If yes then deleteOnExit should work since
your jvm will exit once you are done with your program.
2. If you intend to only renmae the file then why you are not using only
renameTo method in File Class.
3. I think variable newname should be reset in each iteration
4. Also its not clear what is to be done in case directory have all files
already renamed.

I have modified your code below with assumption that if both old and new file you wanted to create already exists then new file will be over-written.

    
import java.io.*;
import java.util.*;
 
public class renameFiles_1 {
    /**
     * DOCUMENT ME!
     */
    public void Fliesrenamed() {
        String Path = "D:\\self\\pdf";
        String newname = null;
        String newfilepath = "";
 
        File f = new File(Path);
        try {
            if (f.exists()) {
                 System.out.println("DEBUG -> Path Exists");
 
                String[] fileslist = f.list();
                System.out.println(fileslist.length);
 
                for (int i = 0; i < fileslist.length; i++) {
                    newname = "";
                    System.out.println("DEBUG -> File Name: " + fileslist[i]);
 
                    if ((fileslist[i].substring(fileslist[i].length() - 4,
                                fileslist[i].length())).equals(".pdf") &&
                            !((fileslist[i].substring(fileslist[i].length() -
                                6, fileslist[i].length())).equals("_1.pdf"))
                                )  {
                        newname = fileslist[i].substring(0,fileslist[i].length() - 4) + "_1.pdf";
                        System.out.println(newname + "in if loop");
 
String oldpath = Path + "\\" + fileslist[i];
String newpath = Path + "\\" + newname;
 
//System.out.println(oldpath + ":::      ld path:::" + newpath +
//":::new path:::");
File f1 = new File(oldpath);
File f2 = new File(newpath);
 
//If File with new name exists then try to delete that file
boolean isDeleted = false;
if(f2.exists()) {
isDeleted = f2.delete();
}
 
//If unable to delete then copy content of old file to new file
if(!isDeleted) {
System.out.println("DEBUG -> Trying to Copy Content");
BufferedReader br = new BufferedReader(new InputStreamReader(new FileInputStream(oldpath)));
FileOutputStream out = new FileOutputStream(newpath);
String temp;
 
while((temp = br.readLine()) != null) {
out.write(temp.getBytes());
}
out.close();
br.close();
//Deleting original file
f1.delete();
}
else {
System.out.println("DEBUG -> Renaming Original File");
f1.renameTo(f2);
}
                }
            }
}
} catch (Exception e) {
e.printStackTrace();
}
    }
 
        /**
         * DOCUMENT ME!
        *
        * @param args DOCUMENT ME!
        */
       public static void main(String[] args) {
           renameFiles_1 ef = new renameFiles_1 ();
           ef.Fliesrenamed();
       }
}

[Paul Sturrock]

Yashu23

Please check your private messages. Thanks.

[Vilmantas Baranauskas]

Some suggestions to improve/simplify your code:

Use fileslist[i].endsWith(".pdf") instead of

(fileslist[i].substring(fileslist[i].length() - 4,
                                fileslist[i].length())).equals(".pdf")

Use

    
File f1 = new File(f, fileslist[i]);
File f2 = new File(f, newname);

instead of

    
String oldpath = Path + "\\" + fileslist[i];
String newpath = Path + "\\" + newname;
 
File f1 = new File(oldpath);
File f2 = new File(newpath);