Rock,Paper Scissors

[David Record]

I'm having a problem with this code. The counters in the "if" statements are not working. Can anyone help me? I've included both files here.

<font size=+0>
/*********************************************************
 * @author  David Record
 * @version 1.0
 * Assignment: Homework #1
 * Filename: Game.java
 */
public class Game {
  public static void main(String args[]){
    // Create Two Player Objects That Will Play Each Other
    Player p1 = new Player();
    Player p2 = new Player();
    boolean gameWon = false;     // Loop control to let play continue until a player wins
    int roundsPlayed = 0;        // Number of rounds played
    int p1Wins = p1.wins;
    int p2Wins = p2.wins;
    int draw = 0;
    String p1Choice;
    String p2Choice;
    // Game Loop
    do
    {
           System.out.println("******************** Round: "+roundsPlayed+" *********************\n");
           System.out.println("Number of Draws: "+draw+"\n");
           p1Choice = p1.playerChoice();
           System.out.println("Player 1: "+p1Choice+ "\t Player 1 Total Wins: "+p1Wins);
           p2Choice = p2.playerChoice();
           System.out.println("Player 2: "+p2Choice+ "\t Player 2 Total Wins: "+p2Wins);

              if((p1Choice.equals("rock"))&&(p2Choice.equals("paper")))
                   {
                   System.out.println("Player 2 Wins");
                   p2Wins++;         // trying a couple different ways to get count to work
                   }
              else if((p1Choice.equals("paper"))&&(p2Choice.equals("rock")))
                   {
                   p1Wins++;
                   System.out.println("Player 1 Wins");
                   }
              else if((p1Choice.equals("rock"))&&(p2Choice.equals("scissors")))
                   {
                   p1Wins = p1.setWins();
                   System.out.println("Player 1 Wins");
                   }
              else if((p1Choice.equals("scissors"))&&(p2Choice.equals("rock")))
                   {
                   p2Wins = p2.setWins();
                   System.out.println("Player 2 Wins");
                   }
              else if((p1Choice.equals("scissors"))&&(p2Choice.equals("paper")))
                   {
                   p1Wins = p1.setWins();
                   System.out.println("Player 1 Wins");
                   }
              else if((p1Choice.equals("paper"))&&(p2Choice.equals("scissors")))
                   {
                   p2Wins = p2.setWins();
                   System.out.println("Player 2 Wins");
                   }
              if(p1Choice==p2Choice)
              {
              draw++;
              System.out.println("\n\t\t\t Draw \n");
              }
           roundsPlayed++;
           if((p1.getWins()>=3)| |(p2.getWins()>=3)){
                   gameWon = true;
                   System.out.println("GAME WON");
           }
           System.out.println();
    }while(gameWon != true);
  }
}
// End of Game.java
************************************************************
/**
 * @author  David Record
 * @version 1.0
 */
public class Player{
  int wins;      // data member that will keep track of # of wins
  int winTotal;
  // method that returns random choic of rock, paper, or scissors
  public String playerChoice(){
       String choice = "";
       int c = (int)(Math.random()*3);
       switch(c) {
       case 0:
           choice = ("Rock");
           break;
       case 1:
           choice = ("Paper");
           break;
       case 2:
           choice = ("Scissors");
           break;
       }
       return choice;
  }
  // method that sets the players wins
  public int setWins(){
    int winTotal = wins++;
    return winTotal;
    }
  // method that gets the players win total
  public int getWins(){
    return(wins);
    }
}
// End of Player.java

[This message has been edited by Cindy Glass (edited June 14, 2001).]

[Richard Boren]

In your
else if((p1Choice.equals("paper"))&&(p2Choice.equals("rock")))
you are checking for "paper", "rock", and "scissors"
but, you have defined your choices as
choice = ("Rock");
with the first letter capitalized "Rock", "Paper" and Scissors".
So paper does not equal Paper...; therefore, you never fall into you if statements meaning the counters are never incremented.
Also for your draw check you are using
if(p1Choice == (p2Choice))
but you should be using
if(p1Choice.equals(p2Choice))
since it is the actual string you want to check not the String reference.
Hope this gets you going again

[David Record]

hey thanks a lot,
that fixed my problem
Dave

[Junilu Lacar]

David,
There are quite a number of things that you could do to make this a better and cleaner program. And although it may work, it simply is not object-oriented. If you're interested, I could show you how to clean it up but I think it would be better to start a new thread in the Refactoring forum.
Thanks,
Junilu
[This message has been edited by JUNILU LACAR (edited June 14, 2001).]

[Junilu Lacar]

David, in case you are interested, I started a thread in the Refactoring forum to show how this program can be improved: http://www.javaranch.com/ubb/Forum9/HTML/000442.html