File APIs for Java Developers
Manipulate DOC, XLS, PPT, PDF and many others from your application.
http://aspose.com/file-tools
The moose likes Beginning Java and the fly likes from a 2d array to a regular array.... Big Moose Saloon
  Search | Java FAQ | Recent Topics | Flagged Topics | Hot Topics | Zero Replies
Register / Login
JavaRanch » Java Forums » Java » Beginning Java
Bookmark "from a 2d array to a regular array...." Watch "from a 2d array to a regular array...." New topic
Author

from a 2d array to a regular array....

Brandi Love
Ranch Hand

Joined: Sep 19, 2003
Posts: 133
I wrote this program to take the individual values from a 4 by 5 array and put them into a single dimensional array, but all I get when I run the program is a bunch of 3s. Can anyone tell me what is wrong with my code?
Ernest Friedman-Hill
author and iconoclast
Marshal

Joined: Jul 08, 2003
Posts: 24187
    
  34

Your i loop iterates over each element of the 1d array. The j and k loops visit every element of the 2d array in turn and assign it into the i'th element of the 1d array. The very last assignment is to assign the last 2d element (3) to the i'th element of the 1d array, so every element ends up being 3 -- plus you've done 20 times more assignments than are necessary!
To fix: remove the loop over i altogether. Inside the k loop, compute the value of i (i.e., the index into the 1d array) as a function of j and k. The right equation is
i = j * array[0].length + k


[Jess in Action][AskingGoodQuestions]
Joel McNary
Bartender

Joined: Aug 20, 2001
Posts: 1824

The problem is that you're looping on i. What you're told the computer to do is:
For each 1 from 1 to 20, place each element of array[j][k] into sort[i].
Therefore, each time through the outermost loop, you place each value in sort[i]. The final element is a 3, so that is what gets left there.
Consider not using an outer foor loop and instead assigning i = 0 to start. Then, after you populate sort[i], increment i by one.


Piscis Babelis est parvus, flavus, et hiridicus, et est probabiliter insolitissima raritas in toto mundo.
Brandi Love
Ranch Hand

Joined: Sep 19, 2003
Posts: 133
I've got it Thank ya gents.
 
I agree. Here's the link: http://aspose.com/file-tools
 
subject: from a 2d array to a regular array....