Currency Problem + General Advice

[Emile Ghazzawi]

Hi again all,
I was just wondering how to insert the Pound Sterling Symbol "�" into a Java program running in the command prompt.
I was also wondering if one of you could maybe check the code below and make sure it is ok and maybe give me some pointers to tidy it up if there are any. Thanks in advance guys, your all a really great help!

 import java.io.*;
import java.text.DecimalFormat;
public class StockControl
{
private static final int maxItems = 20;
private static String[] stockCode = new String[maxItems];
private static String[] stockDesc = new String[maxItems];
private static int[] currentLevel = new int[maxItems];
private static int[] reorderLevel = new int[maxItems];
private static float[] price = new float[maxItems];
private static int numItems = 0;
public static void main(String[] args)
throws IOException
{
String stringOption;
char charOption;
int numOrders = 0;
float totalValue = 0;
BufferedReader input = new BufferedReader(new InputStreamReader(System.in));
readData();
displayData();
try{
do
{
displayMenu();
stringOption = input.readLine();
charOption = stringOption.charAt(0);
switch (charOption)
{
case '1': extendStock();
  break;
case '2':acceptStock();
break;
case '3':totalValue = processOrder(totalValue);
numOrders++;
break;
case '4':displayReorderList();
break;
case '5':displayItem();
break;
case '6':break;
default:System.out.println("\n\t** ERROR - Invalid Selection - Please Try Again **\n");
break;
}
}while (charOption != '6');
}catch (StringIndexOutOfBoundsException e) {
System.out.println("\n\t** ERROR - No Option Entered - Exiting Program! **\n");
}
displayStatistics(numOrders, totalValue);
}
public static void extendStock()
throws IOException
{
if (numItems == maxItems) {
System.out.println("\n\t** ERROR - Maximum Stock Level Reached **\n");
return;
}
String stringOption, textCurrent, textReorder, textPrice;
char charOption = ' ';
BufferedReader input = new BufferedReader(new InputStreamReader(System.in));
try{
System.out.println("\n\nPlease Enter Stock Code:");
stockCode[numItems] = input.readLine();
System.out.println("\n\nPlease Enter Stock Description:");
stockDesc[numItems] = input.readLine();

System.out.println("\n\nPlease Enter Current Level:");
textCurrent = input.readLine();
currentLevel[numItems] = Integer.parseInt(textCurrent);

System.out.println("\n\nPlease Enter Reorder Level:");
textReorder = input.readLine();
reorderLevel[numItems] = Integer.parseInt(textReorder);
System.out.println("\n\nPlease Enter Price:");
textPrice = input.readLine();
price[numItems] = Float.parseFloat(textPrice);
}catch (NumberFormatException e)
{
System.out.println("\n\t** ERROR - Invalid Number Entered! **\n");
return;
}
numItems++;
if (numItems < maxItems) {
System.out.println("\nWould You Like To Enter Another Item? - Y/N");
stringOption = input.readLine();
charOption = stringOption.charAt(0);
if ((charOption == 'Y') || (charOption == 'y')) {
extendStock();
}
}
}
public static void acceptStock()
throws IOException
{
int stockAmount = 0;
String textAmount;
int location = findItem();
BufferedReader input = new BufferedReader(new InputStreamReader(System.in));
do{
System.out.println("\nPlease Enter The Ammount Of New Stock: ");
textAmount = input.readLine();
try{
stockAmount = Integer.parseInt(textAmount);
}catch(NumberFormatException e){System.out.println("\n\t** ERROR - Non Numerical Value Entered! **\n");}
if(stockAmount < 0){
System.out.println("\n\t** ERROR - Please Enter A Valid Stock Amount **\n");
}
}while(stockAmount < 0);
currentLevel[location] = currentLevel[location] + stockAmount;
}
public static float processOrder(float totalValue)
throws IOException
{
BufferedReader input = new BufferedReader(new InputStreamReader(System.in));
int location = findItem();
int quantity=0;
float orderValue;
String textQuantity;
System.out.println("\nQuantity Sold: ");
textQuantity = input.readLine();
try{
quantity = Integer.parseInt(textQuantity);
}catch(NumberFormatException e){System.out.println("\n\t** ERROR - Non Numerical Value Entered! **\n");}
if (quantity <= currentLevel[location])
{
currentLevel[location] = currentLevel[location] - quantity;
orderValue = price[location] * quantity;
DecimalFormat decimal = new DecimalFormat("0.00");
System.out.println("\nTotal Order Value: " + decimal.format(orderValue));
totalValue = totalValue + orderValue;
}
else
{
System.out.println("\n\t** ERROR - Insufficient Stock To Satisfy Order! **\n");
}
return totalValue;
}
public static void displayReorderList()
{
System.out.println("\n\nStock Code\tCurrent Level\tReorder Level");
System.out.println("----------\t-------------\t-------------");
for (int count=0; count < numItems; count++)
{
if (currentLevel[count] <= reorderLevel[count])
{
System.out.println(stockCode[count] + "\t\t\t" + currentLevel[count] + "\t\t" + reorderLevel[count]);
}
}
}
public static void displayItem()
throws IOException
{
int location = findItem();
System.out.println("\n\nCurrent Level\t\tReorder Level");
System.out.println("-------------\t\t-------------");
System.out.println("\t" + currentLevel[location] + "\t\t\t" + reorderLevel[location]);
}
public static void readData()
throws IOException
{
File file = new File("stock.txt");
if(file.exists())
{
int count=0, i;
String txtCurrentLevel, txtReorderLevel, txtPrice, currentData;
BufferedReader input = new BufferedReader(new FileReader("stock.txt"));
do
{
  stockCode[count] = input.readLine();
  stockDesc[count] = input.readLine();
  txtCurrentLevel = input.readLine();
  currentLevel[count] = Integer.parseInt(txtCurrentLevel);
  txtReorderLevel = input.readLine();
  reorderLevel[count] = Integer.parseInt(txtReorderLevel);
  txtPrice = input.readLine();
  price[count] = Float.parseFloat(txtPrice);
  count++;
}while (input.ready());
input.close();
numItems = count;
}
else
{
System.out.println("\n\t** ERROR - Stock File Could Not Be Found **\n");
}
}
public static void writeData()
throws IOException
{
PrintWriter output = new PrintWriter(new FileWriter("stock.txt"));
for (int count=0; count < numItems; count++)
{
output.println(stockCode[count]);
output.println(stockDesc[count]);
output.println(currentLevel[count]);
output.println(reorderLevel[count]);
output.println(price[count]);
}
output.close();
}
public static void displayMenu()
{
System.out.println("\n\n\t\tWelcome To The Stock Control System");
System.out.println("\t\t------- -- --- ----- ------- ------\n");
System.out.println("Please Select An Option From The List Below:\n\n");
System.out.println("(1)  -  Initialise/Extend Stock");
System.out.println("(2)  -  Process Stock Delivery");
System.out.println("(3)  -  Process Sale");
System.out.println("(4)  -  Items At/Below Re-Order Level");
System.out.println("(5)  -  Items Current/Re-Order Level");
System.out.println("(6)  -  Quit\n");
System.out.println("Option Number:");
}
public static int findItem()
throws IOException
{
BufferedReader input = new BufferedReader(new InputStreamReader(System.in));
String searchItem;
boolean found = false;
do{
System.out.println("\nPlease Enter Stock Code:");
searchItem = input.readLine();
for (int itemNum = 0; itemNum < stockCode.length; itemNum++)
{
if (stockCode[itemNum]!=null && stockCode[itemNum].equalsIgnoreCase(searchItem))
{
found = true;
return itemNum;
}
}
System.out.println("\n\t** ERROR - Stock Code Not Found **\n");
}while(!found);
return 0;
}
public static void displayData()
{
System.out.println("#########################################################################");
System.out.println("#   Stock Code\tStock Desc.\tCurrent Level\tReorder Level\tPrice\t#");
System.out.println("#   -----------\t-----------\t-------------\t-------------\t-----\t#");
DecimalFormat decimal = new DecimalFormat("0.00");
for (int count=0; count < numItems; count++)
{
System.out.println("#   " + stockCode[count] + "   \t" + stockDesc[count] + "\t\t" + currentLevel[count] + "\t\t" + reorderLevel[count] + "\t" + decimal.format(price[count]) + "\t#");
}
System.out.println("#########################################################################");
}
public static void displayStatistics(int numOrders, float totalValue)
{
int lowStockCount = 0;
for (int count = 0; count < numItems; count++)
{
if (currentLevel[count] <= reorderLevel[count])
{
lowStockCount++;
}
}
DecimalFormat decimal = new DecimalFormat("0.00");
System.out.println("\nNumber of Orders\t\tTotal Value\t\tLow Stock Count");
System.out.println("----------------\t\t-----------\t\t---------------");
System.out.println("\t" + numOrders + "\t\t\t\t" + decimal.format(totalValue) + "\t\t\t" + lowStockCount);
try{
writeData();
}catch (IOException e) {}
}
} 

Thanks in advance!
Regards,
Emile

[Nick George]

As for command prompt, I think you're out of luck. Were you to write your application in a GUI, you could simply use unicode characters. If I remember correctly, pounds sterling is '\u00A3' (I looked that up). Charts abound on the web, this one's my favorite:
Unicode Charts

[Emile Ghazzawi]

Hi again,
Any tips you could give on the posted code? Or does it all look ok to you?
Regards,
Emile

[Michael Dunn]

Overall it looks pretty good.
A few things:-
1) when you start the program the first time - if you do nothing except
select (6) quit, it errors when you open the program the next time. Test by renaming your current "stock.txt".
this can be fixed by changing
do
{
}while (input.ready());
to
while (input.ready())
{
}
but don't know if this will break something else
2) suggest your program which look like this

 
public class StockControl
{
  public static void main(String[] args)
  {
    a lot of the work here
  }
  various methods()
  {
  }
}

to this

 
public class StockControl
{
  public StockControl() //using a constructor, instead of main()
  {
    a lot of the work here
  }
  various methods()
  {
  }
  public static void main(String[] args)
  {
    new StockControl();//invokes the constructor
  }
}

this way your code can be called by another program
3) when displaying the results of a query eg current stock level, after the
code to display the results, add something like this
System.out.println("Press [ENTER] to continue");
String junk = input.readLine();
this way the result will be at the bottom of the screen, where it is
expected to be, instead of near the top, with the next option menu showing
at the bottom ie you currently have to search the screen for the result.
4) if you want to have a bit of fun, try to convert it from arrays of data
to a HashMap of objects - StockItem, with the stockCode being the key

class StockItem
{
  String stockCode;
  String stockDesc;
  int currentLevel;
  int reorderLevel;
  float price;
}

I'm away for a couple of days, and if I get a chance I'll try to rewrite it
the way I've suggested, which is probably an easier way to show you the
difference.

[Michael Dunn]

Here's a bit of a re-write. It essentially does the same thing as your code.
I've added a couple of menu items and changed the saving of the data to
after each change.
The main difference is removing the limit of stock items.

import java.io.*;
import java.text.DecimalFormat;
import java.util.*;
public class StockControl1
{
  BufferedReader input = new BufferedReader(new InputStreamReader(System.in));
  DecimalFormat decimal = new DecimalFormat("0.00");
  Map stock = new HashMap();
  int selection, numOrders;
  double totalValue = 0;
  boolean quit = false;
  String junk;
  public StockControl1()
  {
    System.out.println("\n\n\t\tWelcome To The Stock Control System");
    System.out.println("\t\t------- -- --- ----- ------- ------\n");
    try
    {
      readData();
      while(!quit) displayMenu();
      if(totalValue > 0) displayStatistics();
    }
    catch (Exception e){System.out.println("\n\t** ERROR - Exiting Program! **\n");}
    goodbye();
  }
  public void readData() throws IOException
  {
    File file = new File("stock.txt");
    if(file.exists())
    {
      BufferedReader fr = new BufferedReader(new FileReader("stock.txt"));
      String line = "";
      String[] bits;
      while ((line = fr.readLine()) != null)
      {
        bits = line.split(";");
        stock.put(bits[0],new StockItem(bits[0],bits[1],Integer.parseInt(bits[2]),
                  Integer.parseInt(bits[3]),Double.parseDouble(bits[4])));
      }
      fr.close();
    }
  }
  public void displayMenu()
  {
    System.out.println("\n\n***Main Menu***\n\n");
    System.out.println("Please Select An Option From The List Below:\n");
    System.out.println("(1)  -  Initialise/Extend Stock");
    System.out.println("(2)  -  Delete Stock");
    System.out.println("(3)  -  List Stock Items");
    System.out.println("(4)  -  Process Stock Delivery");
    System.out.println("(5)  -  Process Sale");
    System.out.println("(6)  -  Items At/Below Re-Order Level");
    System.out.println("(7)  -  Items Current/Re-Order Level");
    System.out.println("(8)  -  Quit\n");
    System.out.print("Option Number (1 - 8): ");
    try
    {
      selection = Integer.parseInt(input.readLine());
      clearScreen();
      if(selection == 1) extendStock();
      else if(selection == 2) deleteStock();
      else if(selection == 3) listStock();
      else if(selection == 4) acceptStock();
      else if(selection == 5) processOrder();
      else if(selection == 6) displayReorderList();
      else if(selection == 7) displayItem();
      else quit = true;
    }
    catch(Exception e)
    {
      System.out.println("\n\nInvalid data");
      hold();
    }
  }
  public void extendStock() throws Exception
  {
    String code,desc,currLev,reOrdLev,price, more = "Y",confirm;
    do
    {
      System.out.println("\n\n***Extend Stock***\n\n");
      System.out.print("\n\nPlease Enter Stock Code       : ");
      code = input.readLine().trim();
      if(stock.containsKey(code))System.out.println("error - Stock code already exists");
      else
      {
        System.out.print("Please Enter Stock Description: ");
        desc = input.readLine().trim();
        System.out.print("Please Enter Current Level    : ");
        currLev = input.readLine().trim();
        System.out.print("Please Enter Reorder Level    : ");
        reOrdLev = input.readLine().trim();
        System.out.print("Please Enter Price            : ");
        price = input.readLine().trim();
        System.out.print("Confirm correct y/n (q-quit)  : ");
        confirm = input.readLine().trim();
        if(confirm.equalsIgnoreCase("q")) {clearScreen();return;}
        if(confirm.equalsIgnoreCase("y"))
        {
          try
          {
            stock.put(code,new StockItem(code,desc,Integer.parseInt(currLev),
                      Integer.parseInt(reOrdLev),Double.parseDouble(price)));
            writeData(code);
            System.out.print("\nWould You Like To Enter Another Item? - Y/N: ");
            more = input.readLine();
          }
          catch(Exception e){System.out.println("Invalid data - try again");}
        }
      }
    }while(more.equalsIgnoreCase("Y"));
    clearScreen();
  }
  public void deleteStock() throws IOException
  {
    System.out.println("\n\n***Delete Stock***\n\n");
    System.out.print("\nPlease Enter Stock Code:");
    String searchItem = input.readLine();
    StockItem temp = (StockItem)stock.get(searchItem);
    if(temp == null) System.out.println("Stock code does not exist");
    else
    {
      System.out.print("Confirm delete "+temp.stockCode+" "+temp.stockDesc+" y/n (q-quit) : ");
      String confirm = input.readLine().trim();
      if(confirm.equalsIgnoreCase("q")) {clearScreen();return;}
      if(confirm.equalsIgnoreCase("y"))
      {
        stock.remove(searchItem);
        saveData();
      }
    }
    clearScreen();
  }
  public void listStock()
  {
    System.out.println("\n\n***List Stock Items***\n\n");
    System.out.println("Stock Code\tStock Description");
    System.out.println("----------\t-----------------\n");
    Iterator iter = stock.values().iterator();
    StockItem temp;
    while(iter.hasNext())
    {
      temp = (StockItem)iter.next();
      System.out.println(temp.stockCode + "\t\t" + temp.stockDesc);
    }
    hold();
  }
  public void acceptStock() throws IOException
  {
    System.out.println("\n\n***Accept Stock***\n\n");
    System.out.println("\nPlease Enter Stock Code:");
    String searchItem = input.readLine();
    StockItem temp = (StockItem)stock.get(searchItem);
    if(temp == null) System.out.println("Stock code does not exist");
    else
    {
      System.out.print("\nPlease Enter The Amount Of New Stock: ");
      temp.currentLevel += Integer.parseInt(input.readLine());
      saveData();
    }
    clearScreen();
  }
  public void processOrder() throws IOException
  {
    System.out.println("\n\n***Process Order***\n\n");
    System.out.print("\nPlease Enter Stock Code:");
    String searchItem = input.readLine();
    StockItem temp = (StockItem)stock.get(searchItem);
    if(temp == null) System.out.println("Stock code does not exist");
    else
    {
      System.out.print("\nQuantity Sold: ");
      int quantity = Integer.parseInt(input.readLine());
      double orderValue;
      if (quantity <= temp.currentLevel)
      {
        temp.currentLevel -= quantity;
        orderValue = temp.price * quantity;
        System.out.println("\nTotal Order Value: " + decimal.format(orderValue));
        totalValue += orderValue;
        numOrders++;
        saveData();
      }
      else
      {
        System.out.println("\n\t** ERROR - Insufficient Stock To Satisfy Order! **\n");
      }
    }
    hold();
  }
  public void displayReorderList()
  {
    System.out.println("\n\n***Display ReOrder List***\n\n");
    System.out.println("\n\nStock Code\tCurrent Level\tReorder Level");
    System.out.println("----------\t-------------\t-------------");
    Iterator iter = stock.values().iterator();
    StockItem temp;
    while(iter.hasNext())
    {
      temp = (StockItem)iter.next();
      if (temp.currentLevel <= temp.reorderLevel)
      {
        System.out.println(temp.stockCode + "\t\t\t" + temp.currentLevel + "\t\t" + temp.reorderLevel);
      }
    }
    hold();
  }
  public void displayItem() throws IOException
  {
    System.out.println("\n\n***Display Item***\n\n");
    System.out.print("\nPlease Enter Stock Code:");
    String searchItem = input.readLine();
    StockItem temp = (StockItem)stock.get(searchItem);
    if(temp == null) System.out.println("Stock code does not exist");
    else
    {
      System.out.println("\n\nStock Desc.\t\tCurrent Level\t\tReorder Level");
      System.out.println("-------------\t\t-------------\t\t-------------");
      System.out.println(temp.stockDesc+"\t\t\t"+ temp.currentLevel + "\t\t\t" + temp.reorderLevel);
    }
    hold();
  }
  public void writeData(String key)
  {
    try
    {
      PrintWriter output = new PrintWriter(new BufferedWriter(new FileWriter("stock.txt",true)));
      StockItem newItem = (StockItem)stock.get(key);
      output.println(newItem.stockCode+";"+newItem.stockDesc+";"+newItem.currentLevel+
                                          ";"+newItem.reorderLevel+";"+newItem.price);
      output.close();
    }
    catch(Exception e){System.out.println("Error saving stock code "+key);}
  }
  public void saveData()
  {
    try
    {
      PrintWriter output = new PrintWriter(new BufferedWriter(new FileWriter("stock.txt")));
      Iterator iter = stock.values().iterator();
      StockItem temp;
      while(iter.hasNext())
      {
        temp = (StockItem)iter.next();
        output.println(temp.stockCode+";"+temp.stockDesc+";"+temp.currentLevel+
                                            ";"+temp.reorderLevel+";"+temp.price);
      }
      output.close();
    }
    catch(Exception e){System.out.println("Error saving data");}
  }
  public void displayData()
  {
    System.out.println("\n\n***Display Data***\n\n");
    System.out.println("#########################################################################");
    System.out.println("#   Stock Code\tStock Desc.\tCurrent Level\tReorder Level\tPrice\t#");
    System.out.println("#   -----------\t-----------\t-------------\t-------------\t-----\t#");
    Iterator iter = stock.values().iterator();
    StockItem temp;
    while(iter.hasNext())
    {
      temp = (StockItem)iter.next();
      System.out.println("#   " + temp.stockCode + "   \t" + temp.stockDesc + "\t\t" +
      temp.currentLevel + "\t\t" + temp.reorderLevel + "\t" + decimal.format(temp.price) + "\t#");
    }
    System.out.println("#########################################################################");
    hold();
  }
  public void displayStatistics()
  {
    int lowStockCount = 0;
    Iterator iter = stock.values().iterator();
    StockItem temp;
    while(iter.hasNext())
    {
      temp = (StockItem)iter.next();
      if(temp.currentLevel <= temp.reorderLevel) lowStockCount++;
    }
    System.out.println("\n\n***Display Statistics***\n\n");
    System.out.println("\nNumber of Orders\t\tTotal Value\t\tLow Stock Count");
    System.out.println("----------------\t\t-----------\t\t---------------");
    System.out.println("\t" + numOrders + "\t\t\t\t" + decimal.format(totalValue)
                                                   + "\t\t\t" + lowStockCount);
    hold();
  }
  public void clearScreen(){for(int x = 0; x < 25; x++)System.out.println();}
  public void hold()
  {
    try
    {
      System.out.println("\n\nPress [ENTER] to continue...");
      junk = input.readLine();
      clearScreen();
    }
    catch(Exception e){}
  }
  public void goodbye()
  {
    System.out.println("\n\nThank you for using the Stock Control Program.\n\nGoodbye.");
    System.exit(0);
  }
  public static void main(String[] args){new StockControl1();}
}
class StockItem
{
  String stockCode;
  String stockDesc;
  int currentLevel;
  int reorderLevel;
  double price;
  public StockItem(String pStockCode,String pStockDesc,int pCurrentLevel,
                   int pReorderLevel,double pPrice)
  {
    stockCode = pStockCode;
    stockDesc = pStockDesc;
    currentLevel = pCurrentLevel;
    reorderLevel = pReorderLevel;
    price = pPrice;
  }
}