Array of Images - PLEASE HELP!

[PM Knight]

Hi,

I've been running around in circles with this - but no amount of advice seems to be getting it working!

PLEASE HELP!

My code produces 2 errors, for each of the six images (ie 12 in total):

they are:

1)

---------- Java Compiler ----------
ImageArrary.java:22: ']' expected
imageArray[0]=getImage(getCodeBase(),"pic0.gif");
                           ^

2)

ImageArrary.java:22: <identifier> expected
imageArray[0]=getImage(getCodeBase(),"pic0.gif");
                                                                ^

Whatever I do I cannot fix these errors, where am I going wrong???
Please can someone post a fixed version as this is drving me crazy - I've been doing it for so long.

Thank-you greatly in advance for any help offered.

This is the seemingly simple code that is killing me:

import java.awt.*;
import java.applet.*;
import javax.swing.*;
 

public class ImageArray extends JApplet implements ImageObserver
{

Image pic0, pic1, pic2, pic3, pic4, pic5;

//declare x co-ords in array
int [] x_pos = {206, 214, 221, 234, 257, 281};
 

//declare y co-ords in array
int [] y_pos = {117, 87,  59,  141, 118, 94};


//declare images in array
Image imageArray[] = new Image[6];

imageArray[0]=getImage(getCodeBase(),"pic0.gif");
imageArray[1]=getImage(getCodeBase(),"pic1.gif");
imageArray[2]=getImage(getCodeBase(),"pic2.gif");
imageArray[3]=getImage(getCodeBase(),"pic3.gif");
imageArray[4]=getImage(getCodeBase(),"pic4.gif");
imageArray[5]=getImage(getCodeBase(),"pic5.gif");

public void init()
{
pic0 = imageArray[0];
pic1 = imageArray[1];
pic2 = imageArray[2];
pic3 = imageArray[3];
pic4 = imageArray[4];
pic5 = imageArray[5];
}

public void paint (Graphics g)

{
 
//paint pictures at x,y co-ords

g.drawImage(pic0,x_pos[0],y_pos[0],this);
g.drawImage(pic1,x_pos[1],y_pos[1],this);
g.drawImage(pic2,x_pos[2],y_pos[2],this);
g.drawImage(pic3,x_pos[3],y_pos[3],this);
g.drawImage(pic4,x_pos[4],y_pos[4],this);
g.drawImage(pic5,x_pos[5],y_pos[5],this);
}
}

[Joe Ess]

First, I'd like to ask you to read our naming policy and proceed to editing your display name into something compliant with the said policy.
Second, you are attempting to place expressions where only declarations can go. Consider the following:

  
class broken {
   StringBuffer sb = new StringBuffer();
   sb.append("blah");
}
 
class works1{
   StringBuffer sb = new StringBuffer();
   static {sb.append("blah");}
}
 
class works2{
   StringBuffer sb;
   public works2(){
      sb = new StringBuffer();
      sb.append("blah");
   }
}

Class "broken" is similar to what you are trying to do. I placed the executable code "sb.append("blah");" in the same place you are trying to initalize your arrays. You will get an "<identifier expected>" flagged on that line. Class "works1" demonstrates something called a static initializer block. The line "static {sb.append("blah");}" gets executed once, when the class is loaded. Note the "static" keyword and the enclosing braces. It will compile without error. Class works2 shows the typical way to do initialization, in a constructor.

[Julian Kennedy]

So in your case you probably want to put the offending imageArray initialisation at the top of your init() method. You'll also need to import ImageObserver. I suggest that you make your imports specific rather than using *, which is just lazy and may lead to further troubles of the kind your currently having. You're only using 4 classes in that code fragment.

Would be nice if it said "statement where declaration should go error" though, eh?

Jules

[Dirk Schreckmann]

To be clear, note that Joe's "works1" example works if the initialization block is not static, or if sb is static. As is, it won't compile.