This week's book giveaway is in the Big Data forum.
We're giving away four copies of Elasticsearch in Action and have Radu Gheorghe & Matthew Lee Hinman on-line!
See this thread for details.
The moose likes Beginning Java and the fly likes better way? Big Moose Saloon
  Search | Java FAQ | Recent Topics | Flagged Topics | Hot Topics | Zero Replies
Register / Login

Win a copy of Elasticsearch in Action this week in the Big Data forum!
JavaRanch » Java Forums » Java » Beginning Java
Bookmark "better way?" Watch "better way?" New topic

better way?

david lightman
Ranch Hand

Joined: Nov 03, 2004
Posts: 82
I basically want to check a key in a hashtable (dog) and if there is a key named dog pull the value which is his name.

but it seems like alot of moving around, is there a better way to do this?

Ernest Friedman-Hill
author and iconoclast

Joined: Jul 08, 2003
Posts: 24189

You can factor out the variable "dog", and you don't need to construct a new Hashtable (very inefficient, and totally unnecessary!)

You could remove the check for null if you assured that getHashTableData() never returned null -- generally a smarter, cleaner way to program. Then you could write it in one line:

String dogName = (String) myClass.getHashTableData().get("DOG");

[Jess in Action][AskingGoodQuestions]
Rick O'Shay
Ranch Hand

Joined: Sep 19, 2004
Posts: 531
Avoid ever having a null collection. It's much better to assume you have a valid collection and check the size for something greater than zero. Also, unless you have an old version of Java you should specifiy what is in your collection. Never use Hashtable: use HashMap. You can synchronize access to your HashMap, if needed, and use it consitently everywhere. Finally, always declare the collection interface not the concrete type.

I agree. Here's the link:
subject: better way?