The lovely tic tac toe implementation!

[Mike Smith]

Hello, I am now on the finally tic tac toe implementation. I am to make a gui tic tac toe game. I am having a little problem with getting my program to display who has won the game. Right now the program is saying the game has resulted in a tie(it does this all the time). It does work properly besides that part I believe. It determines if a move is invalid if a square is occupied etc... If someone could point me where I am off this would greatly help me out. Thanks again

import java.awt.Color;
import java.awt.Dimension;
import java.awt.Font;
import java.awt.FontMetrics;
import java.awt.Graphics;
import javax.swing.JComponent;
import javax.swing.JFrame;
 
public class TicTacToe {
  private final static String progTitle = "GraphTemp";
  private static JFrame mainFrame = new JFrame( progTitle );
 
  public static void main(String args[]) {
    //*************** Add variables after this line ************************
 
Board curboard;
boolean boardfull;
boolean won;
int mov;
char who;
 

    //*************** Add initialization code after this line **************
boardfull = false;
won = false;
mov = 0;
 

 

    //*************** Initialize canvas ************************************
    initCanvas();
 
    // ************** Begin main program after these two lines *************
    // to repaint the canvas use: mainFrame.repaint();
 
curboard = BoardContainer.getBoard();
 
while((boardfull == curboard.boardFull()  || (won == curboard.winningMove()))) {
mov = MyUtils.readInteger( "Please enter a move:",0,0);
boardfull = curboard.nextMove(mov);//***
 
if(boardfull==false) {
System.out.println("The move is not valid.");
} else {
mainFrame.repaint();
//Opponent.doMove(curboard);
curboard.printBoard();
mainFrame.repaint();
 
}
}
if(boardfull == true) {
System.out.println("The game has ended in a tie.");
} else if(won==true) {
who = curboard.getSquare(mov);
System.out.println(who + " s won! ");
}
}
 
  //***************** DO NOT MODIFY THIS METHOD *************
  private static void initCanvas() {
    mainFrame.getContentPane().add(new MyCanvas());
    mainFrame.pack();
    mainFrame.setVisible(true);
  }
 
}
 

class MyCanvas extends JComponent {
  // Set the width and height of the canvas
  private final static int canvasWidth = 400;
  private final static int canvasHeight = 400;
 
  public void paintComponent(Graphics g) {
    //*************** Add variables after this line ************************
 

 
    //*************** Initialize painting **********************************
    initPaint( g );
 

    // **************** Add graphic statements after this line  ************
 

 
    // **************** End of graphic statements **************************
  }
 

  //***************** Do not modify anything below this line ***************
  public Dimension getPreferredSize() {
    return new Dimension(canvasWidth, canvasHeight);
  }
 
  public Dimension getMinimumSize() {
    return getPreferredSize();
  }
 
  private void initPaint( Graphics g ) {
    super.paintComponent(g);
 
    // draw entire component white (initialize to white
    g.setColor(Color.white);
    g.fillRect(0, 0, getWidth(), getHeight());
  }
}
 
 

[Jeanne Boyarsky]

Mike,
Two things:
1) I don't see anywhere where you set won to true. Can you point to the part of the code that does that? Or if it isn't implemented, can you describe how you know the game is won?

2) You should reverse the order of the following two if statements. It is valid for the board to be full and have someone still win. For example, if X moves 5 times and O moves 4 times and X wins on the fifth move.

if(boardfull == true) {
System.out.println("The game has ended in a tie.");
} else if(won==true) {
who = curboard.getSquare(mov);
System.out.println(who + " s won! ");
}