Help.

[Stephen Foy]

Ive completed my program which works fine. But im not happy with it. It looks a mess and very poorly written. Especially my methods.

Any help on how i can improve on this?

// Stephen Foy - 200514959
// Assignment Two
// Glasgow Caledonian University
 
import java.math.*;
import java.util.*;
 
class dice {
 
public static void main(String[] args) {
dice game = new dice();
boolean loopGame = false;
 
while (!loopGame) {
 
game.rollDice();
System.out.println(game.highestValue());
 
System.out.print("Would you like to play again y or n: ");
Scanner in = new Scanner(System.in);
String answer = in.nextLine();
 
if (answer.length() == 1 && answer.charAt(0)=='y') {
loopGame = false;
}
else if (answer.length() == 1 && answer.charAt(0)=='n') {
loopGame = true;
}
 
}
 

}
 
int[] diceRound = new int[3];
int[] values = new int[3];
 
/** Adds together the values of values, taken from the rollDice method
* @returns sum - the final value of the added sums.
* **/
 
public int highestValue() {
int sum = 0;
for (int i = 0;i < values.length;i++) {
sum = ((sum + values[i]));
}
return sum;
}
 
/** Assigns random numbers to dice
*@param Assigns 3 random values to array diceRound
*@return Retruns the realnum value which a random value**/
 
int diceNumber() {
double number = (int)(Math.random() * 6) + 1;
int realNum = (int)number;
return realNum;
}
 
/** Dice Roller. Plays the game.
*Rolls 3 random numbers, gives user option of rolling again or saving highest value
*Rolls 2 random numbers, gives user option of rolling again or saving highest value
*Rolls 1 random numbers, gives user option of rolling again or saving highest value
*Saves Highest values to the array "values".**/
 
void rollDice() {
 
dice roller = new dice();
int largest = Integer.MIN_VALUE;
int highestRolls = 0;
boolean UserRollsAgain = false;
int length = diceRound.length;
int moverolls = 1;
int counter = 0;
 
while (moverolls <= 3) {
 
UserRollsAgain = false;
 
if (moverolls == 2) { length = diceRound.length - 1; largest = 0;}
else if (moverolls == 3) { length = diceRound.length - 2; largest = 0;}
 
while (!UserRollsAgain) {
for (int i = 0;i < length;i++) {
diceRound[i] = roller.diceNumber();
System.out.print(diceRound[i]+" | ");
 
if (diceRound[i] > largest) {
highestRolls = diceRound[i];
largest = diceRound[i];
}
values[i] = largest;
}
 
System.out.print("\nThe largest number is "+largest+" keep it or roll again? y or n: ");
Scanner in = new Scanner(System.in);
String answer = in.nextLine();
 

if (counter == 2) {
System.out.println ("\nNo more rolls\n");
UserRollsAgain = true;
moverolls++;
counter = 0;
}
else if (answer.length() == 1 && answer.charAt(0)=='y') {
counter++;
largest = 0;
UserRollsAgain = false;
}
else if (answer.length() == 1 && answer.charAt(0)=='n') {
UserRollsAgain = true;
moverolls++;
}
}
}
System.out.println(" ");
}
}

[Campbell Ritchie]

Well, not knowing what the rules of the game are supposed to be, it is difficult to tell what you are doing wrong in your methods.
I agree with you however; you do need to tidy it up. You have capitalisation wrong, you have some if . . . {} blocks all written as one line, you seem to be creating your Scanner object and a dice() object several times.
You don't need the java.math.*; import; you aren't using either of the java.math classes. And if I say any more, I shall expect you to share the marks with me

[Campbell Ritchie]

. . . and don't use vague thread titles like "Help." Tell people what you want in the thread title.