File APIs for Java Developers
Manipulate DOC, XLS, PPT, PDF and many others from your application.
The moose likes Beginning Java and the fly likes Help. Big Moose Saloon
  Search | Java FAQ | Recent Topics | Flagged Topics | Hot Topics | Zero Replies
Register / Login

Win a copy of REST with Spring (video course) this week in the Spring forum!
JavaRanch » Java Forums » Java » Beginning Java
Bookmark "Help." Watch "Help." New topic


Stephen Foy
Ranch Hand

Joined: Oct 17, 2005
Posts: 143
Ive completed my program which works fine. But im not happy with it. It looks a mess and very poorly written. Especially my methods.

Any help on how i can improve on this?

Stephen Foy - Microsoft Application Development Consultant
Campbell Ritchie

Joined: Oct 13, 2005
Posts: 45289
Well, not knowing what the rules of the game are supposed to be, it is difficult to tell what you are doing wrong in your methods.
I agree with you however; you do need to tidy it up. You have capitalisation wrong, you have some if . . . {} blocks all written as one line, you seem to be creating your Scanner object and a dice() object several times.
You don't need the java.math.*; import; you aren't using either of the java.math classes. And if I say any more, I shall expect you to share the marks with me
Campbell Ritchie

Joined: Oct 13, 2005
Posts: 45289
. . . and don't use vague thread titles like "Help." Tell people what you want in the thread title.
I agree. Here's the link:
subject: Help.
jQuery in Action, 3rd edition