HFJ 2nd - Problem with SimpleDotCom

[Silvio Lobo]

Hi!

I'm learning Java using Head First Java, 2nd Edition...
I'm at Chapter 5, constructing the SimpleDotCom game...

And I just got errors!

My classes:

SimpleDotCom ( 6 errors )

public class SimpleDotCom {
 
int[] locationCells;
int numOfHits = 0;
 
public void setLocationCells(int[] locs) {
locationCells = locs;
}
 
public String checkYourself (String stringGuess) {
int guess = Integer.parseInt(stringGuess);
String result = "miss";
for (int cell : locationCells) {
result = "hit";
numOfHits++;
break;
}
} // out of the loop
 
if (numOfHits == locationCells.length) {
result = "kill";
}
 
System.out.println(result);
return result;
} // close method
} // close class

SimpleDotComGame ( 6 errors)

class SimpleDotComGame {
public static void main(String[] args) {
int numOfGuesses = 0;
GameHelper helper = new GameHelper();
 
SimpleDotCom theDotCom = new SimpleDotCom();
int randomNum = (int) (Math.random() * 5);
 
int[] locations = {randomNum, randomNum+1, randomNum+2};
theDotCom.setLocationCells(locations);
boolean isAlive = true;
 
while(isAlive == true) {
String guess = helper.getUserInput("enter a number");
String result = theDotCom.checkYourself(guess);
numOfGuesses++;
if (result.equals("kill")) {
isAlive = false;
System.out.println("You took " + numOfGuesses + " guesses");
} //close if
} // close while
} // close main
}

GameHelper (This one compiles fine)

import java.io.*;
public class GameHelper {
public String getUserInput(String prompt) {
String inputLine = null;
System.out.print(prompt + " ");
try {
BufferedReader is = new BufferedReader (new 
 
InputStreamReader(System.in));
inputLine = is.readLine();
if (inputLine.length() == 0 ) 
return null;
} catch (IOException e) {
System.out.println("IOException: " + e);
}
return inputLine;
}
}

What's wrong???

PS.I'm using Java 5.0 version ( jdk1.5.0_06 )

Thanks!

[fred rosenberger]

can you post what errors you are getting? they actually tell you a lot of what's wrong.

[Ernest Friedman-Hill]

Hi,

Welcome to JavaRanch!

There's an extra close brace on the line before the "Out of the loop" line; that messes up everything from that point on.

If you're using Notepad or something along those lines to edit your code: this is the kind of thing that any decent programmers editor would point out to you as you type.

[Silvio Lobo]

Errors from SimpleDotCom

javac SimpleDotCom.java
 
SimpleDotCom.java:20: illegal start of type
        if (numOfHits == locationCells.length) {
        ^
SimpleDotCom.java:24: <identifier> expected
        System.out.println(result);
                                  ^
SimpleDotCom.java:25: illegal start of type
                return result;
                ^
SimpleDotCom.java:25: <identifier> expected
                return result;
                             ^
SimpleDotCom.java:27: 'class' or 'interface' expected
} // close class
^
SimpleDotCom.java:27: 'class' or 'interface' expected
} // close class
                ^
6 errors

Errors from SimpleDotComGame

javac SimpleDotComGame.java
 
.\SimpleDotCom.java:20: illegal start of type
        if (numOfHits == locationCells.length) {
        ^
.\SimpleDotCom.java:24: <identifier> expected
        System.out.println(result);
                                  ^
.\SimpleDotCom.java:25: illegal start of type
                return result;
                ^
.\SimpleDotCom.java:25: <identifier> expected
                return result;
                             ^
.\SimpleDotCom.java:27: 'class' or 'interface' expected
} // close class
^
.\SimpleDotCom.java:27: 'class' or 'interface' expected
} // close class
                ^
6 errors

Thanks!

[Shyam Prasad Murarka]

Dear Reader,
Check out the "checkYourself()" method properly. You will see an if condition missing.

[Silvio Lobo]

I can't believe it!
It works fine now! ( no compile errors! )

I'm so ashamed!! The if condition was there(in the book) and I didn't see it!

But, Thanks for all!!!