Sending Multiple Emails

[Crystal Bazil]

Basically what I am doing with the below code is calling some methods and based on that criteria calling my notfierEmail servlet. NotifierEmail sends off an email notice.

Everything works in theory.. I get an email for the first element in my owner ArrayList with all proper information but then it just stops. No error message or anything.. I need to be able to loop through those owner elements and send off an email for each one.

Could someone point me in a direction on how to do this? I would really appreciate it. Thanks!

Crystal

    
scheduler servlet
.....
 
notifier sitemanager = notifierDB.SiteManager(newID, notifierInformation);
ArrayList owners = notifierInformation.getSitemgrList();
            
for (int i = 0; i < owners.size(); i++) {
    Object sso = owners.get(i);
                
    notifier allAreas = notifierDB.smAreas(newID, notifierInformation, sso );
    notifier sm_first = notifierDB.smFirstNotice(newID, notifierInformation);
    notifier sm_second = notifierDB.smSecondNotice(newID, notifierInformation);
               
    LinkedHashMap smFirst = notifierInformation.getSm_FirstNoticeMap();
    LinkedHashMap smSecond = notifierInformation.getSm_SecondNoticeMap();
        int size1 = smFirst.size();
        int size2 = smSecond.size();
 
        if(size1 != 0 | size2 != 0) {
          RequestDispatcher dispatcher = getServletContext().getRequestDispatcher("/notifierEmail?sso="+sso);
          dispatcher.forward(request, response);
          return;
          } 
}

    
notifierEmail servlet
...
public class notifierEmail extends HttpServlet {
    protected void doPost(HttpServletRequest request, HttpServletResponse response)
    throws ServletException, IOException {
        String grabURL = request.getRequestURI();
        String[] getUrl = grabURL.split("/");
        String newID = getUrl[1];
        String sso = request.getParameter("sso");
        
        HttpSession session = request.getSession();
        notifier notifierInformation =(notifier)session.getAttribute("notifier");
                
        //get db connection
        database.DataFactory dbf = database.DataFactory.getDataFactory(database.DataFactory.sybase);
        notifierInterface notifierDB = dbf.getNotifierInterface();
        
        notifier email = notifierDB.smEmail(newID, notifierInformation, sso);
        notifier notice = notifierDB.Notice(newID, notifierInformation);    
        
        LinkedHashMap smFirst = notifierInformation.getSm_FirstNoticeMap();
        LinkedHashMap smSecond = notifierInformation.getSm_SecondNoticeMap();
       
        
        String to = null;
        String from = null;
        String subject = null;
        String content = null;         
        String server = null;
 
        StringBuffer sb = new StringBuffer();
        sb.append("<font size=-1 face=Arial>");
        sb.append("This is a notice to close outstanding OOTS for" + sso);
        
        sb.append("You have ten days to close the below Out of Tolerances:");   
        Iterator first = smFirst.entrySet().iterator();
        while(first.hasNext()) { 
            Map.Entry entry = (Map.Entry)first.next(); 
            Object firstkey = entry.getKey(); 
            sb.append("<p><b>" + firstkey + "</b>");   
            sb.append("<br>");
        } 
            sb.append("<table width='200px' border='0' cellspacing='0' cellpadding='1'>");    
            sb.append("<tr>");  
            sb.append("<td width='100px'><font size=-3 face=Arial><b>OOT NUMBER</b></font></td>");
            sb.append("<td width='100px'><font size=-3 face=Arial><b>DUE DATE</b></font></td>");
            sb.append("</tr>");
            
        for (Iterator it = smFirst.values().iterator(); it.hasNext() :wink: {
            List list = (List) it.next();   
            for (int i = 0; i < list.size(); i++){
                String temp = (String)list.get(i);
                String[] fields = temp.split(",");
                sb.append("<tr>");  
                sb.append("<td><font size=-1 face=Arial>"+ fields[0] +"</font></td>");
                sb.append("<td><font size=-1 face=Arial>"+ fields[1] +"</font></td>");
                sb.append("</tr>"); 
            }
        }
        sb.append("</table>");
        sb.append("<p>");
        sb.append("<p>");
        sb.append("You have five or less days to close the below Out of Tolerances:");   
        Iterator second = smSecond.entrySet().iterator();
        while(second.hasNext()) { 
            Map.Entry entry = (Map.Entry)second.next(); 
            Object secondkey = entry.getKey(); 
            sb.append("<p><b>" + secondkey + "</b>");   
            sb.append("<br>");
        } 
            sb.append("<table width='200px' border='0' cellspacing='0' cellpadding='1'>");    
            sb.append("<tr>");  
            sb.append("<td width='100px'><font size=-3 face=Arial><b>OOT NUMBER</b></font></td>");
            sb.append("<td width='100px'><font size=-3 face=Arial><b>DUE DATE</b></font></td>");
            sb.append("</tr>");
            
        for (Iterator it = smSecond.values().iterator(); it.hasNext() :wink: {
            List list = (List) it.next();   
            for (int i = 0; i < list.size(); i++){
                String temp = (String)list.get(i);
                String[] fields = temp.split(",");
                sb.append("<tr>");  
                sb.append("<td><font size=-1 face=Arial>"+ fields[0] +"</font></td>");
                sb.append("<td><font size=-1 face=Arial>"+ fields[1] +"</font></td>");
                sb.append("</tr>"); 
            }
        }
        sb.append("</table>");
        
        
        
        sb.append("</font>");   
        
        to = (String)notifierInformation.getEmail();
        from = (String)notifierInformation.getEmail();
        subject = (String)notifierInformation.getSubject();
        content = sb.toString();
        server = (String)notifierInformation.getServer();
        String smtpServer = server;
        
        
        
        //response.setContentType("text/html");
        //PrintWriter out = response.getWriter();
 
        //out.println("<html><head><title>Email Message Sender </title></head><body>");
 
        try {
            if(to != null ) {
                sendOwnerNotice(smtpServer, to, from, subject, content);
            }
        } catch (Exception e) { 
            throw new ServletException(e.getMessage());
        }
        //RequestDispatcher dispatcher = getServletContext().getRequestDispatcher("/build/display/displayQuality.jsp?newID="+newID);
        //dispatcher.forward(request, response);
                
                     
    }
    
    private void sendOwnerNotice(String smtpServer, String to, String from, String subject, String content) throws Exception {
        Multipart multipart = null;
        BodyPart bpart1 = null;
        BodyPart bpart2 = null;
        
        Properties properties = System.getProperties();
        properties.put("mail.smtp.host", smtpServer);
                
        Session session = Session.getDefaultInstance(properties);
        Message mailMsg = new MimeMessage(session); // a new email message
        
        InternetAddress[] addresses = null;
        
        try {
            if(to != null) {
                addresses = InternetAddress.parse(to, false);
                mailMsg.setRecipients(Message.RecipientType.TO, addresses);
            } else {
                throw new MessagingException("The mail message requires a 'TO:' address.");
            }
            if(from != null) {
                mailMsg.setFrom(new InternetAddress(from));
            } else {
                throw new MessagingException(" The mail message requires a valid 'FROM:' address.");
            }
            if(subject != null)
                mailMsg.setSubject(subject);
                    multipart = new MimeMultipart();
                    bpart1 = new MimeBodyPart();
                    DataHandler data = new DataHandler(content, "text/html");
                    bpart1.setDataHandler(data);
                    multipart.addBodyPart(bpart1);
                mailMsg.setContent(multipart);
                Transport.send(mailMsg);
        } catch (Exception exc) {
            throw exc;
        }
        
    }
    
    
    protected void doGet(HttpServletRequest request, HttpServletResponse response)
    throws ServletException, IOException {
        doPost(request, response);
     }
     
}
 

[Brendan Caden]

Is this because your,

ArrayList owners = notifierInformation.getSitemgrList();

is not actually an array? I think it needs [].

[Chengwei Lee]

No Brendan, an ArrayList is not the same as arrays.

Is this because your,

ArrayList owners = notifierInformation.getSitemgrList();

is not actually an array? I think it needs [].

[Chengwei Lee]

Hi Crystal,

I suspect it is the return; thats causing you the problem. Do check it out.

    
for (int i = 0; i < owners.size(); i++) {
  :
  : 
  if (size1 != 0 | size2 != 0) {
    RequestDispatcher dispatcher = getServletContext().getRequestDispatcher("/notifierEmail?sso="+sso);
    dispatcher.forward(request, response);
    return;
} 

[Crystal Bazil]

Hi Chengwei,

I thought this might be the case as well - However, in Tomcat 5.x it seems I have to put the return in otherwise I get a java.lang.IllegalStateException.

This is information I got here: java.lang.IllegalStateException

I have tried moving the return around to no avail..
[ May 24, 2006: Message edited by: Crystal Bazil ]

[Paul Clapham]

The problem is that you are trying to send your e-mails by repeatedly forwarding to a servlet. This won't work because you can only forward the request once. My solution would be to change your design so that you don't use a servlet to send the e-mail, but a plain old Java class that you can use repeatedly.

But I told you all this at least a week ago on the Sun forum.

[Crystal Bazil]

ETA - I think it just clicked what you meant - Please ignore. I might be back with questions. Thanks

[ May 24, 2006: Message edited by: Crystal Bazil ]


ETA: It is working perfectly now! Thanks All
[ May 24, 2006: Message edited by: Crystal Bazil ]