New to java. Need help with errors.

[John Alderdice]

So I have to do this assignment and I'm pretty much done except I have a few errors that I can't solve.

 import java.util.Scanner;
 
public class FishShopApp1
{
public static void main(String[] args)
{
Scanner sc = new Scanner(System.in);
 
double baseArea, height, contents;
 
System.out.print("Enter base area for Tank 1: ");
baseArea = sc.nextDouble();
sc.nextLine();
System.out.print("Enter height for Tank 1: ");
height = sc.nextDouble();
sc.nextLine();
System.out.print("Enter contents for Tank 1: ");
contents=sc.nextDouble();
sc.nextLine();
FishTank tank1 = new FishTank(baseArea, height, contents);

System.out.print("Enter base area for Tank 2: ");
baseArea = sc.nextDouble();
sc.nextLine();
System.out.print("Enter height for Tank 2: ");
height = sc.nextDouble();
sc.nextLine();
System.out.print("Enter contents for Tank 2: ");
contents = sc.nextDouble();
sc.nextLine();
FishTank tank2 = new FishTank(baseArea, height, contents);
 
 
System.out.print("Enter base area for Tank 3: ");
baseArea = sc.nextDouble();
sc.nextLine();
System.out.print("Enter height for Tank 3: ");
height = sc.nextDouble();
sc.nextLine();
System.out.print("Enter contents for Tank 3: ");
contents = sc.nextDouble();
sc.nextLine();
FishTank tank3 = new FishTank(baseArea, height, contents);

int choice= 0;
         double volume = 0;
         volume = baseArea * height;
         int chooseTank = 0;
         
do {
            displayMenu();
            System.out.print("Enter Choice: ");
            choice=sc.nextInt(); sc.nextLine();
           
   switch(choice){
               
case 1 :
int[] FishTank = {1, 2, 3};             
                  System.out.print("Please choose which tank you want to add water to : ");
                  tankChosen = sc.nextInt();
                  sc.nextLine();
               
                  if(FishTank[0]== tankChosen)                  {
                     System.out.print("How much water would you like to add? (cubic cm): ");
                     volume = sc.nextDouble();
                     sc.nextLine();
                  
                     if (tank1.addIn(volume))
                        System.out.println("\nWater added in.");
                     else 
                        System.out.println("\nToo much water, fish tank will overflow!");
                  }
                  
                  else if(FishTank[1]== tankChosen)
                  {
                     System.out.print("How much water would you like to add? (cubic cm): ");
                     volume = sc.nextDouble();
                     sc.nextLine();
                  
                     if (tank2.addIn(volume))
                        System.out.println("\nWater added in.");
                     else
                        System.out.println("\nToo much water, fish tank will overflow.");
                  }
                  
                  else if(FishTank[2]==tankChosen)
                  {
                     System.out.print("Please enter the amount of water to be added(cubic cm): ");
                     volume = sc.nextDouble();
                     sc.nextLine();
                  
                     if (tank3.addIn(volume))
                        System.out.println("\nWater added in.");
                     else
                        System.out.println("\nToo much water, fish tank will overflow.");
                  }
                  else
                  {
                     System.out.println("Invalid fish tank number. Please choose again.");
                  }
               
                  break;
               case 2:
                  int tankFrom=0;
                  int tankInto=0;
                  int[] tankA ={1, 2, 3};
                  int[] tankB ={1, 2, 3};
               
                  System.out.print("Choose which tank you would like to take water from: ");
                  tankFrom = sc.nextInt();
                  sc.nextLine();
                  System.out.print("Choose which tank you would like to pour the water into: ");
                  tankInto = sc.nextInt();
                  sc.nextLine();
                  System.out.println(" ");
               
                  if (tankA[0]==tankFrom)
                  {
                     if(tankB[1]==tankInto)
                     {
                        tank1.pourTo(tank2);
                        System.out.println("The contents in Tank 1 is " +tank1.getContents() +"cubic cm.");
                        System.out.println("The contents in Tank 2 is " +tank2.getContents() +"cubic cm.");
                     }
                     else if(tankB[2]==tankInto)
                     {
                        tank1.pourTo(tank3);
                        System.out.println("The contents in Tank is " +tank1.getContents() +"cubic cm.");
                        System.out.println("The contents in Tank is " +tank3.getContents() +"cubic cm.");
                     }
                     else 
                        System.out.println("Invalid fish tank number. Please choose again.");
                  } 
                  
                  else if (tankA[1]==tankFrom)
                  {
                     if(tankB[0]==tankInto)
                     {
                        tank2.pourTo(tank1);
                        System.out.println("The contents in Tank 2 is " +tank2.getContents() +"cubic cm.");
                        System.out.println("The contents in Tank 1 is " +tank1.getContents() +"cubic cm.");
                     }
                     else if(tankB[2]==tankInto)
                     {
                        tank2.pourTo(tank3);
                        System.out.println("The contents in Tank 2 is " +tank2.getContents() +"cubic cm.");
                        System.out.println("The contents in Tank 3 is " +tank3.getContents() +"cubic cm.");
                     }
                     else 
                        System.out.println("Invalid fish tank number. Please choose again.");
                  } 
                  
                  else if (tankA[2]==tankFrom)
                  {
                     if(tankB[0]==tankInto)
                     {
                        tank3.pourTo(tank1);
                        System.out.println("The contents in Tank 3 is " +tank3.getContents() +"cubic cm.");
                        System.out.println("The contents in Tank 1 is " +tank1.getContents() +"cubic cm.");
                     }
                     else if(tankB[1]==tankInto)
                     {
                        tank3.pourTo(tank2);
                        System.out.println("The contents in Tank 3 is " +tank3.getContents() +"cubic cm.");
                        System.out.println("The contents in Tank 2 is " +tank2.getContents() +"cubic cm.");
                     }
                     else 
                        System.out.println("Invalid fish tank number. Please choose again.");
                  }          

      case 3:
                  if (tank1.getContents() > tank2.getContents() && tank1.getContents() > tank3.getContents())
System.out.println("Tank 1 has the biggest content.");

else if (tank2.getContents() > tank1.getContents() && tank2.getContents() > tank3.getContents())
System.out.println("Tank 2 has the biggest content.");

else if (tank3.getContents() > tank1.getContents() && tank3.getContents() > tank1.getContents())
System.out.println("Tank 3 has the biggest content.");

 
                  break;
               case 4:
                  System.out.println("Thank you for using Fish Tank App!");
                  break;
               default:
                  System.out.println("Invalid choice!");
                  break;
 

while (choice != 4);

public static void displayMenu(); {
System.out.println("Fish Shop Menu");
System.out.println("===========================================");
System.out.println("1. Add water to to a fish tank");
System.out.println("2. Pour water from one tank to another tank");
System.out.println("3. Show biggest content");
System.out.println("4. Exit");
}
}
}   

Error says
FishShopApp1.java:193: illegal start of expression
public static void displayMenu(); {
^
FishShopApp1.java:202: while expected
}


I'm using jGrasp is that helps. I'm seriously stumped at this.

Thanks for any help
[ August 13, 2006: Message edited by: fred rosenberger ]

[Campbell Ritchie]

Welcome to the Ranch.

There is a list of compiler error messages here, but in my experience "illegal start of expression" has to do with pairing off {}. It usually means you have one more { than you think, or one } fewer; the compiler thinks you are still inside a method. Unfortunately, unlike some IDEs, JGrasp doesn't automatically pair off () [] and {}.
Go back and count all your { and } and I think that will sort out your problem.

If you get the error with {} the other way round, it tens to say something like "class or interface expected."

CR

[Ilja Preuss]

From looking at just the error message, there seems to be a semicolon at an odd place...

[Dave Robbins]

it may just be the way the forum is displaying your code, but it's good programming practice to indent your code properly
it's easier to read and helps a lot keeping the curly braces paired up correctly

Dave

[Campbell Ritchie]

Posted by David Robbins

indent your code properly

The way to keep indentation on the forum is to use "code" tags, from the "code" button below the "message" box.

[fred rosenberger]

i edited your original post to take out the 'quote' tags, and put in 'code' tags. this restored the formatting/indentation.

I haven't spent much time looking at this, but i'm pretty sure you don't want this:

while (choice != 4);

it's either going to give you an infinite loop, or do nothing.

the error message is most likely because your braces are off. the second-to-last brace actually is closing your switch statement (which i'm pretty sure is long after you mean to close it), and the last brace currently closes your do-loop. make sure you have all the braces you need...

[Campbell Ritchie]

I think the (while choice != 4); bit is supposed to be the end of the "do-while" loop.
I am still not sure the thing will work even when the braces are sorted out. I can't understand how the pourTo() method in the FishTank class works, though I can guess the addIn() method.
There is also the risk of adding more water in the constructor than the tank will actually hold.
There is more in the assignment which I think will lose marks.

[fred rosenberger]

I think the (while choice != 4); bit is supposed to be the end of the "do-while" loop.

ahh... that makes sense. i always miss that when the formatting isn't right (and sometimes when it is.

but i'm still pretty sure there are missing braces.