need help to resolve protected clone() error

[Jesse Crockett]

For the following code, I see this error:

CloneTest.java:66: clone() has protected access in java.lang.Object
cloned.address = (Address) address.clone();

import java.util.*;
 
public class CloneTest {
 
public static void main(String[] args) {

try{

Employee original = new Employee("John Q. Public", 50000);
original.setAddress("1501 23rd", "Lawrence", "KS", "66044");
Employee copy = original.clone();
copy.raiseSalary(10);
copy.setAddress("7611 Flint", "Shawnee", "KS", "66214");
System.out.println("original = " + original);
System.out.println("copy = " + copy);

} catch (CloneNotSupportedException e) {

e.printStackTrace();
}

} // end main
 
} // end CloneTest
 
class Employee implements Cloneable {
 
private String name;
private double salary;
private Address address;
 
public Employee(String n, double s) {

name = n;
salary = s;
}

class Address {

String street;
String city;
String state;
String zip;

Address(String strt, String c, String st, String z) {

street = strt;
city = c;
state = st;
zip = z;
}

public String toString() {

return "\n" + street + "; " + city + ", " + state + " " + zip;
}

} // end Address

public Employee clone() throws CloneNotSupportedException {

// call Object.clone()
Employee cloned = (Employee) super.clone();

//clone mutable fields
cloned.address = (Address) address.clone();

return cloned;
}

/**
Set the address to the given address
@param strt the street of the address
... city, state, zip ...
*/
public void setAddress(String strt, String c, String st, String z) {

address = new Address(strt, c, st, z);
}

public void raiseSalary(double byPercent) {

double raise = salary * byPercent / 100;
salary += raise;
}

public String toString() {

return "Employee [name = " + name 
+ ", salary = " + salary
+ ", address = " + address
+ "]";
}

} // end Employee

[Ken Blair]

It is a bit confusing. I believe you need to override the method in your Address class. You can leave it as protected and just return super.clone() if that's acceptable. Also, bring your salt shaker as I can't recollect ever using protected nor do I use Cloneable so it's entirely possible I'm spewing misinformation as it's not something I generally bother with on either count.

[Rahul Bhattacharjee]

Address should implement Clonnable interface and should override the clone method to make this work.