lame objects question

[Keenan Staffieri]

Hi,

It makes me feel inferior to ask this, but I have a question about objects in classes. Well I am working with a canvas, and I decided that I want to make a seperate object to have contructors that keeps track of screenwidth ect.

like:

package worldgenerator;
 
public class ProgramSetting {

private int screenWidth;
private int screenHeight;
private int sleepDelay;
private int tileSize;

public ProgramSetting(int width, int height, int delay, int size) {
screenWidth  = width;
screenHeight = height;
sleepDelay   = delay;
tileSize     = size;
}

public int getScreenWidth() {
return screenWidth;
}
}

i constructed it in WorldGenerator (which contains my main class)

ProgramSetting setting = new ProgramSetting( 800, // screen width
  600, // screen height
  10,  // sleep delay
  40   // standard map tile size\
  );

I can refer to the setting object anywhere i want in the world generator class. BUT i cant refer to the setting object in a different TileMap class, because it cant recognize symbol because i didnt construct the object in the TileMap class:

package worldgenerator;
import java.awt.Graphics;
import java.util.Random;
 
/****************************
 * WorldGenerator v1.0 
 * + TileMap Class
 * @author Keenan Staffieri
****************************/
 
public class TileMap {
 
/** The value indicating a clear cell */
private final int LIGHT_GRASS = 1;
private final int DARK_GRASS  = 2;
private final int DIRT        = 3;
private final int SAND        = 4;
private final int WATER       = 5;

/** The value indicating a blocked cell */
//private static final int STATIC = 1;

/** The sprite that represents this entity */
protected Sprite tileGraphic;

/** The current x location of this entity */ 
protected int xPos;
/** The current y location of this entity */
protected int yPos;

Random rand = new Random();

private int random;
private final int VISIBLE = 0;
private final int HIDDEN  = 1;

private String mapName;

/** The width in grid cells of the map */
private int MAP_WIDTH;
/** The height in grid cells of the map */
private int MAP_HEIGHT;

/** The rendered size of the tile (in pixels) */
private int TILE_SIZE;

/** The actual data for our map */
private int[][] tile    = new int[0][0];
private int[][] tileVis = new int[0][0];
 
public TileMap(String ref, int width, int height, int x, int y, int size) {

this.mapName = ref;
this.MAP_WIDTH  = width;
this.MAP_HEIGHT = height;
this.xPos = x;
this.yPos = y;
this.TILE_SIZE = size;
this.tile    = new int[MAP_WIDTH][MAP_HEIGHT];
this.tileVis = new int[MAP_WIDTH][MAP_HEIGHT];

/** DIRECT CONTROL */
/*
this.tile[0][0] = LIGHT_GRASS; this.tile[1][0] = LIGHT_GRASS; this.tile[2][0] = LIGHT_GRASS; this.tile[3][0] = LIGHT_GRASS;
this.tile[0][1] = LIGHT_GRASS; this.tile[1][1] = LIGHT_GRASS; this.tile[2][1] = LIGHT_GRASS; this.tile[3][1] = LIGHT_GRASS;
this.tile[0][2] = LIGHT_GRASS; this.tile[1][2] = LIGHT_GRASS; this.tile[2][2] = LIGHT_GRASS; this.tile[3][2] = LIGHT_GRASS;
*/

for (int i = 0; i < this.MAP_WIDTH; i++) {
for (int j = 0; j < this.MAP_HEIGHT; j++) {

random = rand.nextInt(2)+1;
//if (random==0) { this.tile[i][j] = LIGHT_GRASS; }
if (random==1) { this.tile[i][j] = DARK_GRASS;  }
if (random==2) { this.tile[i][j] = DIRT;        }
//if (random==3) { this.tile[i][j] = SAND;        }
//if (random==4) { this.tile[i][j] = WATER;       }  

this.tileVis[i][j] = HIDDEN;
}
}

for (int i = 0; i < ([B]setting.getScreenWidth()[/B] / TILE_SIZE); i++) {
for (int j = 0; j < (600 / TILE_SIZE); j++) {

this.tileVis[i+(Math.abs(this.xPos/TILE_SIZE))][j+(Math.abs(this.yPos/TILE_SIZE))] = VISIBLE;
}
}
}

public void setX(int amount) {
this.xPos += amount;
}

public void setY(int amount) {
this.yPos += amount;
}

/**
 * Draw this tile to the graphics context provided
 * 
 * @param g The graphics context on which to draw
 */
public void draw(Graphics g) {

for (int i = 0; i < this.MAP_WIDTH; i++) {
for (int j = 0; j < this.MAP_HEIGHT; j++) {
if (this.tileVis[i][j] == VISIBLE) {
if (this.tile[i][j] == LIGHT_GRASS) { this.tileGraphic = SpriteStore.get().getSprite("\\tile_textures\\lightGrass.png"); }
if (this.tile[i][j] == DARK_GRASS)  { this.tileGraphic = SpriteStore.get().getSprite("\\tile_textures\\darkGrass.png");  }
if (this.tile[i][j] == DIRT)        { this.tileGraphic = SpriteStore.get().getSprite("\\tile_textures\\dirt.png");       }
if (this.tile[i][j] == SAND)        { this.tileGraphic = SpriteStore.get().getSprite("\\tile_textures\\sand.png");       }
if (this.tile[i][j] == WATER)       { this.tileGraphic = SpriteStore.get().getSprite("\\tile_textures\\water.png");      }

this.tileGraphic.draw(g, this.xPos+(this.tileGraphic.getWidth()*i), this.yPos+(this.tileGraphic.getHeight()*j));
}
}
}
}
}

So i guess i pretty much messed up my design...
i also tryed using things like static and public, but it feels "wrong" and, it doesnt work anyway. I even tryed to extend the WorldGenerator class, but it causes compile errors with the paramaters in the TileMap constructors.
[ December 06, 2006: Message edited by: Keenan Staffieri ]

[Ulf Dittmer]

The reference to ProgramSetting could either be another parameter of the TileMap constructor, or the TileMap class could have a "setProgramSetting(ProgramSetting)" setter that is invoked after a TileMap object is constructed.

[Keenan Staffieri]

but i never want to change the screenwidth ect, in tile map. i want to make it so i can use the 'setting' object in ANY class, but i guess my design is messed up since i am using the setting thingy in a class that shouldnt have to take screenwidth parameters in the constructor. any recommendations?

[Ulf Dittmer]

You can also make the ProgramSetting object in TileMap public and static, so that any class can get access to it without needing to have a reference to it.