Test User Input Sting to Object

[Steve Dyke]

I can not get the following code to work. It never matches eventhough I know it should:

I unencrypt the password from the remote data then I test it against the user input string.

Connection connection = datasource.getConnection();
   
 
String sql = "SELECT * FROM webprddt6.appusrprf1 WHERE usrid1 = '" + arg0 + "'";
 
Statement sment = connection.createStatement();
 
ResultSet rs = sment.executeQuery(sql);
   
if(rs.next()){



userfname = rs.getString("fname"); /* the column index can also be used */
userlname = rs.getString("lname");
usertype1 = rs.getString("usrtype1");
username = "Welcome " + userfname+userlname+ "- "+usertype1;
userpassword = rs.getString("pword");

PasswordClass unEncriptedpassWord = PasswordClass.getPword(userpassword);


if (arg1.equals(unEncriptedpassWord)){
}
else {
username = "Welcome You are logged on as a Guest!";
userpassword = "";

rs.close(); 
sment.close();
}
}
else {    

[Paul Clapham]

In this code:

if (arg1.equals(unEncriptedpassWord))

I can see that unEncriptedpassWord is a PasswordClass object. But what about arg1? I suspect it is a String. Am I right? If that's the case, it can never be equal to a PasswordClass object. You would have to extract a String from that PasswordClass object and compare that to arg1.

[Michael Labuschagne]

The code below doesn't explain much about what is happening, you'd have to show the code for "PasswordClass" and there is no reference to what the arg1 object/variable is. If it an object and is not overriding the Object classes equals() method than the all that "if statement" is doing is checking if the unEncriptedpassWord object and the arg1 object are the same object.

Please provide more information reqarding the classes involved.

 
PasswordClass unEncriptedpassWord = PasswordClass.getPword(userpassword);
if (arg1.equals(unEncriptedpassWord)){}
 

[Steve Dyke]

Here is my PasswordClass:

public class PasswordClass {
private String password;

public PasswordClass(String pword) {
this.password = pword;
 
}
 
public String getPassWord() {
int lopw = this.password.trim().length();
String uepw = "";
String decriptedletter = "";
for (int i=1; i<lopw; i++) {
decriptedletter = this.password.substring(i-1,i+2);
int sValue = (Integer.parseInt(decriptedletter) - 5)/2;
String cString = new Character((char)sValue).toString();
uepw = uepw + cString;

i = i + 2;

}

this.password = uepw;
return this.password;
 
}
 
public static PasswordClass getPword(String pword) {
return new PasswordClass(pword);

}
}
    

Here is the LogOnConnetion class that calls the PasswordClass:

package com.ibm.drawinginquiry.rational;
 
import java.sql.*;
 
import com.ibm.as400.access.*;
 
public class LogOnConnection{
public String userfname;
public String userlname;
public String usertype1;
public String username;
public String userpassword;
public String unEncriptedpassWord;

public LogOnConnection(String arg0, String arg1){

AS400JDBCDataSource datasource = new AS400JDBCDataSource("gvas400");
    datasource.setUser("drawchg");
    datasource.setPassword("webabc1");
try
 {
Connection connection = datasource.getConnection();
   
 
String sql = "SELECT * FROM webprddt6.appusrprf1 WHERE usrid1 = '" + arg0 + "'";
 
Statement sment = connection.createStatement();
 
ResultSet rs = sment.executeQuery(sql);
   
if(rs.next()){



userfname = rs.getString("fname"); /* the column index can also be used */
userlname = rs.getString("lname");
usertype1 = rs.getString("usrtype1");
username = "Welcome " + userfname+userlname+ "- "+usertype1;
userpassword = rs.getString("pword");

PasswordClass unEncriptedpassWord = PasswordClass.getPword(userpassword);

System.out.println(unEncriptedpassWord.getPassWord());

if (arg1.equals(String.valueOf(unEncriptedpassWord.getPassWord()))){
System.out.println(unEncriptedpassWord.getPassWord());
username = "Welcome You are logged on for real!";
userpassword = "2";

rs.close(); 
sment.close();

}
else {
username = "Welcome You are logged on as a Guest!";
userpassword = "";

rs.close(); 
sment.close();
}
}
else {

username = "Welcome You are logged on as a Guest!";
userpassword = "";

rs.close(); 
sment.close(); 
}
}
 catch (SQLException se)
  {
 System.err.println("Exception creating the database connection: "+se);
 
 }
}
}