Why won't this for loop work?

[colton peterson]

This is supposed to be simple coloring book program, but I can't find out why it is giving me errors.

  package CustomPaint;
 
import java.awt.*;
import java.awt.event.*;
import java.awt.image.*;
import javax.swing.*;
import java.io.*;
import king.lib.util.*;
 
public class CustomPaint{
 

public static void main(String[] args) {
System.out.println("we're in main");
UniCode start = new UniCode();
start.setUpGui();
}
}
class UniCode{
static JFrame frame = new JFrame("CustomPaint");
static JPanel panel = new JPanel();
static JPanel choice = new JPanel();
private JButton next = new JButton("next");
static File dir = new File("F:\\java\\CustomPaint\\class\\temp");
static File[] dirFiles;
static ImageIcon[] imageList;
static Image CurImage;
private PaintFun fun = new PaintFun();
static BufferedImage CurPad;
static Graphics2D painter;
static JPanel ColorPanel;
static CLabel label = new CLabel();
private LMouseList list = new LMouseList();
static int imageCounter = 0; 


public void setUpGui() {
System.out.println("setting up gui");

getImageList();
cycleImage();
CurPad = new BufferedImage(CurImage.getWidth(null),CurImage.getHeight(null),BufferedImage.TYPE_INT_RGB);
painter = CurPad.createGraphics();
ColorPanel = new KColorChooser(painter).getPalette();

Dimension D = new Dimension(90,90);
label.setMinimumSize(D);
label.setMaximumSize(D);
label.setPreferredSize(D);

choice.setLayout(new BoxLayout(choice,BoxLayout.Y_AXIS));

frame.getContentPane().add(BorderLayout.WEST,choice);

fun.addMouseListener(list);
frame.getContentPane().add(BorderLayout.CENTER,fun);
 
choice.add(ColorPanel);
choice.add(label);

next.addActionListener(new nextList());
choice.add(next);

frame.setSize(400,500);
frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
frame.setVisible(true);

System.out.println("gui set up");
}

public void getImageList() {
System.out.println("getting images");

dirFiles = dir.listFiles(new gifFinder());

if(dirFiles == null) {
System.out.println(dirFiles);
} else {
System.out.println("setting up ImageList");
imageList = new ImageIcon[dirFiles.length];

for(int i = 0; i <= dirFiles.length; i++) {
System.out.println("Loop is " + i + " out of " + dirFiles.length);

imageList[i] = new ImageIcon(dirFiles[i].getAbsolutePath());

}
}
}

void setUpBImage(Image I){

painter.drawImage(I,0,0,frame);
}

void cycleImage() {
System.out.println("cycling image");
System.out.println(imageCounter);
System.out.println(imageList);

CurImage = imageList[imageCounter++].getImage();
setUpBImage(CurImage);

}

class PaintFun extends JPanel{


public void paintComponent(Graphics g){
System.out.println("paintfun used");

g.drawImage(CurPad,0,0,frame);
}

}

class nextList implements ActionListener {
public void actionPerformed(ActionEvent event) {
cycleImage();
fun.repaint();
}
}

class LMouseList extends MouseAdapter {
public void mouseClicked(MouseEvent e){
System.out.println("they clicked");

fun.removeMouseListener(list);

Point p = new Point(e.getPoint());

FloodFill filler = new FloodFill(CurPad);
filler.setAntialiased(true);
filler.fill((int) p.getX(),(int) p.getY(),label.getColor());
CurPad = filler.getImage();
fun.repaint();

fun.addMouseListener(list);

System.out.println("it worked!!!!!! ");
}
}

class gifFinder implements FileFilter {
public boolean accept(File pathname) {
return pathname.getName().endsWith(".gif");
}
}
}
 
class CLabel extends JLabel {
Color CColor;
public void setColor(Color c){
CColor = c;
}
public Color getColor() {
if(CColor != null) {
return CColor;
} else {
return KColorChooser.WC;
}
}
 }
  

This is the output

we're in main
setting up gui
getting images
setting up ImageList
Loop is 0 out of 0
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 0
at CustomPaint.UniCode.getImageList(CustomPaint.java:84)
at CustomPaint.UniCode.setUpGui(CustomPaint.java:40)
at CustomPaint.CustomPaint.main(CustomPaint.java:16)

Process completed.

I am pretty sure the for loop in getImageList is throwing the error.
The file dir declared at the beginning is real and the folder it is reffering to has two files, test.gif and test2.gif KcolorChooser is another class in a different file it compiles and runs fine. FloodFill is a flood filling algorithm that I tested and it also works fine.
Any help would be appreciated.

[Ernest Friedman-Hill]

Well, this line is wrong:

for(int i = 0; i <= dirFiles.length; i++) {

If an array has X elements, then a for loop like

for(int i = 0; i <X; i++) {

will visit each element once. Note the "<" rather than "<=". The last element of the array is at index X-1.

Now, the error message suggests that element 0 is out of bounds -- i.e., that there are no files in the list. This is at odds with what you're telling me, so something's not right. One thing you might try: convert the filename to lower case (using String.toLowerCase()) before checking for .gif; although Windows filenames aren't case-sensitive, Java Strings are.

[colton peterson]

Thanks. This forum rocks!