getting a substring from a string

[Avi Sridhar]

Hello everyone,

Please help me out with this .

The below URL is a String

&cardId=11084430&batchId=10&promotionId=xxxx&promoterId=x&status=dormant&cardValue=xx.xx&key=DA7FEBA4F6F8A2E28FC773BE429FBBA1.grovepc.3

&cardId=11084430&batchId=1&promotionId=xxxx&promoterId=x&status=dormant&cardValue=xx.xx&key=DA7FEBA4F6F8A2E28FC773BE429FBBA1.grovepc.3

i am trying to get batchId=10 and batchId=1 from the above string

this is the code i used

   
 
String temp = &cardId=11084430&batchId=10&promotionId=xxxx&promoterId=x&status=dormant&cardValue=xx.xx&key=DA7FEBA4F6F8A2E28FC773BE429FBBA1.grovepc.3
 
if(temp.indexOf("batchId=1")!=-1) prizeDesc = "prize description 1";
else if(temp.indexOf("batchId=10")!=-1) prizeDesc = "prize description 2";
 

Every time i get prizeDesc = prize description 1 printed,

why is it that it is not differenciating the batchId=1 and batchId=10. Please let me know

any alternatives please.

thanks

[Bob Good]

batchId=10 contains the string batchId=1
You could test for batchId=10 first

Or perhaps use a StringTokenizer class.
[ March 07, 2008: Message edited by: Bob Good ]

[Avi Sridhar]

Originally posted by Bob Good:
batchId=10 contains the string batchId=1
You could test for batchId=10 first

Or perhaps use a StringTokenizer class.

[ March 07, 2008: Message edited by: Bob Good ]

Thanks Bob,

will try that out

[Rob Spoor]

String.split should suffice:

String[] params = myString.split("&");
for (String s: params)
{
    String[] keyval = s.split("=");
    if (keyval[0].equals("batchID") && keyval.length > 1)
    {
        // found a batchId element
    }
}

This even allows you to create a Map out of all options, although you must keep in mind that a single key can occur multiple times in these kinds of request parameters.

[Avi Sridhar]

Originally posted by Rob Prime:
String.split should suffice:

String[] params = myString.split("&");
for (String s: params)
{
    String[] keyval = s.split("=");
    if (keyval[0].equals("batchID") && keyval.length > 1)
    {
        // found a batchId element
    }
}

This even allows you to create a Map out of all options, although you must keep in mind that a single key can occur multiple times in these kinds of request parameters.

Thanks, Will try that out too


Thanks for the reply.

[Bill Shirley]

I would split the string by &
take that collection and split each by =
and put all those in a Map

then process to your heart content with much more readable code

[Mike Simmons]

You can also use a regular expression:

Pattern batchIdPattern = Pattern.compile("batchId=(\\d+)");
 
Matcher m = batchIdPattern.matcher(str);
if (m.find()) {
    System.out.println("batchId is" + m.group(1));
} else {
    System.out.println("no batchId found");
}

Whatever the batch ID number is, it becomes group 1 in the pattern, because it's inside the first (and only) pair of parentheses listed in the pattern.
[ March 07, 2008: Message edited by: Mike Simmons ]