recursive methods

[Ravindra Suroju]

Hi all,

I want to print the absolute path of all files (including the files in subfolders) in a given directory [C:/Source]. Please help me what is wrong with my code...

import java.io.File;
 
public class test {
  
  public void getDirectoryList(String Path) {
    String[] dirContents;
    File dir = new File(Path);
    if (dir.isDirectory()) {
      dirContents = dir.list();
      for (int i = 0; i < dirContents.length; i++) {
        File tempFile = new File(dirContents[i]);
        if (tempFile.isFile()) {
          System.out.println("File " + Path + "/" + dirContents[i]);[/b]
        }
        else {
          getDirectoryList(Path + "/" + tempFile.getName());
        }
      }
    }
  }
 
  public static void main(String[] args) {
    test Directory = new test();
    Directory.getDirectoryList("C:" + "/" + "source");
  }
}

[Joanne Neal]

What makes you thing there's something wrong with it ? Does it not compile (show us the error messages) or does it not do what you expected (tell us what it does do and how this differs from what you expected).

[Bob Good]

1) Class names should begin with a capital (Test not test)
2) Instance variables should be non capitalized (directory not Directory, path not Path)
2) You have provided no comments
3) directory.getDirectoryList("/" + args[0]); <== corrected
4) File tempFile = new File(path + "/" + dirContents[i]); <== corrected

You were very close.

[Ravindra Suroju]

Thanks so much Bob...