How?

[Lenny Peter]

How can I write this correctly?

public void setAge(int age)
{
if(age > 0 && age < 18) {
System.out.println("Age:" + age + " " + "this member is junior.");
}
else if(age >= 18) {
System.out.println("Age:" + age +" " + "this member is senior.");
}
else {
System.out.println("The member's age cannot be 0");
}
}

Thanks ;-)

[Darryl Burke]

Umm, so what's wrong with the code you posted? (apart from the unfortunately named method that doesn't in fact set a int field named age.)

[Gary Morris]

Yeah, I don't see why it couldn't work as-is, but would be more meaningful to give it a proper name like:

public void checkAge(int age)
{
if(age > 0 && age < 18)
{// Actually, you could change this to:
System.out.println("Age:" + age + " this member is junior.");
}
else if(age >= 18)
{// And same here, getting rid of the single space concat:
System.out.println("Age:" + age + " this member is senior.");
}
else
{
System.out.println("The member's age cannot be 0");
}
}

[ May 11, 2008: Message edited by: Gary Morris ]

[arulk pillai]

also use of log4j instead of System.out.println might be better.

[Jesper de Jong]

Your method is called 'setAge', but I don't see you setting the entered age anywhere. You only check the value of the parameter. Maybe you intended to save the value in a member variable?

[Kevin Tysen]

Also, I see that if someone passes a negative int to the method, they will get a reply "The age cannot be 0." They might say, "I didn't say 0; I said -7!"

[Gary Morris]

Maybe if you gave a little more info on what it is that you WANT it to do, then someone could offer a little better advice?

[Deepak Bala]

A better title will also help

[Arvind Mahendra]

you also don't need those braces with every if else since you only have single statements.

[Bear Bibeault]

Originally posted by Arvind Birla:
you also don't need those braces with every if else since you only have single statements.

Though many coding conventions state that it's best to include them regardless.