Fractions

[G. Graz]

I am trying to do simple conversion of a "long" fraction to it's Prime number

[G. Graz]

Sorry hit the wrong button ! Ok, so if a fraction is 1/2 then it's good , if the fraction is 3/2 , the method will convert it to 1-1/2. Here is my code:

 
  public String properString(){
 
long a,b;
 
    a = this.getNumerator();
    b = this.getDenominator();
     String result = "";
 if ( a < b)
  {
   result = ( ((a) +"/"+ (b)));
      }
      else if ( a > b)
      {
result = (a/b);
      }
 
     return result.toString();
}
 

    

my "else if" is causing me all the problems ( convert 3/2 to 1-1/2). Any suggestions what I am doing wrong ? I am getting incompatible types when I try to compile, but I though my toString was taking care of that ? Thank you for the insight !! Suggestions always welcome !! Thank you!

Greg

[karthikeyan Chockalingam]

In the else block you can either use
result = Double.toString((a/b));
or
result = ""+(a/b);

Note: a/b is primitive double which does not have a toString method.
[ May 15, 2008: Message edited by: karthi keyan ]

[Campbell Ritchie]

Try printing out a / b and a % b. That's all you need to do. You may end up with � coming out as 0 1/2, and ou will get peculiar results with negative numbers, but you can work out yourself how to deal with that!

[Satya Maheshwari]

You can write something as below:

 public void mixedFraction(int numerator,int denominator)
        {
                String sign = ((numerator/denominator)<0)?"-":"+";
                numerator = Math.abs(numerator);
                denominator = Math.abs(denominator);
                int whole = numerator/denominator;
                numerator = numerator%denominator;
                System.out.println(sign+" " + whole + " " + numerator + "/" + denominator);
        }

[Campbell Ritchie]

Originally posted by Satya Maheshwari:
You can write something as below:

 . . .
    String sign = ((numerator/denominator)<0)?"-":"+";
 . . .

That line won't work correctly, I am afraid.

[Satya Maheshwari]

Originally posted by Campbell Ritchie:
That line won't work correctly, I am afraid.

Thanks for correcting. Very naive on my part . It should be

...
String sign = (((double)numerator/denominator)<0)?"-":"+";
...

[Campbell Ritchie]

That will work, but I think this is better

. . . denominator < 0 ^ numerator < 0 . . .

Work it out. And you ought to throw an Exception if denominator is 0, before reaching that stage.

[Satya Maheshwari]

Originally posted by Campbell Ritchie:
That will work, but I think this is better

. . . denominator < 0 ^ numerator < 0 . . .

Work it out. And you ought to throw an Exception if denominator is 0, before reaching that stage.

Yes I agree 'denominator is 0' case should be handled.
[ May 19, 2008: Message edited by: Satya Maheshwari ]