File APIs for Java Developers
Manipulate DOC, XLS, PPT, PDF and many others from your application.
The moose likes Beginning Java and the fly likes Sorting a string Big Moose Saloon
  Search | Java FAQ | Recent Topics | Flagged Topics | Hot Topics | Zero Replies
Register / Login
JavaRanch » Java Forums » Java » Beginning Java
Bookmark "Sorting a string" Watch "Sorting a string" New topic

Sorting a string

feda alshahwan
Ranch Hand

Joined: Jul 26, 2008
Posts: 170
I am trying to enter a string then output should be the string ordered suppose you enter CDAB output should be ABCD my code is not sorting the string ??

my code is as follows

Compiling 1 source file to C:\Documents and Settings\Moon\My Documents\NetBeansProjects\order1\build\classes
Enter Your Name :
Name after reordering is:CADH
BUILD SUCCESSFUL (total time: 12 seconds)

[HENRY: Added Code Tags]
[ August 08, 2008: Message edited by: Henry Wong ]
Jeanne Boyarsky
author & internet detective

Joined: May 26, 2003
Posts: 33118

This method doesn't do anything. It assigns first and second different values but only within the swap method. It doesn't swap the references in the calling code.

[OCA 8 book] [Blog] [JavaRanch FAQ] [How To Ask Questions The Smart Way] [Book Promos]
Other Certs: SCEA Part 1, Part 2 & 3, Core Spring 3, TOGAF part 1 and part 2
Norm Radder
Ranch Hand

Joined: Aug 10, 2005
Posts: 692
Look up the terms "call by reference" and "call by value". Youcould be a C programmer because your code assumes the method is called by reference.
To use your method logic, you'll have to pass the full string to the method along with the indexes of the chars to be swapped. Then build and return a new string with those chars swapped.
feda alshahwan
Ranch Hand

Joined: Jul 26, 2008
Posts: 170
How to fix the problem if I can not pass by reference. Can you guide me please?
Ulf Dittmer

Joined: Mar 22, 2005
Posts: 42965
A method definition like this would work:
Graeme Byers
Ranch Hand

Joined: Apr 16, 2004
Posts: 127
The ranchers' diagnosis of your bug is correct.
However with mutable objects (even when marked final):

Your code could be simplified :
Norm Radder
Ranch Hand

Joined: Aug 10, 2005
Posts: 692
Arrays.sort(charArray) ;

How does the OP learn how to code if he uses a built in method?
beginners need to do it the hard way first to learn how to loop and index.
I agree. Here's the link:
subject: Sorting a string
It's not a secret anymore!