Upload Download File

[Ramy Raslan]

i uploaded this .txt file

StartText{{{{{}}}}}EndText

but it into a DB2 Blop then download it in OutputStream

find this file

-----------------------------311112870412835 Content-Disposition: form-data; name="file"; filename="New Text Document.txt" Content-Type: text/plain StartText{{{{{}}}}}EndText -----------------------------311112870412835 Content-Disposition: form-data; name="SUBMIT" UPLOAD -----------------------------311112870412835--

as you can see any edit to the response is written to the OutputStream
which destroy all .doc and .jpeg file
can any one help

[Bear Bibeault]

Not without seeing your file handling code.

It looks as if the header values are being written to the file for some reason.

[Ramy Raslan]

Upload form

<form action="/ProjectBlobWeb/ToDBUpload"
enctype="multipart/form-data" method="POST">
<input name=file type=FILE class="style6" size="40" Accept="*.rar"> <br>
<input name="SUBMIT" type=SUBMIT class="style6" value="UPLOAD">
</form>

Upload servlet

protected void doPost(HttpServletRequest request, HttpServletResponse response) 
throws ServletException, IOException {
PrintWriter out = response.getWriter();
 
out.println("Uploading your file. Please wait...");
 
String saveFile = "";
String contentType = request.getContentType();
if ((contentType != null)
&& (contentType.indexOf("multipart/form-data") >= 0)) {
DataInputStream in = new DataInputStream(request.getInputStream());
int formDataLength = request.getContentLength();
byte dataBytes[] = new byte[formDataLength];
int byteRead = 0;
int totalBytesRead = 0;
while (totalBytesRead < formDataLength) {
byteRead = in.read(dataBytes, totalBytesRead, formDataLength);
totalBytesRead += byteRead;
}
try {
String file = new String(dataBytes);
saveFile = file.substring(file.indexOf("filename=\"") + 10);
saveFile = saveFile.substring(0, saveFile.indexOf("\n"));
saveFile = saveFile.substring(saveFile.lastIndexOf("\\") + 1,
saveFile.indexOf("\""));
int lastIndex = contentType.lastIndexOf("=");
String boundary = contentType.substring(lastIndex + 1,
contentType.length());
int pos;
pos = file.indexOf("filename=\"");
pos = file.indexOf("\n", pos) + 1;
pos = file.indexOf("\n", pos) + 1;
pos = file.indexOf("\n", pos) + 1;
int boundaryLocation = file.indexOf(boundary, pos) - 4;

int startPos = ((file.substring(0, pos)).getBytes()).length;
 
int endPos = ((file.substring(0, boundaryLocation)).getBytes()).length;

HttpSession session=request.getSession();
String projectId = (String)session.getAttribute("projectId");

if (projectId==null){
projectId = "000004";
}
 
com.model.DBConnection dbconn = new com.model.DBConnection();
 
if (dbconn != null) {
try {
dbconn.connect();
 
dbconn.insertBlobPROJECT.setString(1, saveFile);
dbconn.insertBlobPROJECT.setBytes(2, dataBytes);
dbconn.insertBlobPROJECT.setString(3, projectId);
dbconn.insertBlobPROJECT.execute();
 

} catch (SQLException e) {
}
} else {
out.print("there's no connection");
}

request.setAttribute("fileName", saveFile);
session.setAttribute("projectId", projectId);
 
RequestDispatcher view = request
.getRequestDispatcher("Uploadnext.jsp");
view.forward(request, response);
 
} catch (Exception e) {
} finally {
try {} catch (Exception err) {
}
}
}
}

Download servlet

protected void doGet(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {

HttpSession session=request.getSession();
String projectId = (String)session.getAttribute("projectId");

String fileName ="";
byte[] fileBytes = null;

if (projectId==null){
projectId = "000004";
}
com.model.DBConnection dbconn = new com.model.DBConnection();
 
if (dbconn != null) {
dbconn.connect();
 
try {
dbconn.selectBlobPROJECT.setString(1, projectId);
ResultSet rs=dbconn.selectBlobPROJECT.executeQuery();
while (rs.next()) {
fileName = rs.getString("ATTACHMENT_NAME");
Blob b = rs.getBlob("ATTACHMENT");
fileBytes = b.getBytes(1, (int)b.length());
}
} catch (SQLException e) {
e.printStackTrace();
}
 
} else {}

String fileType = fileName.substring(fileName.indexOf(".")+1,fileName.length());
 

if (fileType.trim().equalsIgnoreCase("txt"))
{
response.setContentType( "text/plain" );
}
else if (fileType.trim().equalsIgnoreCase("doc"))
{
response.setContentType( "application/msword" );
}
else if (fileType.trim().equalsIgnoreCase("xls"))
{
response.setContentType( "application/vnd.ms-excel" );
}
else if (fileType.trim().equalsIgnoreCase("pdf"))
{
response.setContentType( "application/pdf" );
}
else if (fileType.trim().equalsIgnoreCase("ppt"))
{
response.setContentType( "application/ppt" );
}
else if (fileType.trim().equalsIgnoreCase("jpg"))
{
response.setContentType( "image/jpeg" );
}
else
{
response.setContentType( "application/octet-stream" );
}
 
response.setHeader("Content-Disposition","attachment; filename=\""+fileName+"\"");
response.setHeader("cache-control", "no-cache");
 
OutputStream outs = response.getOutputStream();
outs.write(fileBytes);
outs.flush();
outs.close();
}

[Ben Souther]

Why are you parsing the multipart form yourself when there are already libraries out there for free that have already been written an battle tested?

[Ramy Raslan]

thanks for your reply can i ask you for some names of this libraries

[Ramy Raslan]

it works it just needed to be but into anther array of bytes
using the start position and end position

  
byte realDataBytes[]= new byte[endPos-startPos] ;
for(int i = startPos,j =0;i<endPos;i++,j++){
realDataBytes[j]=dataBytes[i];  
}

dbconn.insertBlobPROJECT.setString(1, saveFile);
dbconn.insertBlobPROJECT.setBytes(2, realDataBytes);
dbconn.insertBlobPROJECT.setString(3, projectId);
dbconn.insertBlobPROJECT.execute();

[ December 14, 2008: Message edited by: Ray Man ]
[ December 14, 2008: Message edited by: Ray Man ]

[Bauke Scholtz]

Honestly, that's very horrible code. This smells like a ripoff from roseindia.net. Please ignore that site forever, it almost only shows bad code examples and introduces bad practies. It's maintained by amateurs with the only focus on advertisement incomes.

To handle file upload I highly recommend you the Apache Commons FileUpload API. Here it is: http://commons.apache.org/fileupload Especially read the 'User Guide' section how to use it. It's fairly easy. For trouble or just for tips/tricks consult the 'Frequently Asked Questions' section. It's simply great stuff; thoroughly tested in all known situations and highly reliable.
[ December 14, 2008: Message edited by: Bauke Scholtz ]

[Ramy Raslan]

yes i know that but sadly i work on rational 6
which is the worst IDE you can see and it give me hard times
in my DB connection which is DB2 v8.1 express
bottom line i was in too much trouble with the db2 driver import to import any other jar

but thanks any way for the heads up i will sure take it in
consideration in the future

[Bauke Scholtz]

RAD is fine. You must be doing the stuff wrong.