Problem with ActionListener and JButtons (harder than it first seems

[Thomas FairBanks]

This program copies the iPhone sort of:

    package iphone;
 
import java.awt.BorderLayout;
import java.awt.CardLayout;
import java.awt.Color;
import java.awt.FlowLayout;
import java.awt.Font;
import java.awt.GridLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
 
 
import java.util.Calendar;
import javax.swing.ImageIcon;
import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JOptionPane;
import javax.swing.JPanel;
import javax.swing.JSlider;
import javax.swing.JTextArea;
import javax.swing.JTextField;
import javax.swing.SwingUtilities;
import javax.swing.UIManager;
import javax.swing.event.ChangeEvent;
import javax.swing.event.ChangeListener;
 
public class iPhoneJava extends JFrame implements ActionListener {
 
    String currentCard;
    CardLayout screens = new CardLayout();
    //Card for every program, plus homescreen and slider
    JButton sms, cal, photo, camera, youtube, stocks, maps, weather, clock, calculator, notes, settings, phone, mail, safari, ipod;
    MiddleButtons mb = new MiddleButtons();
    BottomButtons bb = new BottomButtons();
    public static final String HOME_SCREEN = "HOME";
    public static final String SLIDER_SCREEN = "SLIDER";
    public static final String TEXT_SCREEN = "TEXT";
    public static final String CALENDAR_SCREEN = "CALENDAR";
    public static final String PHOTOS_SCREEN = "PHOTOS";
    //Camera will probably not be added, 
    //too much hassle to detect and access the computer's webcam.
    public static final String CAMERA_SCREEN = "CAMERA";
    public static final String YOUTUBE_SCREEN = "YOUTUBE";
    public static final String STOCKS_SCREEN = "STOCKS";
    public static final String MAPS_SCREEN = "MAPS";
    public static final String WEATHER_SCREEN = "WEATHER";
    public static final String CLOCK_SCREEN = "CLOCK";
    public static final String CALCULATOR_SCREEN = "CALCULATOR";
    public static final String NOTES_SCREEN = "NOTES";
    public static final String SETTINGS_SCREEN = "SETTINGS";
    public static final String PHONE_SCREEN = "PHONE";
    public static final String MAIL_SCREEN = "MAIL";
    public static final String SAFARI_SCREEN = "SAFARI";
    public static final String IPOD_SCREEN = "IPOD";
    public static final JButton homeButton = new JButton("Home");
 
    public iPhoneJava() {
 
        super("iPhone- Java Style");
        setSize(400, 500);
        setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        setResizable(false);
        setLookAndFeel();
        setLayout(screens);
        //Slider (Don't get why this doesn't work)
 
        JSlider slide = new JSlider(0, 50, 0);
        slide.setPaintTicks(false);
        slide.setPaintLabels(false);
        slide.addChangeListener(new SliderListener());
        class SliderListener implements ChangeListener {
 
            public void stateChanged(ChangeEvent e) {
                JSlider sourceSlider = (JSlider) e.getSource();
                if (sourceSlider.getValueIsAdjusting()) {
                    int slideInt = (int) sourceSlider.getValue();
                    if (slideInt > 0) {
                        screens.show(getContentPane(), HOME_SCREEN);
 
                    }
                }
            }
        }
        add(slide, SLIDER_SCREEN);
 
        setVisible(true);
        homeButton.addActionListener(this);
 
//        Home Screen
        HomeScreen hs = new HomeScreen();
        add(hs, HOME_SCREEN);
        //Text
        JPanel textPanel = new JPanel();
        JTextArea text = new JTextArea(8, 35);
        text.setLineWrap(true);
        JButton sendText = new JButton("Send Text");
        textPanel.add(text);
        textPanel.add(sendText);
        textPanel.add(homeButton);
        add(textPanel, TEXT_SCREEN);
        //Calendar
        JLabel[] days = new JLabel[28];
        JLabel[] dayTitles = new JLabel[7];
        JLabel monthTitle = new JLabel("February");
        JPanel pane = new JPanel();
        FlowLayout flow = new FlowLayout();
        pane.setLayout(flow);
        JPanel titlePane = new JPanel();
        titlePane.setLayout(flow);
        titlePane.add(monthTitle);
        pane.add(titlePane);
        JPanel monthPane = new JPanel();
        GridLayout calLayout = new GridLayout(5, 7, 5, 5);
        monthPane.setLayout(calLayout);
        String[] dayNames = {"Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"};
        for (int i = 0; i < 7; i++) {
            dayTitles[i] = new JLabel(dayNames[i]);
            monthPane.add(dayTitles[i]);
        }
        for (int i = 0; i < days.length; i++) {
            days[i] = new JLabel("" + (i + 1));
            monthPane.add(days[i]);
        }
        pane.add(monthPane);
        pane.add(homeButton);
        add(pane, CALENDAR_SCREEN);
 
        //Photos
        JLabel photoLabel = new JLabel("Feature not yet added");
        add(photoLabel, PHOTOS_SCREEN);
        add(homeButton, PHOTOS_SCREEN);
 
        //Camera
        JLabel cameraLabel = new JLabel("Camera not going to be added. Skip to next Program");
        add(cameraLabel, CAMERA_SCREEN);
        add(homeButton, CAMERA_SCREEN);
        //YouTube
        JLabel youtubeLabel = new JLabel("Sorry, yet another feature that won't be added. Open your browser.");
        add(youtubeLabel, YOUTUBE_SCREEN);
        add(homeButton, YOUTUBE_SCREEN);
 
        //Stocks
        JLabel stockLabel = new JLabel("Ok, this one and the map feature won't exist. Weather will be bogus. \n" +
                "The Clock will work though!!!");
        add(stockLabel, STOCKS_SCREEN);
        add(homeButton, STOCKS_SCREEN);
 
        //Maps
        JLabel mapLabel = new JLabel("Go to a different program...");
        add(mapLabel, MAPS_SCREEN);
        add(homeButton, MAPS_SCREEN);
 
        //weather
        JLabel weatherLabel = new JLabel("The temperature today is 56�. Not bad...");
        add(weatherLabel, WEATHER_SCREEN);
        add(homeButton, WEATHER_SCREEN);
 
        //Clock (this took forever...)
        final JTextField _timeField;
        _timeField = new JTextField(5);
        _timeField.setEditable(false);
        _timeField.setFont(new Font("sansserif", Font.PLAIN, 48));
 
        JPanel content = new JPanel();
        content.setLayout(new FlowLayout());
        content.add(_timeField);
        content.add(homeButton);
        content.setBackground(Color.BLACK);
        content.setVisible(true);
 
 
        class ClockListener implements ActionListener {
 
            public void actionPerformed(ActionEvent event) {
 
                Calendar now = Calendar.getInstance();
                int h = now.get(Calendar.HOUR_OF_DAY);
                if (h > 12) {
                    h = h - 12;
                }
 
                int m = now.get(Calendar.MINUTE);
                int s = now.get(Calendar.SECOND);
                _timeField.setText("" + h + ":" + m + ":" + s);
 
            }
        }
        javax.swing.Timer t = new javax.swing.Timer(1000, new ClockListener());
        t.start();
        add(content, CLOCK_SCREEN);
 
        //Calculator (Don't get why this doesn't work)
 
        final JButton add = new JButton("+");
        final JButton subtract = new JButton("-");
        final JButton multiply = new JButton("x");
        final JButton divide = new JButton("�");
        JPanel calcPane = new JPanel();
        final JTextField field1 = new JTextField(null, 5);
        final JTextField field2 = new JTextField(null, 5);
        add.addActionListener(this);
        subtract.addActionListener(this);
        multiply.addActionListener(this);
        divide.addActionListener(this);
        calcPane.setLayout(new FlowLayout());
        calcPane.add(field1);
        calcPane.add(add);
        calcPane.add(subtract);
        calcPane.add(multiply);
        calcPane.add(divide);
        calcPane.add(field2);
        calcPane.add(homeButton);
        add(calcPane, CALCULATOR_SCREEN);
 
 
        class iCalculator extends JPanel implements ActionListener {
 
            public void actionPerformed(ActionEvent evt) {
                Object source = evt.getSource();
                float answerFloat = 0;
 
                try {
                    float value1 = Integer.parseInt(field1.getText());
                    float value2 = Integer.parseInt(field2.getText());
 
                    if (source == add) {
                        answerFloat = value1 + value2;
                        JOptionPane.showMessageDialog(null, "Answer: " + answerFloat);
 
                    } else if (source == subtract) {
                        answerFloat = value1 - value2;
                        JOptionPane.showMessageDialog(null, "Answer: " + answerFloat);
                    } else if (source == multiply) {
                        answerFloat = value1 * value2;
                        JOptionPane.showMessageDialog(null, "Answer: " + answerFloat);
                    } else if (source == divide) {
                        answerFloat = value1 / value2;
                        JOptionPane.showMessageDialog(null, "Answer: " + answerFloat);
                    }
 
                } catch (NumberFormatException e) {
                    JOptionPane.showMessageDialog(null, "Please enter numbers only");
                    field1.setText("");
                    field2.setText("");
                }
 
 
            }
        }
 
        //Notes
        JPanel notesPanel = new JPanel();
        notesPanel.setBackground(Color.BLACK);
 
        JTextArea notesArea = new JTextArea("Enter Your Notes Here.", 10, 35);
        float hhsb = 64;
        float shsb = 8;
        float vhsb = 100;
        notesArea.setBackground(Color.getHSBColor(hhsb, shsb, vhsb));
        notesPanel.add(notesArea);
        notesPanel.add(homeButton);
        add(notesPanel, NOTES_SCREEN);
        //System Settings \ about this program
        JTextArea settingsArea = new JTextArea("ABOUT THIS PROGRAM \n This program was designed as a plaything for " +
                "Apple iPhone aficionados. This program actually does not aid the user in achieving anything." +
                "The creator of this program is only affiliated with Apple because he owns a Mac and an iPod.", 10, 35);
        settingsArea.setEditable(false);
        add(settingsArea, SETTINGS_SCREEN);
        add(homeButton, SETTINGS_SCREEN);
 
 
 
        screens.show(getContentPane(), NOTES_SCREEN);
 
    }
 
    public class HomeScreen extends JPanel {
 
        public HomeScreen() {
            //JPanel iPhone = new JPanel();
            JPanel iPhone = this;
            iPhone.setBackground(Color.BLACK);
            iPhone.setForeground(Color.WHITE);
            iPhone.setLayout(new BorderLayout(2, 1));
            iPhone.add("South", bb);
            iPhone.add("Center", mb);
 
 
        }
    }
 
    public class MiddleButtons extends JPanel implements ActionListener {
 
        public MiddleButtons() {
            JPanel panel = new JPanel();
            panel.setBackground(Color.BLACK);
            panel.setForeground(Color.BLACK);
            GridLayout mainButtons = new GridLayout(3, 4, 6, 6);
            ImageIcon smsIcon = new ImageIcon("sms.png");
            ImageIcon calIcon = new ImageIcon("cal.png");
            ImageIcon photoIcon = new ImageIcon("wallpaper.png");
            ImageIcon cameraIcon = new ImageIcon("photo.png");
            ImageIcon youtubeIcon = new ImageIcon("youtube.png");
            ImageIcon stocksIcon = new ImageIcon("graph.png");
            ImageIcon mapsIcon = new ImageIcon("map.png");
            ImageIcon weatherIcon = new ImageIcon("weather.png");
            ImageIcon clockIcon = new ImageIcon("clock.png");
            ImageIcon calculatorIcon = new ImageIcon("calc.png");
            ImageIcon notesIcon = new ImageIcon("notes.png");
            ImageIcon settingsIcon = new ImageIcon("tools.png");
            JButton textButton = new JButton(smsIcon);
            JButton calendarButton = new JButton(calIcon);
            JButton photosButton = new JButton(photoIcon);
            JButton cameraButton = new JButton(cameraIcon);
            JButton youtubeButton = new JButton(youtubeIcon);
            JButton stocksButton = new JButton(stocksIcon);
            JButton mapsButton = new JButton(mapsIcon);
            JButton weatherButton = new JButton(weatherIcon);
            JButton clockButton = new JButton(clockIcon);
            JButton calculatorButton = new JButton(calculatorIcon);
            JButton notesButton = new JButton(notesIcon);
            JButton settingsButton = new JButton(settingsIcon);
            // add to panel
            panel.setLayout(mainButtons);
            panel.add(textButton);
            textButton.addActionListener(this);
            panel.add(calendarButton);
            calendarButton.addActionListener(this);
            panel.add(photosButton);
            photosButton.addActionListener(this);
            panel.add(cameraButton);
            cameraButton.addActionListener(this);
            panel.add(youtubeButton);
            youtubeButton.addActionListener(this);
            panel.add(stocksButton);
            stocksButton.addActionListener(this);
            panel.add(mapsButton);
            mapsButton.addActionListener(this);
            panel.add(weatherButton);
            weatherButton.addActionListener(this);
            panel.add(clockButton);
            clockButton.addActionListener(this);
            panel.add(calculatorButton);
            calculatorButton.addActionListener(this);
            panel.add(notesButton);
            notesButton.addActionListener(this);
            panel.add(settingsButton);
            settingsButton.addActionListener(this);
            //add(panel);
            //setLookAndFeel();
            setVisible(true);
 
        }
        [B]public void actionPerformed(ActionEvent e) {------------
            Object progSel = e.getSource();-------------------
            if (progSel == textButton) ------------------------
                screens.show(getContentPane(), TEXT_SCREEN);    --------THESE LINES HERE
            if (progSel == calendarButton)-----------------------
                screens.show(getContentPane(), CALENDAR_SCREEN);[/B]--------
        }
    }
 
    public class BottomButtons extends JPanel {
 
        public BottomButtons() {
            JPanel south = new JPanel();
            south.setBackground(Color.BLACK);
            GridLayout bottom = new GridLayout(1, 4, 2, 2);
            //create icons
            ImageIcon phoneIcon = new ImageIcon("phone.png");
            ImageIcon mailIcon = new ImageIcon("mail.png");
            ImageIcon safariIcon = new ImageIcon("browser.png");
            ImageIcon ipodIcon = new ImageIcon("ipod.png");
            //create buttons
            JButton phoneButton = new JButton(phoneIcon);
            phoneButton.setBackground(Color.gray);
            JButton mailButton = new JButton(mailIcon);
            mailButton.setBackground(Color.gray);
            JButton safariButton = new JButton(safariIcon);
            safariButton.setBackground(Color.gray);
            JButton ipodButton = new JButton(ipodIcon);
            ipodButton.setBackground(Color.gray);
            south.setLayout(bottom);
            south.add(phoneButton);
            south.add(mailButton);
            south.add(safariButton);
            south.add(ipodButton);
            add(south);
 
            setVisible(true);
        }
    }
 
    public class Text extends JPanel {
    }
 
    public void setLookAndFeel() {
        try {
            UIManager.setLookAndFeel(
                    UIManager.getCrossPlatformLookAndFeelClassName());
            SwingUtilities.updateComponentTreeUI(this);
        } catch (Exception e) {
            System.err.println("Couldn't use the system" +
                    "look and feel: " + e);
        }
 
    }
 
    public static void main(String[] arguments) {
        iPhoneJava javaiphone = new iPhoneJava();
        javaiphone.setBackground(Color.BLACK);
    }
 
    public void actionPerformed(ActionEvent e) {
        Object source = e.getSource();
        if (source == homeButton) {
            screens.show(getContentPane(), HOME_SCREEN);
        }
    }
}

My problem (lines in bold) is that the buttons that I add the ActionListener to are not in the same class as actionPerformed. When I tried to make the JButtons public (outside of the current class), it gave me some exceptions. What can I do to properly add this ActionListener?
[ October 31, 2008: Message edited by: Thomas FairBanks ]

[Ilja Preuss]

The best solution for this problem is to use a different ActionListener per Button - then there is no need to call e.getSource at all.

[Campbell Ritchie]

And welcome to JavaRanch

Thank you, Ilja; you actually had the patience to read all that code!

[Ilja Preuss]

Originally posted by Campbell Ritchie:

Thank you, Ilja; you actually had the patience to read all that code!

Didn't. Just read the bold lines.

[Campbell Ritchie]

Originally posted by Ilja Preuss:
Just read the bold lines.

In which case, thank you Thomas FairBanks, for marking the location of the problem.

[Thomas FairBanks]

Wow, can't believe I didn't think of that. Thanks Ilja